From patchwork Fri Apr 20 14:52:39 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 133883 Delivered-To: patches@linaro.org Received: by 10.46.66.142 with SMTP id h14csp374919ljf; Fri, 20 Apr 2018 07:52:54 -0700 (PDT) X-Google-Smtp-Source: AIpwx49Jpv70uLgJhiH6vOoJLYWfUg3JnKUzoYgugMvMxOMf84VkBlCBePYlJTpi2byWYKY+bSup X-Received: by 2002:a17:902:2f84:: with SMTP id t4-v6mr10804997plb.24.1524235974549; Fri, 20 Apr 2018 07:52:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524235974; cv=none; d=google.com; s=arc-20160816; b=VM4xGPIaOER+ciQxLay6KFtvJwDLbllO6J9OPLXhBYW4hSX0VJysL3wF0JLHQLVXj5 xuklcEXgZHhrs+uE2aOF/9NHKql57DbshDY0IyOu4pICOQOoXij9FJKYzeZoSdJZBXE8 YZSFjLvw6DxVUgOe4rdZ9aBkqD7voYrNsqm4CkxTfDgJfNHeCMbraJKsBAOkqVRcMjFU vF9O97/cI9CY76qf9MWvAYmAzE9lw3UE7Ezykm7tfV5Nevp+R1ELuSdLW/lPOiPDYUS8 ktOICz3wCrJodk38dTWtxABhMFYgSq1Arx0dXlNlAfyjGB6APiLfCxCWWyVe753vVtCP cstw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=Lt3jaGwVxKCIvZC7Hkn6qOt5guOz6wEvrjQhKp5vUGQ=; b=N3sE4WdGcC/YOyROtC2Iseczs9LGPALSWDdkWnU2WixsW4g3GN7t3NYltqgMG0DIEq Rerjwsq9xfr9OHRvzoC4ZYNsqwFnTmxyCEoq7U1eh9ES9Qb5aSgJq8AX1MVPa2oWzZOa NFBuz55lUobFzHLTVAfSGTpBOhYm0SH6u4/YaabiJRYU7qj9RvFWXmFsCjIUi3YF+5cE uuq3ggWp16lNN1I/dT3MNjemQwxlaQst+wcdWXXQEFBr7H7iXFHD75NKjwmFNumWfHEV munybISSqUISOGLzpzTogVi/GALbc3q0GHRgfN+1fiZvWIOUQQT2rQfF2Tyj5mInHT+F 48pg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of pm215@archaic.org.uk designates 2001:8b0:1d0::2 as permitted sender) smtp.mailfrom=pm215@archaic.org.uk; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by mx.google.com with ESMTPS id c6-v6si5735907pll.498.2018.04.20.07.52.53 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 20 Apr 2018 07:52:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of pm215@archaic.org.uk designates 2001:8b0:1d0::2 as permitted sender) client-ip=2001:8b0:1d0::2; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of pm215@archaic.org.uk designates 2001:8b0:1d0::2 as permitted sender) smtp.mailfrom=pm215@archaic.org.uk; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from pm215 by orth.archaic.org.uk with local (Exim 4.89) (envelope-from ) id 1f9XPA-0006XY-8F; Fri, 20 Apr 2018 15:52:52 +0100 From: Peter Maydell To: qemu-devel@nongnu.org Cc: patches@linaro.org, "Michael S . Tsirkin" , Paolo Bonzini , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Subject: [PATCH 03/13] hw/mips/boston.c: Don't create "null" chardevs for serial devices Date: Fri, 20 Apr 2018 15:52:39 +0100 Message-Id: <20180420145249.32435-4-peter.maydell@linaro.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180420145249.32435-1-peter.maydell@linaro.org> References: <20180420145249.32435-1-peter.maydell@linaro.org> Following commit 12051d82f004024, UART devices should handle being passed a NULL pointer chardev, so we don't need to create "null" backends in board code. Remove the code that does this and updates serial_hds[]. Signed-off-by: Peter Maydell --- hw/mips/boston.c | 4 ---- 1 file changed, 4 deletions(-) -- 2.17.0 Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth diff --git a/hw/mips/boston.c b/hw/mips/boston.c index fb23161b33..14f0f6673b 100644 --- a/hw/mips/boston.c +++ b/hw/mips/boston.c @@ -505,10 +505,6 @@ static void boston_mach_init(MachineState *machine) "boston-platregs", 0x1000); memory_region_add_subregion_overlap(sys_mem, 0x17ffd000, platreg, 0); - if (!serial_hds[0]) { - serial_hds[0] = qemu_chr_new("serial0", "null"); - } - s->uart = serial_mm_init(sys_mem, 0x17ffe000, 2, get_cps_irq(s->cps, 3), 10000000, serial_hds[0], DEVICE_NATIVE_ENDIAN);