From patchwork Wed Apr 25 01:23:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 134213 Delivered-To: patch@linaro.org Received: by 10.46.151.6 with SMTP id r6csp256343lji; Tue, 24 Apr 2018 18:32:17 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqdNsiHW3u26TCDy9tQPFiBFORNKgrii1HSKv7bl0VPcPSCmGMoaNVhMCZIVjv3xcYAa7im X-Received: by 2002:ac8:2998:: with SMTP id 24-v6mr29565561qts.197.1524619937490; Tue, 24 Apr 2018 18:32:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524619937; cv=none; d=google.com; s=arc-20160816; b=SD3qX8ICojSuojHz/r691fxb7j027nkpMsP3eCw9RLggZLaVD8DyMfBWvCC//dVG1F 7fWStMJ1CbllVT8l5iKYYcuC/LNEkcHXTVFjtRcG8qnI8Yrs0DaQVkCE6Gz+zpJl1J0q PwiIkuD9/yVG5dlsVYLdLOPv2d/NwO48MTsT7dLyw5gwdtephV0Wp+VETCc0l6l6noBc 9w1hCPhEYkXQkvRk12bYAEZHW9I7tawmJEb1MwxnDuX1DZJcC5RTMY+1AK7R+FEwculG KICkznx09HglcvVl7TMoJn3qL+QqIT2fOVZA+XjUDAiUl/UcZYCZrbGyPZ90t+srK78B 2sXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=QYB1jA+b/6yV7+O5OAyvdanDF4Pgn2Y+CF2hHxSSV3s=; b=DhMMl8WfZaruYyAlQnQHrXIZPARCDfvtH6drmYZyaxXa+iuJboAdf1SLregzycKr7T a/qFOsSOs7mOk2zXo90sKZv+2UJ/P0PiU0orZJD0AaubLuVfUg1DV90ca2evnw9LCqp9 nLajLS9oMQV842Qne3+7cLnj8OtHNQ1uWCaNYJ7M8rgtj6RPjt1ortPGLdKpWNUusgme G6slmB8d9oUKiETcop7A4yHjGo1iJeRoMp493/xk9BEFI88CCnCfXT0yBjHrq7zg9YG3 2x1c8q9fZNMiBmo+8WDyZWHodRYcUksRhBfDyz6ffeiaPJw7gFiE06k0b8laj0MKvta1 kOWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=cqQlem/A; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id k7si3595694qve.251.2018.04.24.18.32.17 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 24 Apr 2018 18:32:17 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=cqQlem/A; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:33353 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fB9I9-0002oo-0C for patch@linaro.org; Tue, 24 Apr 2018 21:32:17 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55508) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fB99Z-000484-Dx for qemu-devel@nongnu.org; Tue, 24 Apr 2018 21:23:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fB99Y-0007ZS-D4 for qemu-devel@nongnu.org; Tue, 24 Apr 2018 21:23:25 -0400 Received: from mail-pg0-x242.google.com ([2607:f8b0:400e:c05::242]:40446) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fB99Y-0007Y3-7o for qemu-devel@nongnu.org; Tue, 24 Apr 2018 21:23:24 -0400 Received: by mail-pg0-x242.google.com with SMTP id e9so12132781pgr.7 for ; Tue, 24 Apr 2018 18:23:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=QYB1jA+b/6yV7+O5OAyvdanDF4Pgn2Y+CF2hHxSSV3s=; b=cqQlem/AM3BC9xKhwvIk/TTVzlc2T4OW0hB13sgKGODWL3G3jLAYbVlGoAYWCX709S 4wJ3M6IS+nMbqn6rZmHdKKL3BSb6Q3jmCdt02r8njs+MDANUBL6NRnXWGtRYVAc0ohC6 jEA2xwy2N/wegrn6XKu3MnfahcVer3oi5FXeQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=QYB1jA+b/6yV7+O5OAyvdanDF4Pgn2Y+CF2hHxSSV3s=; b=uYMKwDBXSBhrgI2pWiNnH2/3EdpN4sqS6I5lpmvuKeiSoxmL2dacp87gpJlNdS5n9u imYvpaQbbU8+wYWXpkam9A0LuA/OHU07mqo/H8dtsCy1veDKrey8rGGFr7jHnw0QohwW GrHgIICwWzWXVnmFAABmr80RLJzKLXbEkwNbukXvlwXb9o4jVaMazLtulkU+EPfAbMdq 3f6lswvp9DWWYIlQIPCOLqjD/bCVUqtSQ0feYH2oAsD/pR2KQbqR9ZiGZ22d7n4IBMYk Hd3GDwqm4W7fOtcIb2n4pJ7uhYcLS1PSLMQ6z0YgILhCPbM/gmyEzHjGCBciaM53zSKK d4Ww== X-Gm-Message-State: ALQs6tA22bQwgb+LSurCu12FZ0/WY4dcNMIPMux6dP7q4Ahug8WXd+QJ 2fYMrYPdyuZSAjntJclri7BmOUTSnwI= X-Received: by 10.98.155.87 with SMTP id r84mr21376233pfd.109.1524619402893; Tue, 24 Apr 2018 18:23:22 -0700 (PDT) Received: from cloudburst.twiddle.net.com (cpe-76-173-164-138.hawaii.res.rr.com. [76.173.164.138]) by smtp.gmail.com with ESMTPSA id z127sm27767966pfb.72.2018.04.24.18.23.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 24 Apr 2018 18:23:22 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Tue, 24 Apr 2018 15:23:00 -1000 Message-Id: <20180425012300.14698-10-richard.henderson@linaro.org> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180425012300.14698-1-richard.henderson@linaro.org> References: <20180425012300.14698-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::242 Subject: [Qemu-devel] [PATCH 9/9] target/arm: Implement FP data-processing (3 source) for fp16 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, alex.bennee@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" We missed all of the scalar fp16 fma operations. Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 48 insertions(+) -- 2.14.3 Reviewed-by: Alex Bennée diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 11b90b7eb0..0cb1fc4d67 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -5154,6 +5154,44 @@ static void handle_fp_3src_double(DisasContext *s, bool o0, bool o1, tcg_temp_free_i64(tcg_res); } +/* Floating-point data-processing (3 source) - half precision */ +static void handle_fp_3src_half(DisasContext *s, bool o0, bool o1, + int rd, int rn, int rm, int ra) +{ + TCGv_i32 tcg_op1, tcg_op2, tcg_op3; + TCGv_i32 tcg_res = tcg_temp_new_i32(); + TCGv_ptr fpst = get_fpstatus_ptr(true); + + tcg_op1 = read_fp_hreg(s, rn); + tcg_op2 = read_fp_hreg(s, rm); + tcg_op3 = read_fp_hreg(s, ra); + + /* These are fused multiply-add, and must be done as one + * floating point operation with no rounding between the + * multiplication and addition steps. + * NB that doing the negations here as separate steps is + * correct : an input NaN should come out with its sign bit + * flipped if it is a negated-input. + */ + if (o1 == true) { + tcg_gen_xori_i32(tcg_op3, tcg_op3, 0x8000); + } + + if (o0 != o1) { + tcg_gen_xori_i32(tcg_op1, tcg_op1, 0x8000); + } + + gen_helper_advsimd_muladdh(tcg_res, tcg_op1, tcg_op2, tcg_op3, fpst); + + write_fp_sreg(s, rd, tcg_res); + + tcg_temp_free_ptr(fpst); + tcg_temp_free_i32(tcg_op1); + tcg_temp_free_i32(tcg_op2); + tcg_temp_free_i32(tcg_op3); + tcg_temp_free_i32(tcg_res); +} + /* Floating point data-processing (3 source) * 31 30 29 28 24 23 22 21 20 16 15 14 10 9 5 4 0 * +---+---+---+-----------+------+----+------+----+------+------+------+ @@ -5183,6 +5221,16 @@ static void disas_fp_3src(DisasContext *s, uint32_t insn) } handle_fp_3src_double(s, o0, o1, rd, rn, rm, ra); break; + case 3: + if (!arm_dc_feature(s, ARM_FEATURE_V8_FP16)) { + unallocated_encoding(s); + return; + } + if (!fp_access_check(s)) { + return; + } + handle_fp_3src_half(s, o0, o1, rd, rn, rm, ra); + break; default: unallocated_encoding(s); }