[v2,14/14] target/arm: Fix sqrt_f16 exception raising

Message ID	20180502221552.3873-15-richard.henderson@linaro.org
State	Superseded
Headers	show Delivered-To: patch@linaro.org Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; From: Richard Henderson <richard.henderson@linaro.org> To: qemu-devel@nongnu.org Date: Wed, 2 May 2018 15:15:52 -0700 Message-Id: <20180502221552.3873-15-richard.henderson@linaro.org> In-Reply-To: <20180502221552.3873-1-richard.henderson@linaro.org> References: <20180502221552.3873-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PATCH v2 14/14] target/arm: Fix sqrt_f16 exception raising Precedence: list Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org, =?utf-8?q?Alex_Benn?= =?utf-8?b?w6ll?= <alex.bennee@linaro.org>, qemu-stable@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+patch=linaro.org@nongnu.org>
Series	target/arm: Fixups for ARM_FEATURE_V8_FP16 \| expand [v2,00/14] target/arm: Fixups for ARM_FEATURE_V8_FP16 [v2,01/14] target/arm: Implement vector shifted SCVF/UCVF for fp16 [v2,02/14] target/arm: Implement vector shifted FCVT for fp16 [v2,03/14] target/arm: Fix float16 to/from int16 [v2,04/14] target/arm: Clear SVE high bits for FMOV [v2,05/14] target/arm: Implement FMOV (general) for fp16 [v2,06/14] target/arm: Implement FCVT (scalar, integer) for fp16 [v2,07/14] target/arm: Implement FCVT (scalar, fixed-point) for fp16 [v2,08/14] target/arm: Introduce and use read_fp_hreg [v2,09/14] target/arm: Implement FP data-processing (2 source) for fp16 [v2,10/14] target/arm: Implement FP data-processing (3 source) for fp16 [v2,11/14] target/arm: Implement FCMP for fp16 [v2,12/14] target/arm: Implement FCSEL for fp16 [v2,13/14] target/arm: Implement FMOV (immediate) for fp16 [v2,14/14] target/arm: Fix sqrt_f16 exception raising

Message ID

20180502221552.3873-15-richard.henderson@linaro.org

State

Superseded

Headers

Received-SPF: pass (google.com: domain of
	qemu-devel-bounces+patch=linaro.org@nongnu.org designates
	2001:4830:134:3::11 as permitted sender)
	client-ip=2001:4830:134:3::11; 
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Date: Wed,  2 May 2018 15:15:52 -0700
Message-Id: <20180502221552.3873-15-richard.henderson@linaro.org>
In-Reply-To: <20180502221552.3873-1-richard.henderson@linaro.org>
References: <20180502221552.3873-1-richard.henderson@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: [Qemu-devel] [PATCH v2 14/14] target/arm: Fix sqrt_f16 exception
	raising
Precedence: list
Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org, =?utf-8?q?Alex_Benn?=
	=?utf-8?b?w6ll?= <alex.bennee@linaro.org>, 	qemu-stable@nongnu.org
Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org
Sender: "Qemu-devel" <qemu-devel-bounces+patch=linaro.org@nongnu.org>

Series

target/arm: Fixups for ARM_FEATURE_V8_FP16 | expand

Commit Message

Richard Henderson May 2, 2018, 10:15 p.m. UTC

From: Alex Bennée <alex.bennee@linaro.org>


We are meant to explicitly pass fpst, not cpu_env.

Cc: qemu-stable@nongnu.org
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

---
 target/arm/translate-a64.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.14.3

diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
index b73d6d96cd..07e196c19c 100644
--- a/target/arm/translate-a64.c
+++ b/target/arm/translate-a64.c
@@ -4739,7 +4739,8 @@  static void handle_fp_1src_half(DisasContext *s, int opcode, int rd, int rn)
         tcg_gen_xori_i32(tcg_res, tcg_op, 0x8000);
         break;
     case 0x3: /* FSQRT */
-        gen_helper_sqrt_f16(tcg_res, tcg_op, cpu_env);
+        fpst = get_fpstatus_ptr(true);
+        gen_helper_sqrt_f16(tcg_res, tcg_op, fpst);
         break;
     case 0x8: /* FRINTN */
     case 0x9: /* FRINTP */

[v2,14/14] target/arm: Fix sqrt_f16 exception raising

Commit Message

Patch