| Message ID | 20180510094206.15354-2-alex.bennee@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | refactor float-to-float and fix AHP | expand |
On 10 May 2018 at 10:42, Alex Bennée <alex.bennee@linaro.org> wrote: > Reported by Coverity (CID1390635). We ensure this for uint_to_float > later on so we might as well mirror that. > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > --- > fpu/softfloat.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fpu/softfloat.c b/fpu/softfloat.c > index 70e0c40a1c..3adf6a06e4 100644 > --- a/fpu/softfloat.c > +++ b/fpu/softfloat.c > @@ -1517,7 +1517,7 @@ FLOAT_TO_UINT(64, 64) > > static FloatParts int_to_float(int64_t a, float_status *status) > { > - FloatParts r; > + FloatParts r = {}; > if (a == 0) { > r.cls = float_class_zero; > r.sign = false; > -- Reviewed-by: Peter Maydell <peter.maydell@linaro.org> thanks -- PMM
On 05/10/2018 02:42 AM, Alex Bennée wrote: > Reported by Coverity (CID1390635). We ensure this for uint_to_float > later on so we might as well mirror that. > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > --- > fpu/softfloat.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
diff --git a/fpu/softfloat.c b/fpu/softfloat.c index 70e0c40a1c..3adf6a06e4 100644 --- a/fpu/softfloat.c +++ b/fpu/softfloat.c @@ -1517,7 +1517,7 @@ FLOAT_TO_UINT(64, 64) static FloatParts int_to_float(int64_t a, float_status *status) { - FloatParts r; + FloatParts r = {}; if (a == 0) { r.cls = float_class_zero; r.sign = false;
Reported by Coverity (CID1390635). We ensure this for uint_to_float later on so we might as well mirror that. Signed-off-by: Alex Bennée <alex.bennee@linaro.org> --- fpu/softfloat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.0