From patchwork Thu May 10 17:45:05 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 135420 Delivered-To: patch@linaro.org Received: by 10.46.151.6 with SMTP id r6csp1301787lji; Thu, 10 May 2018 10:45:59 -0700 (PDT) X-Google-Smtp-Source: AB8JxZogsHi3CklfGwSysgjPhQngxoT3cJPQwVusugw3rjmmd7CzQzdykX5pK5V6XOH+KSjkKSM6 X-Received: by 2002:ac8:7159:: with SMTP id h25-v6mr2284675qtp.206.1525974359556; Thu, 10 May 2018 10:45:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525974359; cv=none; d=google.com; s=arc-20160816; b=Sla0v93qG7PUpllQt1Hu4wFAApzf6pPVQcHkytiRx5sOGeapgpA5ETVFBuEdwBP0lk eUIdgh5cy5u+8oezlRMpXW4eNEDsEcRamUkpjBZQYggwK9HQwy/MvsaZ36p12XHCjyQd CTYGXRZhWhULbyNyvjn/8zAupUg2ssDHN6FmdQdrRVs18LtaUCY7s0VMvOsBwAqz80dM JUJIvQf3pdDwS0HMIKJc1xGaOhgEwS0YLJ/kfQmWNoSKIlfG0oR3MxBMBievkvrabZiC hakBdqrY4Oy1MvS2+z+tb0UKi+U9NNehijD/ThRywQ+C5+KMzYAq4Ai9ItMEAq2juSiA 4/5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:arc-authentication-results; bh=fzvHQkAy84kwJc7TLkk4umA1D7o2w3Jz54AFoRpOTmM=; b=XO+wXXCV4WQTYVKMAvPtKtYiSgPmZqae7VJawwrKkLjnHEzCWNnbaOW4MvxwPgM1nn Of8/7tz3OfWqSFO8JGm4US/cupaBObFJiJeCkVzmRAEncJClRVoRnYVjSgiuYwbosViT HHiZOGpXLOPB1u3sg8mbh+tFeei/KbDd9ZNG0yI5yK6Wqz2I3f2OoC0l9Dct0VSnlWbT gB0c33X8TdnDcdlX+7lv6sTA8o7PSXJBlBVbWxXYFRDYBhwVb2xD6kqAXyCw2Q6XMUkL VTPAV+gCySZx7PuYUaOdq/SNplH29q4WqaGZ8+w0eqT31pMkRwCl6UheKoWs7WBnAKLJ +lFw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id 126-v6si1231586qkg.65.2018.05.10.10.45.59 for (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 10 May 2018 10:45:59 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:34972 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fGpdf-00053F-0l for patch@linaro.org; Thu, 10 May 2018 13:45:59 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48438) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fGpd9-0004zV-Sg for qemu-devel@nongnu.org; Thu, 10 May 2018 13:45:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fGpd9-0000qW-0y for qemu-devel@nongnu.org; Thu, 10 May 2018 13:45:27 -0400 Received: from orth.archaic.org.uk ([2001:8b0:1d0::2]:41596) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fGpd8-0000nR-Oi for qemu-devel@nongnu.org; Thu, 10 May 2018 13:45:26 -0400 Received: from pm215 by orth.archaic.org.uk with local (Exim 4.89) (envelope-from ) id 1fGpd7-0003Vu-Gh for qemu-devel@nongnu.org; Thu, 10 May 2018 18:45:25 +0100 From: Peter Maydell To: qemu-devel@nongnu.org Date: Thu, 10 May 2018 18:45:05 +0100 Message-Id: <20180510174519.11264-8-peter.maydell@linaro.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180510174519.11264-1-peter.maydell@linaro.org> References: <20180510174519.11264-1-peter.maydell@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:8b0:1d0::2 Subject: [Qemu-devel] [PULL 07/21] atomic.h: Work around gcc spurious "unused value" warning X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Some versions of gcc produce a spurious warning if the result of __atomic_compare_echange_n() is not used and the type involved is a signed 8 bit value: error: value computed is not used [-Werror=unused-value] This has been seen on at least gcc (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609 Work around this by using an explicit cast to void to indicate that we don't care about the return value. We don't currently use our atomic_cmpxchg() macro on any signed 8 bit types, but the upcoming support for the Arm v8.1-Atomics will require it. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- include/qemu/atomic.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.0 diff --git a/include/qemu/atomic.h b/include/qemu/atomic.h index d73c9e14d7..9ed39effd3 100644 --- a/include/qemu/atomic.h +++ b/include/qemu/atomic.h @@ -187,7 +187,7 @@ /* Returns the eventual value, failed or not */ #define atomic_cmpxchg__nocheck(ptr, old, new) ({ \ typeof_strip_qual(*ptr) _old = (old); \ - __atomic_compare_exchange_n(ptr, &_old, new, false, \ + (void)__atomic_compare_exchange_n(ptr, &_old, new, false, \ __ATOMIC_SEQ_CST, __ATOMIC_SEQ_CST); \ _old; \ })