From patchwork Tue May 15 14:07:04 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 135897 Delivered-To: patch@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp1085879lji; Tue, 15 May 2018 07:23:56 -0700 (PDT) X-Google-Smtp-Source: AB8JxZosDDNW55pYDdc3LdDKMrUEFoNWAJb0Fcif/tbpUufMARKahXnsxfDWhnWsa/etJFP5pjuY X-Received: by 2002:aed:22b6:: with SMTP id p51-v6mr14180019qtc.222.1526394236422; Tue, 15 May 2018 07:23:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526394236; cv=none; d=google.com; s=arc-20160816; b=ZiRRea2e+4sqYwOX9ljb/E2d92n4mq0bi+MyDdxYOT89+Sun+V1mrZwS9T8JHlJxQ5 83TEgTAyqrlYLsqY33fAlM6qltqQB8ry1pzJotssbk5cyFc+EGbIfmSV0x7YV7+P4bYf EBlEYoojQKd/epjeaCkBgesLtclQYgooWzRL7whlNUbXb9ApxHd/E+pspeu9kpBDjOkg jAf3mzunKHk7nOw9JI4lL6GkMjkRnzmnmlyQKJqmUwyJNTKz+mLucjoXhGB8IhcX6ijx FcVoKD+dVWNwHzKZuW4LWShjVKLHPKyC0o5UiOF+t/8wM4QaVS1lgOgsP1Kw7rDVXI/F 6Kvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:arc-authentication-results; bh=uA5zwmWu+Rx63EQsCG+q5jBmYFFL+d1r34onO8m3d4Y=; b=Mp/2tu+8aAvdTyRpe4YCvXw2CL8H4vYTMjnM9nQshANupt3NhovsmWJqihmn+I5SOS L7BROjb6ZvnVUbnqNAfDh2eQGqUqusWUOeGMl8pTth8qawowlyY4mnuZZHbuVKUa0SIG zBFRb5MsQeROXPX6sZuybcSQvUBz8NAPHDDmtz5uoT3piYr/HlQqIH7Ncdt70NvtNMJR uVyOUEkDBGD0wj5zvD0QdrUqZGOMcY+mAJlXfApDMNXvXAH3dFNBsoP/srqUZH6WiJLn QH0yp50N/HaPWnajsqbOI/kfQYn+LzLZuTbf8JnPrnTFIoStCZVy8E08Y9TqywOkYEv7 g26Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id r13-v6si195952qtr.91.2018.05.15.07.23.56 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 15 May 2018 07:23:56 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:40162 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fIarr-00086Z-Ql for patch@linaro.org; Tue, 15 May 2018 10:23:55 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39679) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fIabs-0003t3-Jj for qemu-devel@nongnu.org; Tue, 15 May 2018 10:07:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fIabm-0002vo-J3 for qemu-devel@nongnu.org; Tue, 15 May 2018 10:07:24 -0400 Received: from orth.archaic.org.uk ([2001:8b0:1d0::2]:41688) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fIabm-0002tn-Cc for qemu-devel@nongnu.org; Tue, 15 May 2018 10:07:18 -0400 Received: from pm215 by orth.archaic.org.uk with local (Exim 4.89) (envelope-from ) id 1fIabl-0001So-HV for qemu-devel@nongnu.org; Tue, 15 May 2018 15:07:17 +0100 From: Peter Maydell To: qemu-devel@nongnu.org Date: Tue, 15 May 2018 15:07:04 +0100 Message-Id: <20180515140707.15957-14-peter.maydell@linaro.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180515140707.15957-1-peter.maydell@linaro.org> References: <20180515140707.15957-1-peter.maydell@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:8b0:1d0::2 Subject: [Qemu-devel] [PULL 13/16] target/arm: Implement FMOV (immediate) for fp16 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Alex Bennée All the hard work is already done by vfp_expand_imm, we just need to make sure we pick up the correct size. Cc: qemu-stable@nongnu.org Reviewed-by: Peter Maydell Signed-off-by: Alex Bennée Tested-by: Alex Bennée Signed-off-by: Richard Henderson Message-id: 20180512003217.9105-11-richard.henderson@linaro.org [rth: Merge unallocated_encoding check with TCGMemOp conversion.] Signed-off-by: Richard Henderson Signed-off-by: Peter Maydell --- target/arm/translate-a64.c | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-) -- 2.17.0 diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 9dacb583ae..35997969b4 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -5674,11 +5674,25 @@ static void disas_fp_imm(DisasContext *s, uint32_t insn) { int rd = extract32(insn, 0, 5); int imm8 = extract32(insn, 13, 8); - int is_double = extract32(insn, 22, 2); + int type = extract32(insn, 22, 2); uint64_t imm; TCGv_i64 tcg_res; + TCGMemOp sz; - if (is_double > 1) { + switch (type) { + case 0: + sz = MO_32; + break; + case 1: + sz = MO_64; + break; + case 3: + sz = MO_16; + if (arm_dc_feature(s, ARM_FEATURE_V8_FP16)) { + break; + } + /* fallthru */ + default: unallocated_encoding(s); return; } @@ -5687,7 +5701,7 @@ static void disas_fp_imm(DisasContext *s, uint32_t insn) return; } - imm = vfp_expand_imm(MO_32 + is_double, imm8); + imm = vfp_expand_imm(sz, imm8); tcg_res = tcg_const_i64(imm); write_fp_dreg(s, rd, tcg_res);