diff mbox series

[v4,29/49] tests/tcg/arm: disable -p 32768 mmap test

Message ID 20180517174718.10107-30-alex.bennee@linaro.org
State New
Headers show
Series fix building of tests/tcg | expand

Commit Message

Alex Bennée May 17, 2018, 5:46 p.m. UTC
Broken since I updated to 18.04

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

---
 tests/tcg/arm/Makefile.target | 8 ++++++++
 1 file changed, 8 insertions(+)

-- 
2.17.0

Comments

Richard Henderson May 17, 2018, 8:20 p.m. UTC | #1
On 05/17/2018 10:46 AM, Alex Bennée wrote:
> Broken since I updated to 18.04

> 

> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

> ---

>  tests/tcg/arm/Makefile.target | 8 ++++++++

>  1 file changed, 8 insertions(+)


Meh.  Most of these fail for hosts with 64k pages.
So, sure, disable this one, but I don't think that
the others are useful either.


r~
Alex Bennée May 17, 2018, 9:24 p.m. UTC | #2
Richard Henderson <richard.henderson@linaro.org> writes:

> On 05/17/2018 10:46 AM, Alex Bennée wrote:

>> Broken since I updated to 18.04

>>

>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

>> ---

>>  tests/tcg/arm/Makefile.target | 8 ++++++++

>>  1 file changed, 8 insertions(+)

>

> Meh.  Most of these fail for hosts with 64k pages.

> So, sure, disable this one, but I don't think that

> the others are useful either.


I'm not entirely sure what the point of -p is meant to be. Is it just a
performance hack for linux-user to have bigger pages? We are not using
softmmu but I guess it affects the PageDesc structures?

--
Alex Bennée
Richard Henderson May 17, 2018, 9:34 p.m. UTC | #3
On 05/17/2018 02:24 PM, Alex Bennée wrote:
> 

> Richard Henderson <richard.henderson@linaro.org> writes:

> 

>> On 05/17/2018 10:46 AM, Alex Bennée wrote:

>>> Broken since I updated to 18.04

>>>

>>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

>>> ---

>>>  tests/tcg/arm/Makefile.target | 8 ++++++++

>>>  1 file changed, 8 insertions(+)

>>

>> Meh.  Most of these fail for hosts with 64k pages.

>> So, sure, disable this one, but I don't think that

>> the others are useful either.

> 

> I'm not entirely sure what the point of -p is meant to be. Is it just a

> performance hack for linux-user to have bigger pages? We are not using

> softmmu but I guess it affects the PageDesc structures?


I think it was just meant for testing, but I really have no idea.

If we actually had better support for mismatched host/guest page sizes, then
one could view -p as a way to choose between legitimate guest page sizes.  E.g.
8k, 16k, 64k are all legitimate for aarch64.


r~
Philippe Mathieu-Daudé May 18, 2018, 3:47 a.m. UTC | #4
On 05/17/2018 06:34 PM, Richard Henderson wrote:
> On 05/17/2018 02:24 PM, Alex Bennée wrote:

>>

>> Richard Henderson <richard.henderson@linaro.org> writes:

>>

>>> On 05/17/2018 10:46 AM, Alex Bennée wrote:

>>>> Broken since I updated to 18.04

>>>>

>>>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

>>>> ---

>>>>  tests/tcg/arm/Makefile.target | 8 ++++++++

>>>>  1 file changed, 8 insertions(+)

>>>

>>> Meh.  Most of these fail for hosts with 64k pages.

>>> So, sure, disable this one, but I don't think that

>>> the others are useful either.

>>

>> I'm not entirely sure what the point of -p is meant to be. Is it just a

>> performance hack for linux-user to have bigger pages? We are not using

>> softmmu but I guess it affects the PageDesc structures?

> 

> I think it was just meant for testing, but I really have no idea.

> 

> If we actually had better support for mismatched host/guest page sizes, then

> one could view -p as a way to choose between legitimate guest page sizes.  E.g.

> 8k, 16k, 64k are all legitimate for aarch64.


8k + 16k on aarch64:
Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
diff mbox series

Patch

diff --git a/tests/tcg/arm/Makefile.target b/tests/tcg/arm/Makefile.target
index 1ef5d79fe3..9d2b551732 100644
--- a/tests/tcg/arm/Makefile.target
+++ b/tests/tcg/arm/Makefile.target
@@ -16,3 +16,11 @@  hello-arm: LDFLAGS+=-nostdlib
 test-arm-iwmmxt: CFLAGS+=-marm -march=iwmmxt -mabi=aapcs -mfpu=fpv4-sp-d16
 test-arm-iwmmxt: test-arm-iwmmxt.S
 	$(CC) $(CFLAGS) $< -o $@ $(LDFLAGS)
+
+# Currently broken for -p 32768
+ifeq ($(TARGET_NAME), arm)
+run-test-mmap: test-mmap
+	$(call quiet-command, $(QEMU) $< > test-mmap.out, "TEST", "$< (default) on $(TARGET_NAME)")
+	$(call quiet-command, $(QEMU) -p 8192 $< 8192 > test-mmap-8192.out, "TEST", "$< (8k pages) on $(TARGET_NAME)")
+	$(call quiet-command, $(QEMU) -p 16384 $< 16384 > test-mmap-16384.out, "TEST", "$< (16k pages) on $(TARGET_NAME)")
+endif