From patchwork Sun Jun 10 03:00:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 138075 Delivered-To: patch@linaro.org Received: by 2002:a2e:970d:0:0:0:0:0 with SMTP id r13-v6csp2573596lji; Sat, 9 Jun 2018 20:02:52 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLK/7IYGBeL7P1prvSdsDnkzkysO7ZxHHFH/tCl3Fq5X5MPhJIZBfLCROY/JveFuBJ3OOeq X-Received: by 2002:a0c:8601:: with SMTP id p1-v6mr10804947qva.184.1528599772599; Sat, 09 Jun 2018 20:02:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528599772; cv=none; d=google.com; s=arc-20160816; b=Ra7Cypzu50ZY0DWyUhug7rQTXYTnwJOLWoRtbAJAtdsTdJ9voUD9UXka4Gmfd7zw+j SqR1qeAqflJRmSea+OAJAXXIzAUvHMX6UJrhjlLAlzHfdcsHvaKusXmYIIzszOh1PZwB ub20w2RHYzp59YVFtp2xV2pNuMbDYl+/iSfesUDtVFWYTVdoLoyOlTwLSo3c+9w4qelP Znu0yMYfxsxZlXmeu0oF3dAAlOzuDxoJfhmkzIcA5i9WfaHFguvwC+sv3a40GRaS6Mi2 JvQEVgsZVpitntBj0A0iciWd+VZKv0RzvEEfmCizPBzGJbzH2i9OU3gaK4Fpshivrxi8 0SGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=nc8xWXUdkiMLiKu/AUrUH1Pr6L00YHRjLLeytlE0ns8=; b=S2KpK+51K5EFBb+Klnshz3Jv5BIFY7GVk6zgJx54TqlN0nmvQjDHy03IUNBseegcad gwSLp+DqGPYtsK27PFFgfNerKbeFphP4VhH4zUVyqnC9Oxr0xn7ueuiIh/B9j3mjO2Ne Anwld3m2HLy6W4A6Q6LmLDRAcAMSftB3cb7pIuCEJMxy9qzUtIpNv+IUqSpJToV85Xjd thSSFqfbZUa3P64A0FLg0fMSRueITgutW4tlcpE+PQi92+tr8KrVZ1V3V7EMJk+sI803 +YLYgW+w86iyTyt5loMFddIY2yHqFj/V/QbMIZWFo4JMmfPl8En+pERIz4zFWu6wM9l7 u3bA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=YBoSnDpL; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id y7-v6si15618qth.349.2018.06.09.20.02.52 for (version=TLS1 cipher=AES128-SHA bits=128/128); Sat, 09 Jun 2018 20:02:52 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=YBoSnDpL; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:42170 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fRqd2-0001VX-22 for patch@linaro.org; Sat, 09 Jun 2018 23:02:52 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40036) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fRqch-0001VI-9h for qemu-devel@nongnu.org; Sat, 09 Jun 2018 23:02:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fRqcf-00035n-P1 for qemu-devel@nongnu.org; Sat, 09 Jun 2018 23:02:31 -0400 Received: from mail-pg0-x241.google.com ([2607:f8b0:400e:c05::241]:42517) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fRqcf-00035b-IT for qemu-devel@nongnu.org; Sat, 09 Jun 2018 23:02:29 -0400 Received: by mail-pg0-x241.google.com with SMTP id c10-v6so2507859pgu.9 for ; Sat, 09 Jun 2018 20:02:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=nc8xWXUdkiMLiKu/AUrUH1Pr6L00YHRjLLeytlE0ns8=; b=YBoSnDpLzaOxHI8+a8UYUhqMeu81zLePU1VGIMQlR75ZiM6EFIA+EZXKYRD139a0gS Dkk3M97SbT8SkQxLAZOjdrKZR0GsRXVOJTFkeZutgaP1y7GK9sGK+9uNsrm8H6JAs1wm 8XLNgKvOn9XJZIoLXG318bx93gUAUsBqjhHBI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=nc8xWXUdkiMLiKu/AUrUH1Pr6L00YHRjLLeytlE0ns8=; b=AejtTailbaWb9W2pnA3b9uJqRdFtbvGveITCWk2b9DTyxbyNQDUvkxjSTM2A5HK0mR kxEH7/Bgtvo4OO3ejSPifI4bmQVtf1ydHQZBj7D40zjj+OKSI9B62g7qcWoDqclxSflm lQf+G8TjMhsYViYnGYx5MABSwhBNzY0PjsNI8jZXsHCiupmgNqNLqAOILUjesw/POK1i bfXLLMvQgKCGr+gS5YVK3hMzx8ncWd2RZennSldLf5lss/RaBzcVoQNxqcGesl3z0wFv Uh6daq/Wwe4bDpZZiRFh7N6u2yK4qZAE/qgKCchlP/utBoJh1SaV0VH/KdIfc20200F8 3EUw== X-Gm-Message-State: APt69E3lPmB9qqmByLGHehlilH8Vq8LA+e8t1dpWU9nVTv6mMHGbqceZ r16Dza0YBrxxyQJ9/d5o6StkWM9XynA= X-Received: by 2002:a63:12:: with SMTP id 18-v6mr10594894pga.121.1528599748167; Sat, 09 Jun 2018 20:02:28 -0700 (PDT) Received: from cloudburst.twiddle.net (rrcs-173-198-77-219.west.biz.rr.com. [173.198.77.219]) by smtp.gmail.com with ESMTPSA id y17-v6sm31712718pfe.33.2018.06.09.20.02.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 09 Jun 2018 20:02:27 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Sat, 9 Jun 2018 17:00:33 -1000 Message-Id: <20180610030220.3777-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180610030220.3777-1-richard.henderson@linaro.org> References: <20180610030220.3777-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::241 Subject: [Qemu-devel] [PATCH v2 001/108] linux-user: Remove DEBUG X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: laurent@vivier.eu Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" This is redundant with both -strace and actual tracing. Signed-off-by: Richard Henderson --- linux-user/syscall.c | 10 ---------- 1 file changed, 10 deletions(-) -- 2.17.1 Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 7b9ac3b408..c212149245 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -163,7 +163,6 @@ * (The one remaining unallocated bit is 0x1000 which used to be CLONE_PID.) */ -//#define DEBUG /* Define DEBUG_ERESTARTSYS to force every syscall to be restarted * once. This exercises the codepaths for restart. */ @@ -5777,9 +5776,6 @@ static abi_long do_ioctl(int fd, int cmd, abi_long arg) ie++; } arg_type = ie->arg_type; -#if defined(DEBUG) - gemu_log("ioctl: cmd=0x%04lx (%s)\n", (long)cmd, ie->name); -#endif if (ie->do_ioctl) { return ie->do_ioctl(ie, buf_temp, fd, cmd, arg); } else if (!ie->host_cmd) { @@ -7980,9 +7976,6 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1, } #endif -#ifdef DEBUG - gemu_log("syscall %d", num); -#endif trace_guest_user_syscall(cpu, num, arg1, arg2, arg3, arg4, arg5, arg6, arg7, arg8); if(do_strace) print_syscall(num, arg1, arg2, arg3, arg4, arg5, arg6); @@ -12772,9 +12765,6 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1, break; } fail: -#ifdef DEBUG - gemu_log(" = " TARGET_ABI_FMT_ld "\n", ret); -#endif if(do_strace) print_syscall_ret(num, ret); trace_guest_user_syscall_ret(cpu, num, ret);