From patchwork Fri Jun 15 19:43:52 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 138762 Delivered-To: patch@linaro.org Received: by 2002:a2e:970d:0:0:0:0:0 with SMTP id r13-v6csp1252508lji; Fri, 15 Jun 2018 12:53:48 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKn2Ji7MljrhejTmJ1FjlNO45IGuRtCElIaHt11IejaatETMtes7fZlKI+0FrbyfCZuGmzS X-Received: by 2002:a0c:9621:: with SMTP id 30-v6mr2661029qvx.127.1529092428112; Fri, 15 Jun 2018 12:53:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529092428; cv=none; d=google.com; s=arc-20160816; b=H1dv3VhvMcKB7nIJMShLJd3xQvJzBDKOI+lG+VrKFecOE8/8Iai8akmFebMn4z1KIH yt5Fbkuf/DgQeZpWJTgv0vfDlT+vobWCv8KMgQKQMRHZeg5esORgJ0MWmPaNgjC80bCz qOjZmyJ1kbk5q/yzZ8843KS0UfKofl4LavS1n4iBSBWLrHD9tCUt8BrXmyqmQhnWcu5B oEXjC/PxBirU0WLGw31hWNm0NqMt35KSjNE9GcG/h/IW1Qo2iizieHnq2DPgIfY2SrLg 8WBuZX2nBcKqrmOJCSq3cxd5CUOpDY2pL2p4nJoLkHD95L07dNlRnkZC712IHTzLIyjz a8gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=90PvNAHeckXJjwcM439RbSqujLTH8kYi9wIh5hWAJn8=; b=TjpW3QRMBJ7U9Sd0ecIrBm43zg+T737qynNLgriDzuOzVTQLSmGXndLpUnpSRxH+rC qbNurHniCOGlRwupZbg2cgKZv1QORRbjPDbxFBE1KqfMutaM6eLv5our8G2cpOhAw9gm We+SjWei74CmKG713j7lqSGUtl+YN42whiTYxaLVIakdSi5HW+6/slbMMl8i+ofkEpWJ qxQtnuv1BzZGJa0aJjAyDZ6YJDs4X1vYpxXSuBmbDyqReAKCUCsLJUJA6qiL72zrHwxc Zi0PjkIow05aVWoISFWee6mVi0YL1m6JpFt4xnG++trR9WmtmYwxU3p+y14txGyRYkFH iEJQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=QmsbIQbj; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id b64-v6si7486888qkb.260.2018.06.15.12.53.47 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 15 Jun 2018 12:53:48 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=QmsbIQbj; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:49002 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTun5-0007ey-Gb for patch@linaro.org; Fri, 15 Jun 2018 15:53:47 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51695) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTue9-0000bM-K9 for qemu-devel@nongnu.org; Fri, 15 Jun 2018 15:44:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fTue8-0002i8-UE for qemu-devel@nongnu.org; Fri, 15 Jun 2018 15:44:33 -0400 Received: from mail-pl0-x242.google.com ([2607:f8b0:400e:c01::242]:38076) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fTue8-0002hZ-Oz for qemu-devel@nongnu.org; Fri, 15 Jun 2018 15:44:32 -0400 Received: by mail-pl0-x242.google.com with SMTP id b14-v6so5849376pls.5 for ; Fri, 15 Jun 2018 12:44:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=90PvNAHeckXJjwcM439RbSqujLTH8kYi9wIh5hWAJn8=; b=QmsbIQbjbk/wqhoNbFlDn16Uzq+BPGSFMAJzLpGk3u/a27Cw8zJOgRskvldVbqFVp2 v+fFxMyHPAQgg2/vpvtXzX64sT6OrIWwtJKp7yxPhcN+bEkRCwhmTY6x99EEmuRWnWIV CwFa1afnlbmH/YOMcDUrmycSVAL+uztn4zX3w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=90PvNAHeckXJjwcM439RbSqujLTH8kYi9wIh5hWAJn8=; b=ICYrUjNGF6XsKvJEXwWr8NtbhjKGoCUyVyxh2p27IsK5e2MwIQc5Dv0rya29wGw1Ej J40Yrp0QoUAqmX94YWGlpSluBTr3qjTy+GpbI4jBzLu3Cv13CW5EjXr4eQDWtJaacBz+ SzckKJSbMShpBFjwYdnTaPcX+/cG+is8wMWwWi95MHG3xhZRAgnXsqQ9UwFohzdaMHBY ApaC3ZKn4TJczRKghq9ImOMmGlXzFX+YkawvWU30qP+WuEqKjX38FVZmFBmTxzFhMy09 VJJog3Kh6qtRBUU49HwiKJhxPXJkMkkVLfT/otepRCdgrJEMl7+jRrIMpsbmn3dMEhIA TEKw== X-Gm-Message-State: APt69E1mG+c3ufhnGYN8IMJOG4jL60tc166e7O178H3ZAscnETqKGb7P gKkYIv6gTgpVDVbwdYj5XSIEOEvEW2E= X-Received: by 2002:a17:902:aa95:: with SMTP id d21-v6mr3507996plr.73.1529091871507; Fri, 15 Jun 2018 12:44:31 -0700 (PDT) Received: from cloudburst.twiddle.net (rrcs-173-198-77-219.west.biz.rr.com. [173.198.77.219]) by smtp.gmail.com with ESMTPSA id 29-v6sm14038360pfj.14.2018.06.15.12.44.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 15 Jun 2018 12:44:30 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Fri, 15 Jun 2018 09:43:52 -1000 Message-Id: <20180615194354.12489-18-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180615194354.12489-1-richard.henderson@linaro.org> References: <20180615194354.12489-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c01::242 Subject: [Qemu-devel] [PULL v2 17/19] translate-all: remove tb_lock mention from cpu_restore_state_from_tb X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, "Emilio G. Cota" Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: "Emilio G. Cota" tb_lock was needed when the function did retranslation. However, since fca8a500d519 ("tcg: Save insn data and use it in cpu_restore_state_from_tb") we don't do retranslation. Get rid of the comment. Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota Signed-off-by: Richard Henderson --- accel/tcg/translate-all.c | 1 - 1 file changed, 1 deletion(-) -- 2.17.1 diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c index 55c9e1b196..b33cd9bc98 100644 --- a/accel/tcg/translate-all.c +++ b/accel/tcg/translate-all.c @@ -355,7 +355,6 @@ static int encode_search(TranslationBlock *tb, uint8_t *block) } /* The cpu state corresponding to 'searched_pc' is restored. - * Called with tb_lock held. * When reset_icount is true, current TB will be interrupted and * icount should be recalculated. */