From patchwork Mon Jul 2 14:30:04 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 140775 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp23991ljj; Mon, 2 Jul 2018 07:30:59 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeU+AcztkGbwn+DCLcRDZecVFp/hRTp/Cs7vbjzCrQIsPxlyFLYX+fVpYy4zRoFGLb83obq X-Received: by 2002:a37:a0b:: with SMTP id 11-v6mr17841299qkk.90.1530541859685; Mon, 02 Jul 2018 07:30:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530541859; cv=none; d=google.com; s=arc-20160816; b=CK/baXPPCwWYFltUTxjndrfNbiFIoaye6VDU8Wm6wf6NZpudcBind8LsIgNztwRa1R kax8seRM4ohIY5DkH30NOZReAzcNsZJGiZ5Zouk9792+vefbDbxiM/BOrKjDAYfBiryp 3Uq+riwAmK6cYOkct0H0zoRdXy10lZkhZHUtIP75dUzuq9WPtD5Hbb1yqc9WEERZvAtV 5TLuWIV1IxDSDGdSWpo553iVh62+ytfSTXYs8bvPvI6EvWJiw5K8HP8P+hGnHOu5hvTf hHYozBAin1Jmj8ZpgDp+G9M11QUa2n2R3FyQw1xplKhyxNpkG/nmPxtyASlzhhEkE+Oi pd3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=5YJQD6mVsHQ+y4JfkIGsYKr2KX19OUMuNv1hJuaEJwQ=; b=1Dt8BSq5jPermp7FKsZ4B3NGFAmIbB1pL5jFOqvcJBzL+D2llfO/mfXnDRpbNRZic2 Kpih2B69vgXpz2ASa4l9+X1dm1JmbrPTXO1EhmqR1QsXM+7hNSZoHciXmwKsNiValigL 2Rym0vQYrnM37t+BdycZYudGVX4MauF8yLFgV1SKk9gosRll/4zYnybAa91H6I3GaC5V Extoj56lOQwFYMOJYBVZQT8IyfDpT7EuVsVd9zTnCQdUMBgRVHPx72yPsUP3i0ZUTnLU tgkDEUbfAp7EiQuAMFh34Sqbe9UVQA6KE303pkpU6n4UI+E2v0ZlZmlA9vqHklp3zaMX czYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=Rx6vbZb7; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id v1-v6si398071qtf.152.2018.07.02.07.30.59 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 02 Jul 2018 07:30:59 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=Rx6vbZb7; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:33145 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fZzr1-0005NA-3J for patch@linaro.org; Mon, 02 Jul 2018 10:30:59 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54290) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fZzqW-0005M0-AM for qemu-devel@nongnu.org; Mon, 02 Jul 2018 10:30:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fZzqV-0000RZ-7B for qemu-devel@nongnu.org; Mon, 02 Jul 2018 10:30:28 -0400 Received: from mail-wr0-x230.google.com ([2a00:1450:400c:c0c::230]:33806) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fZzqU-0000R1-SH for qemu-devel@nongnu.org; Mon, 02 Jul 2018 10:30:27 -0400 Received: by mail-wr0-x230.google.com with SMTP id a12-v6so15791266wro.1 for ; Mon, 02 Jul 2018 07:30:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5YJQD6mVsHQ+y4JfkIGsYKr2KX19OUMuNv1hJuaEJwQ=; b=Rx6vbZb7lmWm25d+Ips4mPMEpipLATKjvnSu9lSi6zBXIMerOGanczk5LrEMRLGWZ8 7oXwxjCQsE6+tciSC9SSfuTfyzQDqd4WBCsZdDQ77czPBr3fI4lChz0XIW3swRzmTU7e dy/F3OqsKUkeifxLp9wmxy93pW/CKAAWklLB0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5YJQD6mVsHQ+y4JfkIGsYKr2KX19OUMuNv1hJuaEJwQ=; b=W5/A/tDG00u5nfUckRZG0cR4fWL2cHP1OBvXOuatlpDJ+rJRvQAtHDmcNa5pDnyIxb A6hxS9j13hoNv+QUp4SvOQ1aQVlUQ93R6VguPqRXcoDX9e/WdKg8FlrAd6PGcZmoq448 tPXrxO5iG/ReTy8PUnvnjMEEmEpemlJSPvh4yQlkJu3HjlUcNYCjwGg/VyTI7BOGgd/V mfe77Re1S1b9fHo9ELsxUUS5KKExuVy7QJ9X5u9SbjLif+JNNaplQbP0MTQ08T46GOfN 3JhZYr+3uBBjdo/2hEVkz7xQsvba1uzyY5cbXX3BfkNAeL9uwt3g947FzOodn85njPUs ydqw== X-Gm-Message-State: APt69E3rs2PvFqgr8C1sSqpqGsrrDIjvd2AWxKUqTisnk9bbvou8Bwva banMXbaYov+HKzsEBCPsN56WqQ== X-Received: by 2002:adf:8162:: with SMTP id 89-v6mr12459648wrm.192.1530541825731; Mon, 02 Jul 2018 07:30:25 -0700 (PDT) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id b190-v6sm10545942wma.24.2018.07.02.07.30.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 02 Jul 2018 07:30:23 -0700 (PDT) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id EAAC23E06DE; Mon, 2 Jul 2018 15:30:21 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: cota@braap.org, famz@redhat.com, berrange@redhat.com, f4bug@amsat.org, richard.henderson@linaro.org, balrogg@gmail.com, aurelien@aurel32.net, agraf@suse.de Date: Mon, 2 Jul 2018 15:30:04 +0100 Message-Id: <20180702143021.18864-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180702143021.18864-1-alex.bennee@linaro.org> References: <20180702143021.18864-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::230 Subject: [Qemu-devel] [PATCH v3 03/20] build-system: remove per-test GCOV reporting X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, =?utf-8?q?Alex_Benn=C3=A9e?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" I'm not entirely sure who's using this information and certainly in a CI environment it just washes over as additional noise. Later patches will provide new reporting options so a user who wants to analyse individual tests will be able to use that to get the information. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé --- docs/devel/testing.rst | 11 +++++------ tests/Makefile.include | 10 ---------- 2 files changed, 5 insertions(+), 16 deletions(-) -- 2.17.1 diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst index f33e5a8423..66ef219f69 100644 --- a/docs/devel/testing.rst +++ b/docs/devel/testing.rst @@ -158,12 +158,11 @@ rarely used. See "QEMU iotests" section below for more information. GCC gcov support ---------------- -``gcov`` is a GCC tool to analyze the testing coverage by instrumenting the -tested code. To use it, configure QEMU with ``--enable-gcov`` option and build. -Then run ``make check`` as usual. There will be additional ``gcov`` output as -the testing goes on, showing the test coverage percentage numbers per analyzed -source file. More detailed reports can be obtained by running ``gcov`` command -on the output files under ``$build_dir/tests/``, please read the ``gcov`` +``gcov`` is a GCC tool to analyze the testing coverage by +instrumenting the tested code. To use it, configure QEMU with +``--enable-gcov`` option and build. Then run ``make check`` as usual. +Reports can be obtained by running ``gcov`` command on the output +files under ``$build_dir/tests/``, please read the ``gcov`` documentation for more information. QEMU iotests diff --git a/tests/Makefile.include b/tests/Makefile.include index e8bb2d8f66..756474814a 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -891,26 +891,16 @@ GCOV_OPTIONS = -n $(if $(V),-f,) .PHONY: $(patsubst %, check-qtest-%, $(QTEST_TARGETS)) $(patsubst %, check-qtest-%, $(QTEST_TARGETS)): check-qtest-%: subdir-%-softmmu $(check-qtest-y) - $(if $(CONFIG_GCOV),@rm -f *.gcda */*.gcda */*/*.gcda */*/*/*.gcda,) $(call quiet-command,QTEST_QEMU_BINARY=$*-softmmu/qemu-system-$* \ QTEST_QEMU_IMG=qemu-img$(EXESUF) \ MALLOC_PERTURB_=$${MALLOC_PERTURB_:-$$(( $${RANDOM:-0} % 255 + 1))} \ gtester $(GTESTER_OPTIONS) -m=$(SPEED) $(check-qtest-$*-y) $(check-qtest-generic-y),"GTESTER","$@") - $(if $(CONFIG_GCOV),@for f in $(gcov-files-$*-y) $(gcov-files-generic-y); do \ - echo Gcov report for $$f:;\ - $(GCOV) $(GCOV_OPTIONS) $$f -o `dirname $$f`; \ - done,) .PHONY: $(patsubst %, check-%, $(check-unit-y) $(check-speed-y)) $(patsubst %, check-%, $(check-unit-y) $(check-speed-y)): check-%: % - $(if $(CONFIG_GCOV),@rm -f *.gcda */*.gcda */*/*.gcda */*/*/*.gcda,) $(call quiet-command, \ MALLOC_PERTURB_=$${MALLOC_PERTURB_:-$$(( $${RANDOM:-0} % 255 + 1))} \ gtester $(GTESTER_OPTIONS) -m=$(SPEED) $*,"GTESTER","$*") - $(if $(CONFIG_GCOV),@for f in $(gcov-files-$(subst tests/,,$*)-y) $(gcov-files-generic-y); do \ - echo Gcov report for $$f:;\ - $(GCOV) $(GCOV_OPTIONS) $$f -o `dirname $$f`; \ - done,) # gtester tests with XML output