From patchwork Mon Jul 2 15:09:59 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Stafford Horne X-Patchwork-Id: 140796 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp67687ljj; Mon, 2 Jul 2018 08:12:00 -0700 (PDT) X-Google-Smtp-Source: AAOMgpd40qSPVa3zJ+n6Ln8vZflJelrNc57zN8z7yQkJ/o5Mok8sKQqXP++IP/Owao/6+hbnhDAP X-Received: by 2002:ac8:33c2:: with SMTP id d2-v6mr8430092qtb.323.1530544319926; Mon, 02 Jul 2018 08:11:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530544319; cv=none; d=google.com; s=arc-20160816; b=bADkvQ+q8tUD23+9kjMwKZyrWoiZKdufv1qMub++G3b9EIhD25jOxsd0eJ+i1ajwOn cEUNFmBa/zMR1KXHl/AFAP/hux/ZQLpJFGwkpr1ugRbrUTKQYgNKiBHTmffqyoKK3Rrc 41uuoPAbfWOcrKZpSlAyZlkaWPa7Z4tIYS9XoUNsyRswRh5k7WjmNry8UczpDmQL0P9l 93CYySJDYB8Or3ny68CWDGCWmUCG0y4jwqAOQeGEoynAZc+O9vYFYweO/SrKc+NTxllO icldtCqTOH5ePL1tDaG+xBuuwJfGXtLItxk/SajnG8gU45q6l8gc9Y0tBwCygqzt1hbA LXZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=4kKcrKeV9F/Qdu736T7k95sF9L6dvtl4xdV9jCWRIzA=; b=mpdp+G9RTY/Dedz976eW9txDa3SOmnsHFjQZu8eBxCkB/lZ+jvGxHo4Ad5yTxoJyJt xrEw2TcgFQOKIkmgqHCYUXUqaWWJJC4Bs4uhZyPmhRzYYex7lvPxA6Gfj8MFPQjXJP3o mcfoOJV8P9yf7D+s9z1rmiiar4Vu52ruIr0QWRZ0x47fnIxW/7PaSK2dSNnYf+5dEq3r HAXvFzKaIlkzrNWiJbr0M9IVLSxyzF5h800qdwNVbs7QP9M2DPGcbVcq+97TLV+Cn1qf 5yieOagEax4C4aX7S1wTOJGxzHUxzfUJ9aScqrLn7WyLK0+NcsuUbBX70bv0xNUwS1Cf bzQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=mkZZzp2Q; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id y126-v6si5239878qke.6.2018.07.02.08.11.59 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 02 Jul 2018 08:11:59 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=mkZZzp2Q; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from localhost ([::1]:33440 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fa0Uh-0004Yk-2t for patch@linaro.org; Mon, 02 Jul 2018 11:11:59 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48491) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fa0TV-0003pF-D1 for qemu-devel@nongnu.org; Mon, 02 Jul 2018 11:10:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fa0TS-0007h0-Ux for qemu-devel@nongnu.org; Mon, 02 Jul 2018 11:10:45 -0400 Received: from mail-pf0-x241.google.com ([2607:f8b0:400e:c00::241]:44243) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fa0TS-0007fw-7b for qemu-devel@nongnu.org; Mon, 02 Jul 2018 11:10:42 -0400 Received: by mail-pf0-x241.google.com with SMTP id j3-v6so7649652pfh.11 for ; Mon, 02 Jul 2018 08:10:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4kKcrKeV9F/Qdu736T7k95sF9L6dvtl4xdV9jCWRIzA=; b=mkZZzp2QMR4H1414eG/tss32R32uqpmxVJ01FqgwqnpukfWqeO6qTLCMw5/f1FMIV4 pkuWXy8GgvaNmc7rV9PODdvHzB8Nes7yDXzQCutPbPDTTqWLz4KOXo642zmGzSO6Q1fI GLu0dJ3W6dU2OhVI1m8X0w7gSs/H2OdTY6WR1Fku2OGc36wuk4KMRFQzsujOjwimDCUR MCLaP9SIvghwIOPpHvmREfGoWr92HMR30zmlOcK/SQbeO29NXhhoT91yzP2U8Zc7Ard5 DPq9Tv8Iez0qsGvGHQrvwEIrf7M6Ftjc+TnMH/iYLh1BCIBvF+BqZM/gicHOhXvrCA8K 47bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4kKcrKeV9F/Qdu736T7k95sF9L6dvtl4xdV9jCWRIzA=; b=A5s11o0+GbB9Qz18sHomht1086TwgrbmzLwx7hlbjtnJV90+/hZUxmhnmCLOYrEDog RliNA9V+rsoRJtirrhMp7n12CeFvJlBnvgxIhdqqHy6frj43B0We55rfjcqcAGqthB26 BGnOzM6ovqDU+d6jCx16lemPtTS7omo89jjevfbn79BCEFHup4iKN7d6/dOFQBv/Bqv5 eaHnZVSyKMfSaqGGqlAoKelNVmk7Rbb/uyFbikk7IMcEyxTU9Qm0cfVxPDneQcEGocry 5bm9rHHDMXD3EuZOwiVe4KDnOuPWOvq+x1muAexx9Yc8Gw+hSNXNsQr/T79+2dEPVszn wubQ== X-Gm-Message-State: APt69E3JBEsp7fu1Km5/X+JDdz8Jy98RFKrX/SmkLbvsyPk4EjZxNzdF 9RqqG+fKplrGN2/Jk4QvSRI= X-Received: by 2002:a62:57dc:: with SMTP id i89-v6mr13777076pfj.65.1530544241199; Mon, 02 Jul 2018 08:10:41 -0700 (PDT) Received: from localhost (g90.124-44-6.ppp.wakwak.ne.jp. [124.44.6.90]) by smtp.gmail.com with ESMTPSA id r77-v6sm10576728pfr.117.2018.07.02.08.10.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 02 Jul 2018 08:10:40 -0700 (PDT) From: Stafford Horne To: Peter Maydell Date: Tue, 3 Jul 2018 00:09:59 +0900 Message-Id: <20180702151023.24532-2-shorne@gmail.com> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180702151023.24532-1-shorne@gmail.com> References: <20180702151023.24532-1-shorne@gmail.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::241 Subject: [Qemu-devel] [PULL v2 01/25] target/openrisc: Fix mtspr shadow gprs X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stafford Horne , Richard Henderson , QEMU Development Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson Missing break when this feature was added in 89e71e873d ("target/openrisc: implement shadow registers"). This was causing strange issues as we get writes into the translation block jump cache and other bits of state. Fixes: 89e71e873d ("target/openrisc: implement shadow registers") Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Signed-off-by: Stafford Horne --- target/openrisc/sys_helper.c | 1 + 1 file changed, 1 insertion(+) -- 2.17.0 diff --git a/target/openrisc/sys_helper.c b/target/openrisc/sys_helper.c index b284064381..2f337363ec 100644 --- a/target/openrisc/sys_helper.c +++ b/target/openrisc/sys_helper.c @@ -98,6 +98,7 @@ void HELPER(mtspr)(CPUOpenRISCState *env, case TO_SPR(0, 1024) ... TO_SPR(0, 1024 + (16 * 32)): /* Shadow GPRs */ idx = (spr - 1024); env->shadow_gpr[idx / 32][idx % 32] = rb; + break; case TO_SPR(1, 512) ... TO_SPR(1, 512+DTLB_SIZE-1): /* DTLBW0MR 0-127 */ idx = spr - TO_SPR(1, 512);