From patchwork Mon Jul 23 20:17:27 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Michael Roth X-Patchwork-Id: 142643 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp6508464ljj; Mon, 23 Jul 2018 14:21:15 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfEVz+0Uly54P+nSfOpzdLq9rUhYbfv6uKf5cn/cNw3R0v4AXIv+iikhufF/29BmHYpesfF X-Received: by 2002:a0c:aac9:: with SMTP id g9-v6mr12637225qvb.78.1532380874924; Mon, 23 Jul 2018 14:21:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532380874; cv=none; d=google.com; s=arc-20160816; b=hSqOXAVhLMnBznIhjGxGGDBHWGvt8rOzQiloiNP1S3qOcM1K2OJWLJ/PsQTbj4eq1o lO3tV3VYTjd3Fvv07V3hr0zzzxlV/NYYe13BS/e86WnLth8oCxQ4ePagEaOINzPcByzp 3/2rcMuwO/svevJIX6IDfz2s9bT4qF2MQ8JW644HnS+VPfPV3xazGsFNWYpx6nCHUHfE +zLhNk+fj6tv0vrTO1PceWSk58Sx3TVvhql/fbZ5NYfLmM5jNZIjd+/xdMBEmoIQsmYA RI7oS5Gx2f7OUYReOv9hxhutnrPKqPFU9IixH6Z/6gX3KT+5VREyj2zZtwtCWJs9H0Ik B94A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=VVvH4YNzTK+zAkrkiwSZ16MOLhc3dhyTKbADCU/yIfg=; b=yUN/bAlHMCZBAEpZQ2x5XaMCdB9500JIPuJS0ds2naJE0VTxwJp15zR+1JFBKE1dkI RVNg7MtYSODD3mqR5G+oY+uvMRe50a640rUNkNIglm0r1BtexXcgVTLwo+2h3JYR7yyI h+WS9BZ4ijssHwX1K+Cr1YL/d8tz8vOTRM2h2OL47KJ9hGDBp2/MTgvc06nzCMMpRgp4 0OGS7s/M+Cu5Ye5qv1kz8hYTf/3NDu8MUFekOUAhF2CqwQF+wYyee4UgvMVfQsYX7p+z 9aahVbO2tuQiLjqboZqKlphDjC1g3Q3Qkx6jj4Ly8j2LyNkoFNhc/M8gTozjfUD+oRD1 xrxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=df7n2tKo; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id c53-v6si3837858qvd.175.2018.07.23.14.21.14 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 23 Jul 2018 14:21:14 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=df7n2tKo; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: from localhost ([::1]:36718 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fhiGY-0006qi-6c for patch@linaro.org; Mon, 23 Jul 2018 17:21:14 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43103) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fhhKg-0003t2-PU for qemu-devel@nongnu.org; Mon, 23 Jul 2018 16:21:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fhhKg-0005MZ-10 for qemu-devel@nongnu.org; Mon, 23 Jul 2018 16:21:26 -0400 Received: from mail-oi0-x22c.google.com ([2607:f8b0:4003:c06::22c]:40354) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fhhKf-0005MG-SM; Mon, 23 Jul 2018 16:21:25 -0400 Received: by mail-oi0-x22c.google.com with SMTP id w126-v6so3482556oie.7; Mon, 23 Jul 2018 13:21:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VVvH4YNzTK+zAkrkiwSZ16MOLhc3dhyTKbADCU/yIfg=; b=df7n2tKoNfJT8Q90wVaHu/73Q0m+wpN9Ro3qK+DCDsNyd+2vHM+DrhOyyi4KRvW/a5 Uzk1EGio8oEumvDlgU03kyWKlBqLKal0WgD4th83AZw7988LOPSU1mcLNhceEtoLeucG 9erp0pK1zneURKtj3NlGUZaaNos1eI5xy5I2P6VCXD0x78PAe1U+DcdBS7fgV/2pa9t8 T1qt8N9E1D0U6yHCVoqAIElYMCfaLK15Mv6EMtPilAycMqiSeah0YdWpRyX/jZbD4DJg iSW/uRrWlGJnfgda3Jg0RuNHNFf2NZc7HD6J8VsHn4qUVdp1D0oejP68D1iCCRCfYHMY 9S8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=VVvH4YNzTK+zAkrkiwSZ16MOLhc3dhyTKbADCU/yIfg=; b=qxJ72/x4BwKfdq4k/BVFBAT3akNy9WjVUrx4gbKl7+1RLccdLf+8ZL7R2vIEpej4EB s0wyFJWzsUHM64a0KK8Zr/6mGWd/7JxVoPchfbDUoX7V8YFIfnfVMm90IWE5hJRUSBo0 eHklheH9D/rkeH4TDaVa5ktYPUCBopS9kKcyhThOuD4GoOOMa5aYUvN8XokZIGKy3G2G WRJHO2CYNbrpkp+OX5D9jBhrt3TL7+Lz6BeCQrtW01dBAgWlOU0Vv+n3fm+NJaFZRAra N5IG+RuUmxv/mtyjtYVU6ckVYomzz67Lrht7HW/Bqo/ThJB7Xl4pCMfhiuuK9zz1N3C1 lCvg== X-Gm-Message-State: AOUpUlGYRlOXQz4Mk4+E5irZoUGE7/1kefWJCEjtligrCFc6wKhcg6WZ g7tkZ+G+8gjGdsah9VUg9WFinYjC8sX3Fg== X-Received: by 2002:aca:4a49:: with SMTP id x70-v6mr278796oia.11.1532377284656; Mon, 23 Jul 2018 13:21:24 -0700 (PDT) Received: from localhost (76-251-165-188.lightspeed.austtx.sbcglobal.net. [76.251.165.188]) by smtp.gmail.com with ESMTPSA id r133-v6sm7511499oia.33.2018.07.23.13.21.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 23 Jul 2018 13:21:23 -0700 (PDT) From: Michael Roth To: qemu-devel@nongnu.org Date: Mon, 23 Jul 2018 15:17:27 -0500 Message-Id: <20180723201748.25573-79-mdroth@linux.vnet.ibm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180723201748.25573-1-mdroth@linux.vnet.ibm.com> References: <20180723201748.25573-1-mdroth@linux.vnet.ibm.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c06::22c Subject: [Qemu-devel] [PATCH 78/99] target/arm: Implement FCVT (scalar, fixed-point) for fp16 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Richard Henderson , qemu-stable@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson Cc: qemu-stable@nongnu.org Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson Tested-by: Alex Bennée Message-id: 20180512003217.9105-5-richard.henderson@linaro.org Signed-off-by: Peter Maydell (cherry picked from commit 2752728016bef06e7c9cfb961019272859beeca4) Signed-off-by: Michael Roth --- target/arm/translate-a64.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) -- 2.17.1 diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 33be611bdb..c5be901b5f 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -5454,8 +5454,21 @@ static void disas_fp_fixed_conv(DisasContext *s, uint32_t insn) bool sf = extract32(insn, 31, 1); bool itof; - if (sbit || (type > 1) - || (!sf && scale < 32)) { + if (sbit || (!sf && scale < 32)) { + unallocated_encoding(s); + return; + } + + switch (type) { + case 0: /* float32 */ + case 1: /* float64 */ + break; + case 3: /* float16 */ + if (arm_dc_feature(s, ARM_FEATURE_V8_FP16)) { + break; + } + /* fallthru */ + default: unallocated_encoding(s); return; }