From patchwork Wed Aug 1 12:31:08 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 143284 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp815984ljj; Wed, 1 Aug 2018 05:34:31 -0700 (PDT) X-Google-Smtp-Source: AAOMgperfGA+E+HsxprYg6iYYeG4jDyqg/syeam5LzTz+8uhOGiEmrK3jCb0JMeXmxKAdt8/j42Y X-Received: by 2002:ac8:3346:: with SMTP id u6-v6mr24920992qta.182.1533126871430; Wed, 01 Aug 2018 05:34:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533126871; cv=none; d=google.com; s=arc-20160816; b=yGLo3UH1ZkUPgLNQ8QtLFSzEFAELmxNmhxzTDn5WZ+Vk+8iBjtGnROsAqmGZgBkOIt 2DOi7E9DS66BH2qz8sT8W7HZ4FDY2W1+G2+p8AvC+LqRxwYVkrbHq0YvETKfTwK3lrYk 9mYDyFziYaoULtHeg9WI5sNU1dSZTVWNK2nyG4l37qYhUD/bYOy2j+sA2sgEtmQBLpHv gVTgti51mZ3ZOGBfSLJusBrCPYYqLvx2WhQ4lyHeX20amhVHuKmx5RHCtezVYPz94lOS iFairjlGOEbh2Eoy4jGlS2a8LcNGqic8ULPQR2AqFiCNpzrmYzlPDNyKT5rLIvAq7jSN Du7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=QmJi8veTXHAPWn+vDwupbHDsSR7WDss7mhFB9JuugSg=; b=0mX5YqjZdjHjLiMCvN9FdJSyUJjG7S63tc3f2cH1H8X3UxzCtK5rdMb1ZdrVgCmVc2 OVqZxj05W0aFGmUPHCzAj3xUlEg5X94A5+TGZC5Xhh7yELOizAVbnn8/kw9x1LmUCkLC 3xGFM/mupeEPJKzYMufM01oJMVz3cfyj0yUxrpjBUqWXN4sr26PkYx1+Nkq/ZlHvh6Jm KAoZerdTbRIh9R9uGJK7pvh6y6T9qrC5hHHXUQQIDtUTT9Fgr1KdUe4CMVm1rSVF3o87 YeeD8cAodVW9YXE7Tx3d4KeBVX8lh+kHKv3e8f0DlBm0LGc9whEDfcxYTG6KWiEjhiOH go0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b="N/UnTB4v"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id v87-v6si32564qkl.303.2018.08.01.05.34.31 for (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 01 Aug 2018 05:34:31 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b="N/UnTB4v"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:39615 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fkqKk-000743-Tw for patch@linaro.org; Wed, 01 Aug 2018 08:34:30 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52104) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fkqHh-0005lG-Pg for qemu-devel@nongnu.org; Wed, 01 Aug 2018 08:31:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fkqHg-0004Qt-GM for qemu-devel@nongnu.org; Wed, 01 Aug 2018 08:31:21 -0400 Received: from mail-ua0-x233.google.com ([2607:f8b0:400c:c08::233]:38534) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fkqHg-0004QL-Bm for qemu-devel@nongnu.org; Wed, 01 Aug 2018 08:31:20 -0400 Received: by mail-ua0-x233.google.com with SMTP id o11-v6so12543518uak.5 for ; Wed, 01 Aug 2018 05:31:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=QmJi8veTXHAPWn+vDwupbHDsSR7WDss7mhFB9JuugSg=; b=N/UnTB4vz3xLRmov3Y8C2xfh+t3d204KdPltZiu5trecaOytG2VAbCprMF1XvBzZo/ Yh9KKWWq1GDabJX4nw9yOLYW3zEfjMyH1G/+gJ6sD5eqd8yOi9CMc87502eCS7dhlU3y Hm/2RgfXLPXBgG2pj3LAuwwIEH4YiF05AkcmM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=QmJi8veTXHAPWn+vDwupbHDsSR7WDss7mhFB9JuugSg=; b=lTXg5jalBNayHazhuSEH52GFQ+HA6SHkYdyLk3Cjqo6R+hRsM+dq+waPCtCIo1izMd KwvCoMmLKPmyoqsOV84FNK1fbm6VkFXXxbmIpgmn/t7tswXzLw+PjjAfOx0q0mACZqbC 0LVMAgrv0uMreAQm9DZ8O4cYE04wvrlz0tviYfAyTEdg6+lXU/5+q+PN65R+0ceIIBeN Rf8Jn6SPqnpxCtdeWeynqiXm7G/qfueQQ1XrXyIpqzgdY81UkJJyVldvN0WBeolQzKxq 1XfF0HDF9d1hgH0vkYYb+TqdpHFRLlf++pH+xasxjzIhuxUbdpX4d7jMVQ4u0nci3GOq sS6Q== X-Gm-Message-State: AOUpUlEb466DnpdRKveSk0U4V4rg2a1wb09doe2s60gW5dmOpLS8u2qs R3ElCG8KIRTIF1aDXD8pRvH2Q5HvvPg= X-Received: by 2002:a9f:37c8:: with SMTP id q66-v6mr18092449uaq.180.1533126679418; Wed, 01 Aug 2018 05:31:19 -0700 (PDT) Received: from cloudburst.twiddle.net ([190.166.236.188]) by smtp.gmail.com with ESMTPSA id f60-v6sm4247847uaf.10.2018.08.01.05.31.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 01 Aug 2018 05:31:18 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Wed, 1 Aug 2018 08:31:08 -0400 Message-Id: <20180801123111.3595-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180801123111.3595-1-richard.henderson@linaro.org> References: <20180801123111.3595-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400c:c08::233 Subject: [Qemu-devel] [PATCH 1/4] target/arm: Fix sign of sve_cmpeq_ppzw/sve_cmpne_ppzw X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: laurent.desnogues@gmail.com, peter.maydell@linaro.org, qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The normal vector element is sign-extended before comparing with the wide vector element. Reported-by: Laurent Desnogues Signed-off-by: Richard Henderson --- target/arm/sve_helper.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) -- 2.17.1 Reviewed-by: Laurent Desnogues Tested-by: Laurent Desnogues Reviewed-by: Alex Bennée diff --git a/target/arm/sve_helper.c b/target/arm/sve_helper.c index 54795c9194..9bd0694d55 100644 --- a/target/arm/sve_helper.c +++ b/target/arm/sve_helper.c @@ -2436,13 +2436,13 @@ uint32_t HELPER(NAME)(void *vd, void *vn, void *vm, void *vg, uint32_t desc) \ #define DO_CMP_PPZW_S(NAME, TYPE, TYPEW, OP) \ DO_CMP_PPZW(NAME, TYPE, TYPEW, OP, H1_4, 0x1111111111111111ull) -DO_CMP_PPZW_B(sve_cmpeq_ppzw_b, uint8_t, uint64_t, ==) -DO_CMP_PPZW_H(sve_cmpeq_ppzw_h, uint16_t, uint64_t, ==) -DO_CMP_PPZW_S(sve_cmpeq_ppzw_s, uint32_t, uint64_t, ==) +DO_CMP_PPZW_B(sve_cmpeq_ppzw_b, int8_t, uint64_t, ==) +DO_CMP_PPZW_H(sve_cmpeq_ppzw_h, int16_t, uint64_t, ==) +DO_CMP_PPZW_S(sve_cmpeq_ppzw_s, int32_t, uint64_t, ==) -DO_CMP_PPZW_B(sve_cmpne_ppzw_b, uint8_t, uint64_t, !=) -DO_CMP_PPZW_H(sve_cmpne_ppzw_h, uint16_t, uint64_t, !=) -DO_CMP_PPZW_S(sve_cmpne_ppzw_s, uint32_t, uint64_t, !=) +DO_CMP_PPZW_B(sve_cmpne_ppzw_b, int8_t, uint64_t, !=) +DO_CMP_PPZW_H(sve_cmpne_ppzw_h, int16_t, uint64_t, !=) +DO_CMP_PPZW_S(sve_cmpne_ppzw_s, int32_t, uint64_t, !=) DO_CMP_PPZW_B(sve_cmpgt_ppzw_b, int8_t, int64_t, >) DO_CMP_PPZW_H(sve_cmpgt_ppzw_h, int16_t, int64_t, >)