From patchwork Fri Aug 10 19:31:29 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 143961 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp328713ljj; Fri, 10 Aug 2018 12:33:49 -0700 (PDT) X-Google-Smtp-Source: AA+uWPzz1x5NOsCFTg/MyBRc5Hdate4zMIoK8FCcEvFzsqblCADFZf6I4hbSrbA0D0x0VPRCY0nO X-Received: by 2002:ac8:2bea:: with SMTP id n39-v6mr7931850qtn.292.1533929629471; Fri, 10 Aug 2018 12:33:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533929629; cv=none; d=google.com; s=arc-20160816; b=sWd/ym5u9g+aqPw73zSI92OzQG0VHDT3ZbdHLp7ikpVDcPjwff2naD7qe0bnVvd01H qD9XDu63DVRZqP5KoZEEdvgg4KIIrP+l00D5kwFssbzBMH0EW17DUaHgYGL+07Mz5N4x fupp2ncjAlUpFZJk3v3gCOquQ+9+6jQlYNUejaXFAiZ4mM5seYoW0Zc7TetS3REnBiub 0vG6jZoRpV+DJDmqixV51gUOlO8XXJ5M5qJGGMJFwqy8lGqchnoP940TgSu26GbfGGVO Rb0MPt3yg73Psw8I4paqHjoSlogb9/+peROythQDbb7u4pPpdk9Hahpwk+uXcuBJ2cNZ +T8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=Y+/qvMWgmtaKUgYpCZgt6h+1WcjiP8pBregr55tLYTA=; b=NBGxM5WUMZ4obWOSuBLn0HO7xxgOjVOM0QRfi2xm7e7x5S6kb8vz7gvOT0vRkbKjna ZONwKgULVeu5yKycEsw80u3NJZU2WaNi9jRzEeyQ7AQnUG9anY+L8GUMCLG1bncbztec a1cnAPSTbMMtrjC/C6skhOWAmcpOBwuNXbvejUewVfLIoqFVlbeLgWctXqJsv+PjtQZX rTo3oeNZLrXoezWQkGWIiDVirB44IjJplSQ8faNO86yDuWq2dG8NyVnEVd4JNtzpJRxV w2Dany7tBcQ3vcJsmsQVrFdQcOUozNc1dIZxh6ojndiBhHQF4gMv9oy8RKHOsOtkcfBA PWJg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=Y+ONhweV; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id v87-v6si10055190qkl.303.2018.08.10.12.33.49 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 10 Aug 2018 12:33:49 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=Y+ONhweV; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:57710 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1foDAS-0003gG-Td for patch@linaro.org; Fri, 10 Aug 2018 15:33:48 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59128) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1foD8Q-0002Se-0r for qemu-devel@nongnu.org; Fri, 10 Aug 2018 15:31:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1foD8P-0005fV-B5 for qemu-devel@nongnu.org; Fri, 10 Aug 2018 15:31:42 -0400 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]:44954) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1foD8P-0005f2-5O for qemu-devel@nongnu.org; Fri, 10 Aug 2018 15:31:41 -0400 Received: by mail-pg1-x543.google.com with SMTP id r1-v6so4829227pgp.11 for ; Fri, 10 Aug 2018 12:31:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Y+/qvMWgmtaKUgYpCZgt6h+1WcjiP8pBregr55tLYTA=; b=Y+ONhweV4FCP6WxMn+pY8DgqzWq4G0u01Ul/C9qhZT6XLTpiLsjmX2py9nFGO7R5Gd aZoZYZQ9MK4CqAp+DaePgUQ/XaokK7M8/YZUjhmkSFYoTHyZs4NiWMfw6C0ch54McArN tO5tMXKm/bEbo7oe4HHfT6tqZUsROHWC8sodg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Y+/qvMWgmtaKUgYpCZgt6h+1WcjiP8pBregr55tLYTA=; b=VLf6/2+hprkrviG8aySm3LoMB/+Ef4SBc4h9ZGTYBm4Ut6aQhwBwAW6zAog9en0AZj QjABrTABLC3FurgiFvYm/eBdkFygv+ub/4DSFOrTtnI8GrVnobBzEPyiV+zKiuJyWWaA vCzMZ53cgjgoWfvZ4Xkb1zv3p/EtNJRhePOCMe9rUyjb4itBw+ehHHysvMuYgD+jcrLG JoD/NyL8/FaeowvD1HqM3A8sf+3Gv0xhRGQDKHGkcl9s8zQh+OCkYyDVYP6VG+y+YY5h 9yUGQ5zIM8fOM+D/q1PcDpUq0Wr/LsMKDY2kbDbC5MlhV5+bs5gyclfiEFb31l/Pj7ky zYCQ== X-Gm-Message-State: AOUpUlFUekNrSY4OtLwzTFJ3CYzPRoB7kB02U5AVDV6Wk03ZBOiaR+yS z61zcGXCK4WhFdUD/XdpzmPOUTulQA0= X-Received: by 2002:a63:f002:: with SMTP id k2-v6mr7533133pgh.8.1533929500008; Fri, 10 Aug 2018 12:31:40 -0700 (PDT) Received: from cloudburst.twiddle.net (97-113-8-179.tukw.qwest.net. [97.113.8.179]) by smtp.gmail.com with ESMTPSA id g28-v6sm20500949pfe.41.2018.08.10.12.31.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 10 Aug 2018 12:31:39 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Fri, 10 Aug 2018 12:31:29 -0700 Message-Id: <20180810193129.1556-7-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180810193129.1556-1-richard.henderson@linaro.org> References: <20180810193129.1556-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::543 Subject: [Qemu-devel] [PATCH 6/6] softfloat: Fix missing inexact for floating-point add X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: laurent.desnogues@gmail.com, peter.maydell@linaro.org, alex.bennee@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" For 0x1.0000000000003p+0 + 0x1.ffffffep+14 = 0x1.0001fffp+15 we dropped the sticky bit and so failed to raise inexact. Reported-by: Laurent Desnogues Signed-off-by: Richard Henderson --- fpu/softfloat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1 Tested-by: Laurent Desnogues Reviewed-by: Laurent Desnogues diff --git a/fpu/softfloat.c b/fpu/softfloat.c index 8cd2400081..7d63cffdeb 100644 --- a/fpu/softfloat.c +++ b/fpu/softfloat.c @@ -701,7 +701,7 @@ static FloatParts addsub_floats(FloatParts a, FloatParts b, bool subtract, } a.frac += b.frac; if (a.frac & DECOMPOSED_OVERFLOW_BIT) { - a.frac >>= 1; + shift64RightJamming(a.frac, 1, &a.frac); a.exp += 1; } return a;