From patchwork Wed Aug 22 01:14:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 144790 Delivered-To: patch@linaro.org Received: by 2002:a2e:164a:0:0:0:0:0 with SMTP id 10-v6csp171246ljw; Tue, 21 Aug 2018 18:15:56 -0700 (PDT) X-Google-Smtp-Source: AA+uWPwIQVkYIXLcRRx4NnU/UK7VA5IySEEFFXiEVn43wqL0NmDWQkIi9e9pkgRdrw7ni7MlvqUd X-Received: by 2002:a37:9505:: with SMTP id x5-v6mr48524615qkd.287.1534900556781; Tue, 21 Aug 2018 18:15:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534900556; cv=none; d=google.com; s=arc-20160816; b=dXf4YcpnA8c3aBurTJkEIoTSl48jE+YhXT/ehL3/opc01bmDFZWQkETd/pYlhkLprk DuYRewlWmB9csLpcauqXtaPNg+jGqY/WtzwLaHY4cmSKWJ+jXqG3SD3rgY6Nzz/k4ZHI tHwF3gF3WCtRJRZtdcLbZE3Qx1kqTOvIQb6zVTnttNne227z4hF2+eGBfh1/62sYRCuQ 1mCwQoSjsf2KipnMvtdUrmowYh0S3qPVbe0STJVzVNPU/lR1Sh9ZlVLf5x9sSzMET8zd BkX67CqUOMURKUm+2kc6XXPka759nGpXyNNqRdh9VM81UBEyufT7ezMTHut4BfijLDMP +DlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:arc-authentication-results; bh=q3sOVn+m2ryFTAzwTOk9e/VX+s0PTSNdZ+i13KKdHGw=; b=cn0cYxLSOpTcjj3a6N50bQX2TK04KY77r+GGrp3faADWVtJ+HSfWxjvrS9PphOBxIb HXoNpp9WK56+W5waLUBfLqGhP/xuUQu9STAJ67zmYMOIPQN8bKvT+IwREdhx9HnZTsLr FLNzwJhuCO5q+p3qE4yDKpgJhp4MdQrd6zIvDxrRhk0P4V2ZLUDP8rRDOK7hmwZ1arb/ olIhCYDAMYWS+6f3ynnNk5eH9VO05mfhdKeykoMue/+Mujh0YfqKDdwULz4pQXy3cNeR z5pXzjBztRNyOts2uCi7kFEFtZmmLa936qAMtfgcfxIMTgg+Mx+r4kMa5AWS4NlznpDc vAhQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id k8-v6si291233qvo.41.2018.08.21.18.15.56 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 21 Aug 2018 18:15:56 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1]:56417 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fsHka-00077H-63 for patch@linaro.org; Tue, 21 Aug 2018 21:15:56 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36503) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fsHk3-00073U-Va for qemu-devel@nongnu.org; Tue, 21 Aug 2018 21:15:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fsHjv-0001ui-2a for qemu-devel@nongnu.org; Tue, 21 Aug 2018 21:15:20 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:41147) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fsHjs-0001rs-Nu for qemu-devel@nongnu.org; Tue, 21 Aug 2018 21:15:14 -0400 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue102 [212.227.15.183]) with ESMTPSA (Nemesis) id 0Lp7GG-1gLpeJ0zdk-00ey1t; Wed, 22 Aug 2018 03:14:27 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Wed, 22 Aug 2018 03:14:11 +0200 Message-Id: <20180822011417.11608-2-laurent@vivier.eu> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180822011417.11608-1-laurent@vivier.eu> References: <20180822011417.11608-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:IIWg7uud6obg4spBvNuoxHrJDXTfaA8op5lpxILWx7eTJI6O1w1 90V4BmVcTau6/VSArO087foyZ2aL3mgiHZLXvW0a4G+d7V9iLuMiKztr8J9IUN7RrU6wHWD pr4OJ16qg+1wnMjKk1xi44ntgIKquZS5V6Ga09Xjm1TI7PymKNt0mQt9+RyNhJdoBkJ/0rD 1CQPuyznrKdPTfiA635lA== X-UI-Out-Filterresults: notjunk:1; V01:K0:RbVxLzpx2OE=:j4iiOc8gvXfzBNR0gfhuHy 6EuwvLh+oNxVlxFOZUxEqh8i4BkVkFC8r3tKnzzlmujg7+KDmJ4h0aD5laYwczDyF4OsncJ87 hD1UzHrMTxXN2vRn06OEE8qzIkXbR6XYclY1Q85zm/dh/2RhJ+UjiiWmMKzC6Wj44nzl0EoVu mf9/N9urvDxH8M4YhM2nIQPOMumLN3MFlcKONSGuxW92pb5aN+eGXt9Fde/3LEarlobyfJOB8 zhj4/JcwryZfTWsaG7fYFrwRXRUgRTmX/Rt91nmECloOD1lryfQy+yKPDVLDgC5ES9tMRtz9K HkPBZaAjGCSL3ixu9z2sgLIIWUgc+dgRJFf0huxGXDC8YUwZV/SRw7LFQ5zNhUoRgLyhitdjG KIBTaSewBUzOdrYFKdOE9GPw25K+GGJ+BL6xEbz2zBx6SvZAfwylOkAeZILUgMgGikKCx3N2c 8NYjiw2xFIwkPXSoK8DODw+/JS7px7BIMxS2W9/cT43VOciLuco0TZGP09ZDHep/EtTAo/hm2 utO2o/D7JbxClIZ8KwSyDqkRmpFZ7XM38+/WREMOgM+lAReBwnTI2lyWKoxPmT4LWtDQDojQp ynBLqF1hz/9NhYe6Xt/UkTuiuxvwWDDrP2BAnW1l3HdEoFQijfQUed9NUjxJvknVVirqJgCKF 9D1H0tD8ar81Y+i9dbRK++HN6LsQ2HBUAxtoDDDf3V4cEtUC/lV89rFZuwxyqaFmxMsjZrYNQ Si6r97445L+f5UXt X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.17.13 Subject: [Qemu-devel] [PULL 1/7] linux-user: Remove DEBUG X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Riku Voipio , Richard Henderson , Laurent Vivier Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson This is redundant with both -strace and actual tracing. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier Signed-off-by: Richard Henderson Message-Id: <20180818190118.12911-2-richard.henderson@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/syscall.c | 10 ---------- 1 file changed, 10 deletions(-) -- 2.17.1 diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 202aa777ad..2e45f854f7 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -163,7 +163,6 @@ * (The one remaining unallocated bit is 0x1000 which used to be CLONE_PID.) */ -//#define DEBUG /* Define DEBUG_ERESTARTSYS to force every syscall to be restarted * once. This exercises the codepaths for restart. */ @@ -5884,9 +5883,6 @@ static abi_long do_ioctl(int fd, int cmd, abi_long arg) ie++; } arg_type = ie->arg_type; -#if defined(DEBUG) - gemu_log("ioctl: cmd=0x%04lx (%s)\n", (long)cmd, ie->name); -#endif if (ie->do_ioctl) { return ie->do_ioctl(ie, buf_temp, fd, cmd, arg); } else if (!ie->host_cmd) { @@ -8132,9 +8128,6 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1, } #endif -#ifdef DEBUG - gemu_log("syscall %d", num); -#endif trace_guest_user_syscall(cpu, num, arg1, arg2, arg3, arg4, arg5, arg6, arg7, arg8); if(do_strace) print_syscall(num, arg1, arg2, arg3, arg4, arg5, arg6); @@ -12949,9 +12942,6 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1, break; } fail: -#ifdef DEBUG - gemu_log(" = " TARGET_ABI_FMT_ld "\n", ret); -#endif if(do_strace) print_syscall_ret(num, ret); trace_guest_user_syscall_ret(cpu, num, ret);