From patchwork Tue Oct 16 15:23:24 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 148960 Delivered-To: patch@linaro.org Received: by 2002:a2e:8595:0:0:0:0:0 with SMTP id b21-v6csp5245881lji; Tue, 16 Oct 2018 08:35:40 -0700 (PDT) X-Google-Smtp-Source: ACcGV62H+Qes9LmKRz4kPvJRNooI9yDZjrZ4oPo0/ipE4X/Nr7t/WFbnkIImKlbf734unysQjm37 X-Received: by 2002:ac8:1967:: with SMTP id g36-v6mr20060490qtk.193.1539704140459; Tue, 16 Oct 2018 08:35:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539704140; cv=none; d=google.com; s=arc-20160816; b=0jrXdFtJUOM0BqylQRyYDS7gxEQkqWjssLtCWxI1o2x3XmeNCRLtn0UHrJvvA/r9vB 9A3byqAMf+1SN3LM4b3SONLUNiHk6rFo0pwPRAvjLChriVEYZrahSBgTeNM1/w6ldCc/ QijuI+F2pFNmx7ejog/Rq51oAa/1P/3SpQOrkgw/pnmXxmyvre/krc2tMY6r23h3hiRV fsRTYQMGOrzx5SJoSxCo40CMYBJQU13UTO5kwTDsuYJodxRyymAkGI1aVgz+8A1MWDDg jPyVWZ/G4RUm3JW5LM9AY/Xb0BW7QmsuGh3wulgpgBIvPYgYz+yEQzpKbyLalPNd+z9N uuWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from; bh=GXbLmc+uOsSsbGXdda4QKgyboAK7KmgU2DbiGIvYLoI=; b=GLLtxc9wgiMzolMAiGofBJS3Cr9B7Qq2GPTNIu52bjxKTFu3gP6CVej1xjs7bohAYp 2q7YhPT6YiPpByUSs1UiBCI1c6q1pfzEgL20u/sCD4wN56zBdZW1ZgR3gZI2uaT+hrlN e7Rdcxq389pYl8nBqGGsBhEzhBdjVlCUHQ/w8G3/eJRT+Gc/g3RCz+TzRzmNSUkZ2EcR oZIOQVIBaBmA2+dGsCvznpTbPxHTiQ6EzuTLM10ha8lPMLXyMp+N/yxHn8tQPKif7JHC QzDk0MYFG/cOw9b0APoNtOVtAqQkUuQX8JhBqjz9bUXWSiXaZh7gk/+wpWHAJjVVNGyu FGhw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id v89-v6si4130qte.376.2018.10.16.08.35.40 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 16 Oct 2018 08:35:40 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:58724 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gCRNj-0002xR-Me for patch@linaro.org; Tue, 16 Oct 2018 11:35:39 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43175) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gCRCX-0000z7-CQ for qemu-devel@nongnu.org; Tue, 16 Oct 2018 11:24:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gCRCW-0000Aj-Lx for qemu-devel@nongnu.org; Tue, 16 Oct 2018 11:24:05 -0400 Received: from orth.archaic.org.uk ([2001:8b0:1d0::2]:51906) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gCRCW-000803-DL for qemu-devel@nongnu.org; Tue, 16 Oct 2018 11:24:04 -0400 Received: from pm215 by orth.archaic.org.uk with local (Exim 4.89) (envelope-from ) id 1gCRCG-0003qV-1y for qemu-devel@nongnu.org; Tue, 16 Oct 2018 16:23:48 +0100 From: Peter Maydell To: qemu-devel@nongnu.org Date: Tue, 16 Oct 2018 16:23:24 +0100 Message-Id: <20181016152325.31367-19-peter.maydell@linaro.org> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20181016152325.31367-1-peter.maydell@linaro.org> References: <20181016152325.31367-1-peter.maydell@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:8b0:1d0::2 Subject: [Qemu-devel] [PULL 18/19] target/arm: Initialize ARMMMUFaultInfo in v7m_stack_read/write X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The get_phys_addr() functions take a pointer to an ARMMMUFaultInfo struct, which they fill in only if a fault occurs. This means that the caller must always zero-initialize the struct before passing it in. We forgot to do this in v7m_stack_read() and v7m_stack_write(). Correct the error. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Message-id: 20181011172057.9466-1-peter.maydell@linaro.org --- target/arm/helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.19.0 diff --git a/target/arm/helper.c b/target/arm/helper.c index 7a53098888d..e3946562aa1 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -6472,7 +6472,7 @@ static bool v7m_stack_write(ARMCPU *cpu, uint32_t addr, uint32_t value, target_ulong page_size; hwaddr physaddr; int prot; - ARMMMUFaultInfo fi; + ARMMMUFaultInfo fi = {}; bool secure = mmu_idx & ARM_MMU_IDX_M_S; int exc; bool exc_secure; @@ -6534,7 +6534,7 @@ static bool v7m_stack_read(ARMCPU *cpu, uint32_t *dest, uint32_t addr, target_ulong page_size; hwaddr physaddr; int prot; - ARMMMUFaultInfo fi; + ARMMMUFaultInfo fi = {}; bool secure = mmu_idx & ARM_MMU_IDX_M_S; int exc; bool exc_secure;