From patchwork Wed Nov 7 15:54:05 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corey Minyard X-Patchwork-Id: 150411 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp5330899ljp; Wed, 7 Nov 2018 07:55:06 -0800 (PST) X-Google-Smtp-Source: AJdET5fThCAVItDsNx5j+T26ZpOZQKq9zvek1MRJ+UrLocgHTC5aICdbUafJ86zj/q1fP4A1Ubbb X-Received: by 2002:ac8:674b:: with SMTP id n11mr762687qtp.104.1541606106877; Wed, 07 Nov 2018 07:55:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541606106; cv=none; d=google.com; s=arc-20160816; b=Mx86IYtS6HA1S92CkbptXCpvpFTWWfxCYdrdKdc/xo+ylW/NBUwU9+zuVHnOnoVrYz bBXFbuelupmcrokHNi26+bqf8f3CvjXZ43WZj+2ENDb/f6Mhh9i5B7ahMSgG+ZNijE93 b0dX47WPvlanAPOkKkTv9qDaqHbG7XjlcNWvWtDCv0oGQIOievnPQXPJwS0aiCB521Ud SgIixgYy4h+2J+9UGSK6L+tCGbMZ6kvGn4WfqbuFxmZXSsCho2YUA7MmmfchQHIkjf1+ m7xIbwKReBymYcaadl/TCP5ooIycIkLAHQa96/IwkPCOpPS2QaKYJ2rqI2dG5gLll887 thTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=uy2OKLTiDnFEns3o9LzMnFpxj5U0/822p3D8iG2rJbQ=; b=dx6HnIkU2FlfLKs2wju8mJFL8UyaaDFC8CkFRpErE3mbWvALoyv29UWR/sAPPXpXWy QHEW6F0KZirqAYJmywFCnd0P5dm2azQmED3QR+hFPQ88Pp9x/gXvE3uPbqK+23eSYiMD 27Y0O4cGBZe4zWqe08M2LXwQg9vVXp4dFH74BKzsCVyjvbcbvCogjja+efdq5hihvmFw NHLBYdlDGl1yPV5sZFm6vWwkt9fedBVO+23Cw/vDOj2feWkkTRPmrqqF2K7LhyoyrmS+ xcaHkPDB+Vhm0RIoh2wrWzwJZxKixdOzbbXOMLe5DVYhLHeniZu/xAJpLKEqm/k//Oti 0LIg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=AmdosAyK; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id f132-v6si727700qkb.45.2018.11.07.07.55.06 for (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 07 Nov 2018 07:55:06 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=AmdosAyK; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1]:49042 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gKQAc-0000X2-9d for patch@linaro.org; Wed, 07 Nov 2018 10:55:06 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44254) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gKQAE-0000VJ-Fg for qemu-devel@nongnu.org; Wed, 07 Nov 2018 10:54:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gKQAA-00020b-91 for qemu-devel@nongnu.org; Wed, 07 Nov 2018 10:54:42 -0500 Received: from mail-oi1-x244.google.com ([2607:f8b0:4864:20::244]:36242) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gKQA8-0001xP-FL for qemu-devel@nongnu.org; Wed, 07 Nov 2018 10:54:37 -0500 Received: by mail-oi1-x244.google.com with SMTP id r127-v6so14209887oie.3 for ; Wed, 07 Nov 2018 07:54:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=uy2OKLTiDnFEns3o9LzMnFpxj5U0/822p3D8iG2rJbQ=; b=AmdosAyKvPXRBnhOOuEJAoqrTT/OlhEcHRq4+7wg2ISyO7H7nIxbxrC2sTPTW2lJax DIZJYqW9cM8wSCy/GnQd4FrHty2hsUnbM/7k8s4n9nG0SwmACu4O9rbUP0AxFd9ou20x 4DP9N9smVAXStPmHRSpA1mddUcAXxzpHJN9RRy8bbakNpuG84AsVM0sOK4dH3OFtiHBd KmxUEMo/sN3E8fcBRhIbneChqUW1kv72QC6mvSWs2r566iqkdMpDPfxEg+Ir097pgebW H3YtN1GETN2j4pLNmitDAGCEaKQWTeum5zcdEWe1jCG2A0n69SxDLCvU52UVAc1Mb6yA VmjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=uy2OKLTiDnFEns3o9LzMnFpxj5U0/822p3D8iG2rJbQ=; b=TGQZ+VTmtnbJ/t2dDv8Vq6k1iILFZWdTDzldOWdkLFcRAc4K5HV8ySJQYdY9yy2OsM N0irebCX0KShmyP+Sro1V6RkPImPhj0fMc3O8ait9Lf+9vm64mtfrprmXNYi4NS5AlFs XXAuHjmlhJBev+ZUlNkZy3AsHr/nNnglSczZkrnWEXFk7/qYGw6gAWA4264u+mcDQ1I3 L2oFZj2FwWOjb4rbILWoWe0S3/pYvSPSUuCpWV8m6X8i9gNQHpIMabhbYI5wEG8XuIEP SxdCVWOgArbqCaooILPgRQModNLxprjkMtBmr1DH8E2IMREyzzp5cUg6m+Xnu8knBM01 RAGw== X-Gm-Message-State: AGRZ1gISyLaY0VSl5VMpmgej292VHOZ7lyIRrUf9kHmQuMoCEXhwl+/l 0zHn6gOkctABXfltXC8gniOcuZA= X-Received: by 2002:a54:488f:: with SMTP id r15-v6mr457446oic.80.1541606072791; Wed, 07 Nov 2018 07:54:32 -0800 (PST) Received: from serve.minyard.net ([47.184.170.128]) by smtp.gmail.com with ESMTPSA id i35sm345275ote.69.2018.11.07.07.54.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Nov 2018 07:54:30 -0800 (PST) Received: from t430.minyard.net (t430m.minyard.net [192.168.27.3]) by serve.minyard.net (Postfix) with ESMTPA id 4614DF26; Wed, 7 Nov 2018 09:54:29 -0600 (CST) Received: by t430.minyard.net (Postfix, from userid 1000) id 5E2D9301154; Wed, 7 Nov 2018 09:54:28 -0600 (CST) From: minyard@acm.org To: qemu-devel@nongnu.org Date: Wed, 7 Nov 2018 09:54:05 -0600 Message-Id: <20181107155405.24013-4-minyard@acm.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181107155405.24013-1-minyard@acm.org> References: <20181107155405.24013-1-minyard@acm.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::244 Subject: [Qemu-devel] [PATCH 3/3] i2c: Add vmstate handling to the smbus eeprom X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Corey Minyard , "Dr . David Alan Gilbert" , "Michael S . Tsirkin" Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Corey Minyard This was if the eeprom is accessed during a state transfer, the transfer will be reliable. Signed-off-by: Corey Minyard Cc: Paolo Bonzini Cc: Michael S. Tsirkin Cc: Dr. David Alan Gilbert --- hw/i2c/smbus_eeprom.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) -- 2.17.1 diff --git a/hw/i2c/smbus_eeprom.c b/hw/i2c/smbus_eeprom.c index f18aa3de35..d4430b0c5d 100644 --- a/hw/i2c/smbus_eeprom.c +++ b/hw/i2c/smbus_eeprom.c @@ -29,6 +29,8 @@ //#define DEBUG +#define TYPE_SMBUS_EEPROM_DEVICE "smbus-eeprom" + typedef struct SMBusEEPROMDevice { SMBusDevice smbusdev; void *data; @@ -97,6 +99,17 @@ static uint8_t eeprom_read_data(SMBusDevice *dev, uint8_t cmd, int n) return eeprom_receive_byte(dev); } +static const VMStateDescription vmstate_smbus_eeprom = { + .name = TYPE_SMBUS_EEPROM_DEVICE, + .version_id = 1, + .minimum_version_id = 1, + .fields = (VMStateField[]) { + VMSTATE_SMBUS_DEVICE(smbusdev, SMBusEEPROMDevice), + VMSTATE_UINT8(offset, SMBusEEPROMDevice), + VMSTATE_END_OF_LIST() + } +}; + static void smbus_eeprom_realize(DeviceState *dev, Error **errp) { SMBusEEPROMDevice *eeprom = (SMBusEEPROMDevice *)dev; @@ -121,12 +134,13 @@ static void smbus_eeprom_class_initfn(ObjectClass *klass, void *data) sc->write_data = eeprom_write_data; sc->read_data = eeprom_read_data; dc->props = smbus_eeprom_properties; + dc->vmsd = &vmstate_smbus_eeprom; /* Reason: pointer property "data" */ dc->user_creatable = false; } static const TypeInfo smbus_eeprom_info = { - .name = "smbus-eeprom", + .name = TYPE_SMBUS_EEPROM_DEVICE, .parent = TYPE_SMBUS_DEVICE, .instance_size = sizeof(SMBusEEPROMDevice), .class_init = smbus_eeprom_class_initfn,