From patchwork Fri Nov 30 21:52:15 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 152606 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp4178728ljp; Fri, 30 Nov 2018 14:06:14 -0800 (PST) X-Google-Smtp-Source: AFSGD/WCLcMR5O26BlC9cm/4UeJvUaYmf8+e5FZ7/ufYOT6izhDqQV/Af4f70gWGLP6zWRent6R1 X-Received: by 2002:a25:7e04:: with SMTP id z4-v6mr3654225ybc.118.1543615574301; Fri, 30 Nov 2018 14:06:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543615574; cv=none; d=google.com; s=arc-20160816; b=BjnFPIXqtTU4QaeHNKZZa66qI79iQe06qYPjZGijMtC+6SXsYgNpBWyxedvru1BYPK lP4qvGyRoCDT7pI++OkzPlY+a/1OCTC1bsB3WOSAJmoNOe7pz89ZiZHXKuMkRnOThbyE vUeAFAhp04K6pYlIyVQ3GwvIpIR9ebOp9o60OU3mvMVopTzDg2WxKhrLjSdy+eB5T63h 60nWcypDb+HpinoLTHGEbIP/fbhCaQrul71nXS8CN/v3UJKEvEQVMCobGc5r1wRt4DmS UGXfS8t5zGRATzIqAbVz57ot4Hl0sqVMt86O4/VWXoaBOSshNx4uGZFdL8h6WuMbVpFq mXWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=ic9yGA2IXubLUWfhTU5XIR+gEPgnKoDxdXyZYSEXZTY=; b=ARjMSfNFl0TXXF1JiSZFIY/lBW3ZBHV9Z/nFyZJ/0epDRuDhLyYi6fSxIDd6q3GCjr 5CxWRM8DLHB7bLsKu1/0kjUXXcLHIoMLumlKA6Ah3+FlBtWHWm+n23tWH2e034pGp0Ep mg3Pi5BaQpkLKs71qgicz2ZbCphH1VhxxGkZ3pH7NY953w7m0jA7HIbPBQv1QEbubXZt 316Z6Noe8qWDJ38rqkNbZuTsOvAkdY7U9NJ+vdJSAmskj3vduUs1yNpQLx6lwl5LQsNh yJ6dQ3YdnHF9vowQmRaxvFhd+p66n2WzZgtWLidLdfvQQ+fBAxNOyYd1PkCKOh8W8qTY pixA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=Qx2z6GhK; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id 84si3843988ywo.466.2018.11.30.14.06.14 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 30 Nov 2018 14:06:14 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=Qx2z6GhK; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:34816 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gSqvN-00065y-Kh for patch@linaro.org; Fri, 30 Nov 2018 17:06:13 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52603) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gSqiE-00081Z-7z for qemu-devel@nongnu.org; Fri, 30 Nov 2018 16:52:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gSqiD-00078G-FH for qemu-devel@nongnu.org; Fri, 30 Nov 2018 16:52:38 -0500 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]:45290) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gSqiD-00074K-9c for qemu-devel@nongnu.org; Fri, 30 Nov 2018 16:52:37 -0500 Received: by mail-pl1-x643.google.com with SMTP id a14so3408303plm.12 for ; Fri, 30 Nov 2018 13:52:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ic9yGA2IXubLUWfhTU5XIR+gEPgnKoDxdXyZYSEXZTY=; b=Qx2z6GhKoY/vdSNyKgeQw8eF38a6Uv46Bm47oIrTrtnPMLUJ/pT7lTo2YFIES43jvL lk5CZ4x+9x6xWysXJb7/tSKTomO/o6j20wdb61inoI4pa9jt4Z21Cuuj5JYJrycG7Z6x 7OEOzF2o71anqi6aAIAA3J4A/gs3Nk38p8sxs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ic9yGA2IXubLUWfhTU5XIR+gEPgnKoDxdXyZYSEXZTY=; b=C+fMR3Bwn5igy3YBZW2TqHRT9W22Pd3OoH1h1Y3ISoQmkjRQgPMHniVYj8/mekYiR+ +uEx9d90gNpGfHCor80Xrk1OwasQilBTps7Juz4toq3XHMy71syX5AOsjV/gs7FvgX5i 9hdF5goYUQkIhJOM45OiWvHAPYkXi3Z4xySMG+Oprz+ymmF95h8VhjnfqRbdsP6OBIj+ nyMUDFGPrfDIBjwxwnJcCV5An36RRuKN6qHHNt0N7eMQ4WzAJHargxUNpI/w1rq7rTSC Cl2dHPm4cGeHv4mhYeqrFX8qv0DlDPVeHPzD/Dq+/k6/065AzQlujOItz0qA7agsutON FRZw== X-Gm-Message-State: AA+aEWYz2ZATEwwBxhou9Kb9EavnKcUvFdfasjFpNl4g71ulCRXnZ8As 8wiYmxNKXUp8tnWpWV101+S/EaRZAtQ= X-Received: by 2002:a17:902:8d8e:: with SMTP id v14mr7203167plo.133.1543614755937; Fri, 30 Nov 2018 13:52:35 -0800 (PST) Received: from cloudburst.twiddle.net (97-113-170-180.tukw.qwest.net. [97.113.170.180]) by smtp.gmail.com with ESMTPSA id a18sm6973967pgj.30.2018.11.30.13.52.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 30 Nov 2018 13:52:35 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Fri, 30 Nov 2018 13:52:15 -0800 Message-Id: <20181130215221.20554-11-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20181130215221.20554-1-richard.henderson@linaro.org> References: <20181130215221.20554-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::643 Subject: [Qemu-devel] [PATCH v3 10/16] tcg/mips: Remove retranslation code X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" There is no longer a need for preserving branch offset operands, as we no longer re-translate. Signed-off-by: Richard Henderson --- tcg/mips/tcg-target.inc.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) -- 2.17.2 Reviewed-by: Alex Bennée diff --git a/tcg/mips/tcg-target.inc.c b/tcg/mips/tcg-target.inc.c index cff525373b..e21cb1ae28 100644 --- a/tcg/mips/tcg-target.inc.c +++ b/tcg/mips/tcg-target.inc.c @@ -483,12 +483,7 @@ static inline void tcg_out_opc_bf64(TCGContext *s, MIPSInsn opc, MIPSInsn opm, static inline void tcg_out_opc_br(TCGContext *s, MIPSInsn opc, TCGReg rt, TCGReg rs) { - /* We pay attention here to not modify the branch target by reading - the existing value and using it again. This ensure that caches and - memory are kept coherent during retranslation. */ - uint16_t offset = (uint16_t)*s->code_ptr; - - tcg_out_opc_imm(s, opc, rt, rs, offset); + tcg_out_opc_imm(s, opc, rt, rs, 0); } /*