From patchwork Fri Dec 14 03:19:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 153730 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp1605505ljp; Thu, 13 Dec 2018 19:38:04 -0800 (PST) X-Google-Smtp-Source: AFSGD/WR4UEZab5B8cyrn02Jz3MvBoi21kiLiXjLJox2jP/w+u2f/qFJfvqHFdvHgoAbldQ43X9p X-Received: by 2002:ae9:e8d7:: with SMTP id a206mr93870qkg.317.1544758684112; Thu, 13 Dec 2018 19:38:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544758684; cv=none; d=google.com; s=arc-20160816; b=xf5qes1H7uUAzUD7Ck8jE5xfyHZog83yCj/ZuN23C8oqYT5mmeH+HQrBKqb2pJiUpX EmxBaFKL1Bvvmu9FTDIX4g8C+rxjxK517XStq1RDT5NLvGM+3x6cZ4sEZp1+hWeGcta/ lkliYF8ma9TT4XVNq/omjrXwdfX8eiCdGu0eUFDkImo+ZrO38lqOQkq1ljEdcVwJDLm9 sO5XosBW17mhyQAPMTeimP8uQXonNwg7ghITDQZfb1HWYWo4TkyDKhtCxNK17Or6xKqh JwK8c6REj442dSToe/F3+UTUNjLy5x9Wfb+1D+rH/Yj1dgCwhUTB50GnxiyLxkHHTdPu 9vhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=b/KrQm54Hq8g9c6ylntqi8uAZ7geEAnFxKWxRn7UGwQ=; b=FBLA8tUi2oAr1jbzbNAHzwxPPb4ass5lijuMNzlJIip/877u9kOWFwM1bZWEVligzw EQR2t2YDdpRrwn4ZIFIURs7TkmXqq93B8V5fveInMDP7vK8R/ehDKwxs7YcO5/wQThxF /L6Pw4LwrNVJdyhciEumq0ds3BUA8BTWVIAMiCpzxyEv3aClBQZRR+i2TDN1YNM6oxk5 wrZXcezG4o9kjBZmoXhSY5mTWLYfbYSTbQWZa8E1s7jTVKq5XKJoz9ciMFfGBtxGUKjF rxaAD189SuDZ1fjgizmuxvJWxh5NHbxKOsNABxQvQvJEUw29dVDVHJYANeC1ahI67/Cr QFnA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b="FyQ/bZLj"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id n37si2231283qtc.72.2018.12.13.19.38.03 for (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 13 Dec 2018 19:38:04 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b="FyQ/bZLj"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:59149 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXeId-0005PJ-KY for patch@linaro.org; Thu, 13 Dec 2018 22:38:03 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58794) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXe0r-0005wb-QA for qemu-devel@nongnu.org; Thu, 13 Dec 2018 22:19:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXe0q-0006oO-UE for qemu-devel@nongnu.org; Thu, 13 Dec 2018 22:19:41 -0500 Received: from mail-oi1-x233.google.com ([2607:f8b0:4864:20::233]:41268) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gXe0q-0006n9-O0 for qemu-devel@nongnu.org; Thu, 13 Dec 2018 22:19:40 -0500 Received: by mail-oi1-x233.google.com with SMTP id j21so3458577oii.8 for ; Thu, 13 Dec 2018 19:19:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=b/KrQm54Hq8g9c6ylntqi8uAZ7geEAnFxKWxRn7UGwQ=; b=FyQ/bZLj+HG0z3FYawTDSasyFIQHUV5cDB/UavZLrbNlkWnZ3Q+vmy1ETO7P/zaKA8 JXPt9GEnQx7lxi1/vhR+3JwhB/700sJxra3AhPpNKgqhyq2AuhMPP1PtqMdh1g5Sh5LF l3Q6clYzMb/UcsM6hYCX+JAGd4ktCK6TVbMyE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=b/KrQm54Hq8g9c6ylntqi8uAZ7geEAnFxKWxRn7UGwQ=; b=VR41revAVMQTp3ysAQBdjhtPt0Bf8Dq0ZH+dK/K53IcRJ1R2v6dYFguVArOowVGmCN 4v1K84RnRJNunVKlXl5mIVSY6RriDdKrxRE5QWun3PEzx/2i6bkwKYcDLxjq9maYlO+P AfD74X5w/kHpmi75iQKRnCJ+edwpbC+pORWN3ESonOQqCbl6qfkAKN8Hurqp6CtTOK7v WL3SraAt0FvEaZ1g5bMBz+SwcCKdWl8NKj56Jh/xW+OSf3Gy549yGAIRlbb3Sfbr4Ck3 GXveS3js5dNULzA5lCTaOMcu7oWlUwP2pa5N903hvDIzjubvJvQOpFPmeZbek5syTPKn /E/A== X-Gm-Message-State: AA+aEWaY2uDBUcFT4fQCZXEw8R19WYJpSRvs+IMxTbhPTldf0zTGhCma XSsufVmvZgIk4SVFzD9s8t5hqUbdnT0w+g== X-Received: by 2002:aca:f0f:: with SMTP id 15mr857719oip.47.1544757579822; Thu, 13 Dec 2018 19:19:39 -0800 (PST) Received: from cloudburst.twiddle.net ([187.217.227.243]) by smtp.gmail.com with ESMTPSA id g138sm2367537oib.26.2018.12.13.19.19.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 13 Dec 2018 19:19:39 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Thu, 13 Dec 2018 21:19:03 -0600 Message-Id: <20181214031923.29527-14-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20181214031923.29527-1-richard.henderson@linaro.org> References: <20181214031923.29527-1-richard.henderson@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::233 Subject: [Qemu-devel] [PULL 12/32] tcg/i386: Return false on failure from patch_reloc X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.inc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.17.2 diff --git a/tcg/i386/tcg-target.inc.c b/tcg/i386/tcg-target.inc.c index 5c88f1f36b..28192f4608 100644 --- a/tcg/i386/tcg-target.inc.c +++ b/tcg/i386/tcg-target.inc.c @@ -175,7 +175,7 @@ static bool patch_reloc(tcg_insn_unit *code_ptr, int type, case R_386_PC32: value -= (uintptr_t)code_ptr; if (value != (int32_t)value) { - tcg_abort(); + return false; } /* FALLTHRU */ case R_386_32: @@ -184,7 +184,7 @@ static bool patch_reloc(tcg_insn_unit *code_ptr, int type, case R_386_PC8: value -= (uintptr_t)code_ptr; if (value != (int8_t)value) { - tcg_abort(); + return false; } tcg_patch8(code_ptr, value); break;