From patchwork Tue Dec 18 06:39:04 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 154110 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp3363440ljp; Mon, 17 Dec 2018 23:05:28 -0800 (PST) X-Google-Smtp-Source: AFSGD/XV3CqGA+U8WMtlnSgtg95dsFnoE4rgwZxgHkS3gpgLnGjVBzPlIwxTDoDCJfL4DfDAU65d X-Received: by 2002:ac8:1909:: with SMTP id t9mr15683653qtj.327.1545116728427; Mon, 17 Dec 2018 23:05:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545116728; cv=none; d=google.com; s=arc-20160816; b=KhstiLJ2W3fjy5+UtvjYosrLqcXPxKiESJFyKNiMoqSNV4qi91DDHf5ftummxwM6+G DvAd/C57fcRMXZ1QbL+fVXFW3P2mccaAhtR/Xd3wJJVn0W3L093wf3McqwMlmqtjdGRc oBAJjY6pNuSzmnROeQKu41y54ZWE8dAffIkkBzYbwXAUnE1+sZ+E4OsWS+eDc5+f4Xd4 bP1qTgu9gchSnn3lp/Chr0v8jT22IlC1hbZnG14++/M40mYl6H8paM3LwcRBdszwW+W+ NZS0xGyaWW6BI9g4dWrHCly9CTWk6MqXY0pFdEhJA2IoilzjXhb/oqVHIVmco32M7dcO zeOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=YW7kNEnh0p74b8tmNGS0tI6jmUKC29mBQcE1tHBFKh8=; b=NFlcKClQYJB7s1AcDre3DlszRNbboso+uJ4Xumm6TOQ4Qc4gyZX8VBuwOk8XFS2e37 pJ6CfTFluTEo8QlcY90OaTa4rGtOvgIao3kuoadZdVMHmHbAnqBMKJXp4JUYK0OOImbZ TuBN0ClzWcvfP0nUcQRM/ERLfpTtdsTW2oVxaW6DkYs18+SxPGaDsBXj4Mx3tO9Q9e5U 2aCAbsUSGqNOO8nzb8tuMaJg9GCYn2nEf9BxUg5gg2GPwgme+XxqPKxKMbGrsVZ4dA4V tCmqk0Re4j335w6zixh+iD3+WT7+mkSK3HvaIhKwU7vr1/2ns8d+2HrBfRv/RvArMgFw u/SQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=TucXQbdm; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id c18si5696749qvb.181.2018.12.17.23.05.28 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 17 Dec 2018 23:05:28 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=TucXQbdm; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:52185 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZ9RX-0006QR-U5 for patch@linaro.org; Tue, 18 Dec 2018 02:05:27 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53164) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZ931-0001mk-Ev for qemu-devel@nongnu.org; Tue, 18 Dec 2018 01:40:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gZ92u-0002wE-DO for qemu-devel@nongnu.org; Tue, 18 Dec 2018 01:40:07 -0500 Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]:37998) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gZ92u-0002jg-2B for qemu-devel@nongnu.org; Tue, 18 Dec 2018 01:40:00 -0500 Received: by mail-pf1-x434.google.com with SMTP id q1so7651546pfi.5 for ; Mon, 17 Dec 2018 22:39:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=YW7kNEnh0p74b8tmNGS0tI6jmUKC29mBQcE1tHBFKh8=; b=TucXQbdma+auyfCjcQSjbQVeKjgdf/Up2OVuuSFsXTwkgmmoK+Y5q/2/LyDB1r+SCv AaSve5KC4HFiaidppN3guQYyupZcfDRUavRnJYCoXtrG86XyVwh/PE3m+AicU5IhtTEn mCsx7O1N+cgtu5S4RJWJ1s8Hrp8dcrZsHBWyA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=YW7kNEnh0p74b8tmNGS0tI6jmUKC29mBQcE1tHBFKh8=; b=ndQ1A5AjyXsIfvMpcxU2B1w8uIdhYLmymKakkcYLq/LQkRiu69GFPihp7MPWK3Xx87 2w+eo53hVe0vTPAULBMLb/IxCB9oi9pWJ3ayc96+ebNObDf0lPW4B2jSP0VVkYnMlI8B eOeuHbvKcEpcOSrAJDU6HdfU7eMheJyBT4eT6cFK57/osAWbdIyzxo3HXW+LEs7XEokh VmTkFS3nOXGOdYOEM5XthQqJlATGoUy2nPpLEHRRFqy+gMm2kXnywhE1IB+BjHQ0ylzx KfY38qJ0QHl5DwCGc1/WkGUaulXSvjbGgV4c0ZMsk8XXXSrYQuf5UVEM+cyhuD9mOXuf HY2Q== X-Gm-Message-State: AA+aEWYt7w/eD2Iptti2dEPi2Fblkcmx3GPWWksMtmsK+p9bTlV0+En7 0UcqHQwuDS9dWkAzfr3RSQVP0fbpTg8= X-Received: by 2002:a62:c28e:: with SMTP id w14mr15547502pfk.115.1545115190167; Mon, 17 Dec 2018 22:39:50 -0800 (PST) Received: from cloudburst.twiddle.net (97-126-115-157.tukw.qwest.net. [97.126.115.157]) by smtp.gmail.com with ESMTPSA id c7sm27072509pfh.18.2018.12.17.22.39.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 17 Dec 2018 22:39:49 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Mon, 17 Dec 2018 22:39:04 -0800 Message-Id: <20181218063911.2112-28-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20181218063911.2112-1-richard.henderson@linaro.org> References: <20181218063911.2112-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::434 Subject: [Qemu-devel] [PATCH 27/34] target/ppc: Use helper_mtvscr for reset and gdb X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-ppc@nongnu.org, mark.cave-ayland@ilande.co.uk, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Not setting flush_to_zero from gdb_set_avr_reg was a bug. Signed-off-by: Richard Henderson --- target/ppc/translate_init.inc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) -- 2.17.2 Acked-by: David Gibson diff --git a/target/ppc/translate_init.inc.c b/target/ppc/translate_init.inc.c index b83097141c..292b1df700 100644 --- a/target/ppc/translate_init.inc.c +++ b/target/ppc/translate_init.inc.c @@ -601,10 +601,9 @@ static void spr_write_excp_vector(DisasContext *ctx, int sprn, int gprn) static inline void vscr_init(CPUPPCState *env, uint32_t val) { - env->vscr = val; /* Altivec always uses round-to-nearest */ set_float_rounding_mode(float_round_nearest_even, &env->vec_status); - set_flush_to_zero(vscr_nj, &env->vec_status); + helper_mtvscr(env, val); } #ifdef CONFIG_USER_ONLY @@ -9556,7 +9555,7 @@ static int gdb_set_avr_reg(CPUPPCState *env, uint8_t *mem_buf, int n) } if (n == 32) { ppc_maybe_bswap_register(env, mem_buf, 4); - env->vscr = ldl_p(mem_buf); + helper_mtvscr(env, ldl_p(mem_buf)); return 4; } if (n == 33) {