From patchwork Tue Jan 8 22:31:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 155023 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp39683jaa; Tue, 8 Jan 2019 14:44:07 -0800 (PST) X-Google-Smtp-Source: ALg8bN4foqcvFVqaZySWq8yrhsOZM6DKMqA/hdOu6stuEXwUvcLT8X8Q0C+dOSQwwlXiPHBeabAZ X-Received: by 2002:a5d:6988:: with SMTP id g8mr2703778wru.33.1546987446913; Tue, 08 Jan 2019 14:44:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546987446; cv=none; d=google.com; s=arc-20160816; b=lRQQakYoz7l4GISuAG8a9XVJm6hMTH7ymzCtsjuKDzeu43KdKwWiQjgu7cKL84gBO4 hrvebbAmrH34Pw8nF6YTFPcb6F0t8kKSNxPT0g3hG7IBbnB6HFA6W9LxK55NNfrvTIeS KazAz3Ul54Uo3yq6GEWVqXeS2CZv/CPzA8Evet4j0LlroBQIJjrtKSU8SgfVabP/GfcW g1uu7NT24OYUoq901IBMAxu9iS1jgofhIR3xF41YGRVqgVBmBylS5TJ79RhsubJ8I8ZZ 4JMj+0w7699GCnQ6gk8F7QD1NqJpB1CREIoBhMsfltHOzBtJR7DvNX/s/b4GiyQ5lOEi aHGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=1DNhN8d8jnSLxAt0OunfVVewQ2O4L+Y8MHnesgNIMy4=; b=DfUAUvfFOz9BacSgtk5x2BSKBBhMVEy2IQo+05sStsjnFMr/2X3sW4FoJcbvKPxjKV C9Z4pIh6XZg+VYttEMaCd2V/BNZ1/au8bprfRwmAL6NaI5P/sBw7eJXKQp8QpNuM1rhg hjvCcmn7bP+nPDOaJSth0Qko80BOOjCwPtwpe+Meihqqu9Z15QpOVc2FRPxArMpQfixE MkriQ/oY4F7c2WUCHX4JMzjOtCp5RUHRArcyDn79VSXoGV9VCEwTzNV/5d7L94hiz2Z4 xYoBlxWksp3RuKwjSU8YP3o+dyKUi72qfDOPZOcWJ8OLAJjVp1uEBNAiW/C+EWI/T/rD CyAQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=L5LtFTFl; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id z193si7684552wmc.130.2019.01.08.14.44.06 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 08 Jan 2019 14:44:06 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=L5LtFTFl; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:42756 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gh06P-0002xX-M2 for patch@linaro.org; Tue, 08 Jan 2019 17:44:05 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52728) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggzv7-0000Cd-A6 for qemu-devel@nongnu.org; Tue, 08 Jan 2019 17:32:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ggzv5-0004mo-8i for qemu-devel@nongnu.org; Tue, 08 Jan 2019 17:32:25 -0500 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]:37214) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ggzv4-0004d4-Jz for qemu-devel@nongnu.org; Tue, 08 Jan 2019 17:32:22 -0500 Received: by mail-pf1-x443.google.com with SMTP id y126so2620202pfb.4 for ; Tue, 08 Jan 2019 14:32:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=1DNhN8d8jnSLxAt0OunfVVewQ2O4L+Y8MHnesgNIMy4=; b=L5LtFTFlZsGzK5WpgpmYBFmenhtmlL86coAiOqKo/QqMhFZF0PnK7UIHe8Zyd55flN ksTnzYckT0VrF5b+ylxHmjwuFJODDTwJMOu4HIfsGO5TPyYV808sqjo6MRCDt6d3pCXl KU/21Vx+8nUafQt944yhukfPpe4f6YjWp0syk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=1DNhN8d8jnSLxAt0OunfVVewQ2O4L+Y8MHnesgNIMy4=; b=S+qHL+LIqo+CcP0GBtvrYRzekbPztfsZTECFlYdScmRqYnVs0KpShVGlHBh9jMsYAC Pz+WIA0+ziuSSBwV429DDquzNdbn+ak9rC/QwYgzSCrWXwOf3XJv5TM9l8QZLbsBav+0 vQsXajzZLGKV8Wl+mEVTRgVQr1k03ghr+KwC8PyChXiEHT8DP07By3diVo5bO49J/3N5 0ZhfzhHmb4gVlUrE8r1PMOzy3e7h7CMAruHbHHvDr2sV+jR9tyW4ZV2yE0wlKHBRKE9E 8FYO8isk7bu4lMxkIPiuACn5UwlLEtzH/LBUKNi+epO1Wz5CGYCMKL96hdzT2TRYqaVn qYZQ== X-Gm-Message-State: AJcUukfOv/mZOcItNBhdwxS3svkAxCWOufMC9jad1Qsq/1V6bnoQUIrZ 0Uj/VcvqoYiCojWQBkXm9JMWGF3E/9E= X-Received: by 2002:a63:2a4a:: with SMTP id q71mr3151394pgq.374.1546986733032; Tue, 08 Jan 2019 14:32:13 -0800 (PST) Received: from cloudburst.lan (2001-44b8-2176-c800-8cc6-2630-7d99-5ef1.static.ipv6.internode.on.net. [2001:44b8:2176:c800:8cc6:2630:7d99:5ef1]) by smtp.gmail.com with ESMTPSA id w128sm100686177pfw.79.2019.01.08.14.32.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 08 Jan 2019 14:32:12 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Wed, 9 Jan 2019 08:31:12 +1000 Message-Id: <20190108223129.5570-15-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190108223129.5570-1-richard.henderson@linaro.org> References: <20190108223129.5570-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::443 Subject: [Qemu-devel] [PATCH v3 14/31] target/arm: Decode Load/store register (pac) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Not that there are any stores involved, but why argue with ARM's naming convention. Signed-off-by: Richard Henderson --- v3: Use do_gpr_ld; fix sextend typo; iss_valid only for !wback. --- target/arm/translate-a64.c | 60 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 60 insertions(+) -- 2.17.2 Reviewed-by: Peter Maydell diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index fa50003f0b..a4dfdf5836 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -3146,6 +3146,63 @@ static void disas_ldst_atomic(DisasContext *s, uint32_t insn, s->be_data | size | MO_ALIGN); } +/* PAC memory operations + * + * 31 30 27 26 24 22 21 12 11 10 5 0 + * +------+-------+---+-----+-----+---+--------+---+---+----+-----+ + * | size | 1 1 1 | V | 0 0 | M S | 1 | imm9 | W | 1 | Rn | Rt | + * +------+-------+---+-----+-----+------------+---+---+----+-----+ + * + * Rt: the result register + * Rn: base address or SP + * V: vector flag (always 0 as of v8.3) + * M: clear for key DA, set for key DB + * W: pre-indexing flag + * S: sign for imm9. + */ +static void disas_ldst_pac(DisasContext *s, uint32_t insn, + int size, int rt, bool is_vector) +{ + int rn = extract32(insn, 5, 5); + bool is_wback = extract32(insn, 11, 1); + bool use_key_a = !extract32(insn, 23, 1); + int offset; + TCGv_i64 tcg_addr, tcg_rt; + + if (size != 3 || is_vector || !dc_isar_feature(aa64_pauth, s)) { + unallocated_encoding(s); + return; + } + + if (rn == 31) { + gen_check_sp_alignment(s); + } + tcg_addr = read_cpu_reg_sp(s, rn, 1); + + if (s->pauth_active) { + if (use_key_a) { + gen_helper_autda(tcg_addr, cpu_env, tcg_addr, cpu_X[31]); + } else { + gen_helper_autdb(tcg_addr, cpu_env, tcg_addr, cpu_X[31]); + } + } + + /* Form the 10-bit signed, scaled offset. */ + offset = (extract32(insn, 22, 1) << 9) | extract32(insn, 12, 9); + offset = sextract32(offset << size, 0, 10 + size); + tcg_gen_addi_i64(tcg_addr, tcg_addr, offset); + + tcg_rt = cpu_reg(s, rt); + + do_gpr_ld(s, tcg_rt, tcg_addr, size, /* is_signed */ false, + /* extend */ false, /* iss_valid */ !is_wback, + /* iss_srt */ rt, /* iss_sf */ true, /* iss_ar */ false); + + if (is_wback) { + tcg_gen_mov_i64(cpu_reg_sp(s, rn), tcg_addr); + } +} + /* Load/store register (all forms) */ static void disas_ldst_reg(DisasContext *s, uint32_t insn) { @@ -3171,6 +3228,9 @@ static void disas_ldst_reg(DisasContext *s, uint32_t insn) case 2: disas_ldst_reg_roffset(s, insn, opc, size, rt, is_vector); return; + default: + disas_ldst_pac(s, insn, size, rt, is_vector); + return; } break; case 1: