From patchwork Thu Jan 17 13:26:57 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 155828 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp1981393jaa; Thu, 17 Jan 2019 05:38:18 -0800 (PST) X-Google-Smtp-Source: ALg8bN7BunizvqgKf0m0754GgLhRcNGyAZRHAfDzVv/HyCKmuaNMW0YwhlMejAFhN1jRxI7LK4pL X-Received: by 2002:adf:c846:: with SMTP id e6mr11581718wrh.243.1547732298681; Thu, 17 Jan 2019 05:38:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547732298; cv=none; d=google.com; s=arc-20160816; b=zBHtdPNPleA4t56cDjqXMS6KqHI3qsxCzt7T5gfDC6RiIZJjuJLBaE404F6YKCQBcz cwX5x4gRV/xO2ihf4vx3zwMId+NkEJkVbMOYPmY0A/8paYHAcIxwqM317avwCv1HrdyM uTnhFGBLqKj4O1VplCuJMeH9Zqj1aZ2EcFTFDOjazM9Y9nK9pgN5CC4vwBDvt4AT6Xtu pm752DgzUcGfjxw02ePN9Nu/jm+id4wxa2LPTgmYeKOaK5PaIcDDjNUpOiUm08eJlHXR SmzCDBt8c1O8X13ORoHa113zaqT29hGvbuQF6u+j6fbxUbkr2UUJUdTYdCaruE3LG3LO lUdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=sKUbCr+5hebTCE7vCo8l+AO5U+Gmyjus1WUo35lXpns=; b=fBS6/Hx9bv+1SVrkr7cFVTdxRoei+M8BYKWPPJZ4UkUFOVl3Gh8MXuOlcv53b1J3sY vXrOYi23bmxjGWobB/TXYcSff57iAxCr3kucBT7F3zHA1E7o2WRiA2B8pH+PcudGER0J 26yAfBreG/ZFu7oSJ8BphKba8L20Sr/XEBdmP6hRQUJoQq1Vs+j47SrMWSrvXmLqkXjr lOLikeA/aFZlxDNMtZHOILLsako+8GQSXOX3fUTzOEITR45vB3M+3EtXy996cAdaUzwq v0jOBARK9CzMV8XWKP63m1LJ4c7y4jEQI1vu9juSkQAPFzH7LN79F085nzK6oBEErixy WrxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=hdDVdpuW; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 60si56422544wrb.246.2019.01.17.05.38.18 for (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 17 Jan 2019 05:38:18 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=hdDVdpuW; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:44581 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gk7s9-0004qz-Kb for patch@linaro.org; Thu, 17 Jan 2019 08:38:17 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58293) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gk7mK-0000Ae-NB for qemu-devel@nongnu.org; Thu, 17 Jan 2019 08:32:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gk7hP-0002Yi-4R for qemu-devel@nongnu.org; Thu, 17 Jan 2019 08:27:16 -0500 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]:35851) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gk7hM-0002Rv-RK for qemu-devel@nongnu.org; Thu, 17 Jan 2019 08:27:10 -0500 Received: by mail-wm1-x336.google.com with SMTP id p6so1062201wmc.1 for ; Thu, 17 Jan 2019 05:27:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=sKUbCr+5hebTCE7vCo8l+AO5U+Gmyjus1WUo35lXpns=; b=hdDVdpuWQVbn2Q1NYJO362CXh6N8VA5bmtmHDEg5ez/BkY34weVaHvcSKIGmabN6o2 Sx6B7idNTbNzgVttITAG3QbysFHV4yZsdnhB9YiudP1mZ2C0vxxbhVVBR5oZFqJ1SdtT xkodT09N1WBB4tnueKXaQsoa+bAfCjJijaFvM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sKUbCr+5hebTCE7vCo8l+AO5U+Gmyjus1WUo35lXpns=; b=SYo3wXEIvAgqFyRVNjM/hqesRzM1TCBtambm7SFys8i1/PgYq5Krg5voOzrKszzVI0 bq09ntroZVybDlYFrrQRatn/G7RSdPj/P5A16cWTnVhu0xD2pExpFkJRnfQ1A8g+QpNF 6VAgZ4596x7kEdF4kiYjDeX1PRCYG49GPUmM6i/ijlFGtSz1PKgULSvplETsipZZybHC 6ZGl7eBfWS/VawNknShlCEnsASI7wuiifLnb617rvyce4Svygfn42Sko9biRQHjUAutQ kTz2RMStSbtA5JJzwI/w57IeYDmDrBMFMDpmMubR3gk9tTa03W/Y4hfryRXN1FfB9rSe xdtg== X-Gm-Message-State: AJcUukeO0Kbpa6i0TcDzOCtw+BlXb1XFzkx+48FLer9BGqd7eo0yrMby uc51dfdQd8ORp7Zasuj4kqG52Q== X-Received: by 2002:a1c:27c6:: with SMTP id n189mr11623793wmn.108.1547731626736; Thu, 17 Jan 2019 05:27:06 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id x20sm53856351wme.6.2019.01.17.05.27.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 17 Jan 2019 05:27:04 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id 0A45F3E06EA; Thu, 17 Jan 2019 13:27:04 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org Date: Thu, 17 Jan 2019 13:26:57 +0000 Message-Id: <20190117132703.17790-2-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190117132703.17790-1-alex.bennee@linaro.org> References: <20190117132703.17790-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::336 Subject: [Qemu-devel] [PULL 1/7] fp-bench: fix update_random_ops X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Emilio G. Cota" , =?utf-8?q?Alex_Benn=C3=A9e?= , qemu-devel@nongnu.org, Aurelien Jarno Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: "Emilio G. Cota" The second test in the branches is wrong; fix while converting to a switch statement, which is easier to get right. Signed-off-by: Emilio G. Cota Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé -- 2.17.1 diff --git a/tests/fp/fp-bench.c b/tests/fp/fp-bench.c index f5bc5edebf..546bac9c9c 100644 --- a/tests/fp/fp-bench.c +++ b/tests/fp/fp-bench.c @@ -143,15 +143,20 @@ static void update_random_ops(int n_ops, enum precision prec) for (i = 0; i < n_ops; i++) { uint64_t r = random_ops[i]; - if (prec == PREC_SINGLE || PREC_FLOAT32) { + switch (prec) { + case PREC_SINGLE: + case PREC_FLOAT32: do { r = xorshift64star(r); } while (!float32_is_normal(r)); - } else if (prec == PREC_DOUBLE || PREC_FLOAT64) { + break; + case PREC_DOUBLE: + case PREC_FLOAT64: do { r = xorshift64star(r); } while (!float64_is_normal(r)); - } else { + break; + default: g_assert_not_reached(); } random_ops[i] = r;