From patchwork Tue Jan 22 21:50:06 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 156323 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp39372jaa; Tue, 22 Jan 2019 13:50:48 -0800 (PST) X-Google-Smtp-Source: ALg8bN5fI+N6zqW/vySeTAiMqL9SyOLa64VnjQmlb1TjAesg0Ou877OvUrCSQ9Lua8/tR9PnvNwb X-Received: by 2002:a1c:a6c2:: with SMTP id p185mr149514wme.133.1548193848196; Tue, 22 Jan 2019 13:50:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548193848; cv=none; d=google.com; s=arc-20160816; b=lkuFdsrLR5Hb0DDyutNJ7PIdwGSYEj14EZwJy6MpptFEdrTkcVbaDlUMcbMhLpgaNp SoZskQ4VBQIOTOfHdRmxm4Gd4No7+YC7qFrLUvco3W1nLR+0OrjRbO/jYDedPgE7dRvE fxuaHL2aJgF3svxedhDgIcVLX9gqU/Pcb9ukl16qp9lfPFjDtzos90m6kl4XJoCnynMN SyiGuAEDvZw3RcewvDnvJp89si5DyHyvu5EMpxMoPM2VLs/DfVeTgjp9F5E62ghsiwZv 0WbPFtSyP4n6PP5LCWhsmvSeohWpNQqR8NtHUu/S/qGzM+UWM7OpDEh4qurpQAqECr1G EBMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=1nYURC9J3WUUZatMQMjMushGVVnRe2BtZ2VT+vU0n5Y=; b=YdnYwa9iCxckiSqp+8xBjrkBBoE0PWSEySn2R/wsMuVvFi52aXzK/qQYgRn/1rJC0J RoDA536Ik5qM2SDp06hhEx/2sCkmkATtJt2MqWUmr7WgRv7ecYf1CIhViegQ4OBqpnVk JZ/pUBaWHQRPlpth8LReHCfHUe+7d3dUoLCVRp0ZwCh6uub4GxTvnwkJqxJcLR/6ue29 WVZvytIu+h31QOmyd7HAzv6T8sjiQVIku3OfiUPBEwkDL3EcmNGvd5yPqIBwEPj8COm7 J55iDo3SglyhqwxrEnaC/bTa5WycRH+OYobCTCsqQr98dkHZGxkZoxeteNA0Nw/2C/15 5BmA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=KvLilcT7; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id w72si35781026wme.155.2019.01.22.13.50.47 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 22 Jan 2019 13:50:48 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=KvLilcT7; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:50769 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm3wV-0007KM-4l for patch@linaro.org; Tue, 22 Jan 2019 16:50:47 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60832) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm3wA-0007Js-0r for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gm3w4-0007nr-Sb for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:21 -0500 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]:38146) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gm3w2-0007jE-RR for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:19 -0500 Received: by mail-wr1-x441.google.com with SMTP id v13so83358wrw.5 for ; Tue, 22 Jan 2019 13:50:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1nYURC9J3WUUZatMQMjMushGVVnRe2BtZ2VT+vU0n5Y=; b=KvLilcT7T/5EypOW6sb2RhODzswUWt58bUcNYBmvVMxpZPVd/DLHLvbOBgYWoWYQds q0g7HC/Cl3RT6kHtz10sP1PjnSRjDprYMTgcnLeLEbhFy6DTDVfeP5baFMxxRZ+g4laj nzR6Yg07qThPXuomsa6zn68zBr0aD+UVeFgIA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1nYURC9J3WUUZatMQMjMushGVVnRe2BtZ2VT+vU0n5Y=; b=lE7ksnZbAL53h7JpMFmTzSnFv5xWZHPVpL4mY3SL2i38xyTahny9PGuKxEHdly3xTO atCrWZpJljlWnBQHoTF8E66c4J0IGjTKPlPyFhEkV/z897O0UGuGUpe3OBNGdS37DCxW h9zbk1TfT6YXlAzrpDCZ+V67GJmPQEnFv9BHImUtNjq+vs9DM7OXX0+tLHrqzkOQeUgH I5FMgx7dF4r1q7IKejqGor25jAsfikgwKfFZo8CA0KufYrN3CdygapH8nGUaT0tzCNON he18nmqYMkgk6x6Ew5LsGNFOKGKWE4fRTIyXt2zcsnzNHcxj92in8YXt1ZIBtSBYBOzy OyWA== X-Gm-Message-State: AJcUukevAWB5KwTCgPFej8pkwCZ0DxhLkP1LHBUXFHcQDiCKOrc6guW6 mWBh96RygyWRMwvZW4pHQj3vZQ== X-Received: by 2002:a5d:4a0c:: with SMTP id m12mr34170832wrq.38.1548193817615; Tue, 22 Jan 2019 13:50:17 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id p4sm81010790wrs.74.2019.01.22.13.50.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 Jan 2019 13:50:17 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id 3B6243E0807; Tue, 22 Jan 2019 21:50:16 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Tue, 22 Jan 2019 21:50:06 +0000 Message-Id: <20190122215016.18697-2-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190122215016.18697-1-alex.bennee@linaro.org> References: <20190122215016.18697-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::441 Subject: [Qemu-devel] [PATCH v3 01/11] fp-bench: fix update_random_ops X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "Emilio G. Cota" , =?utf-8?q?Alex_Benn=C3=A9e?= , Aurelien Jarno Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: "Emilio G. Cota" The second test in the branches is wrong; fix while converting to a switch statement, which is easier to get right. Signed-off-by: Emilio G. Cota Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée --- tests/fp/fp-bench.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) -- 2.17.1 diff --git a/tests/fp/fp-bench.c b/tests/fp/fp-bench.c index f5bc5edebf..546bac9c9c 100644 --- a/tests/fp/fp-bench.c +++ b/tests/fp/fp-bench.c @@ -143,15 +143,20 @@ static void update_random_ops(int n_ops, enum precision prec) for (i = 0; i < n_ops; i++) { uint64_t r = random_ops[i]; - if (prec == PREC_SINGLE || PREC_FLOAT32) { + switch (prec) { + case PREC_SINGLE: + case PREC_FLOAT32: do { r = xorshift64star(r); } while (!float32_is_normal(r)); - } else if (prec == PREC_DOUBLE || PREC_FLOAT64) { + break; + case PREC_DOUBLE: + case PREC_FLOAT64: do { r = xorshift64star(r); } while (!float64_is_normal(r)); - } else { + break; + default: g_assert_not_reached(); } random_ops[i] = r;