From patchwork Tue Jan 22 21:50:07 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 156329 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp44125jaa; Tue, 22 Jan 2019 13:57:49 -0800 (PST) X-Google-Smtp-Source: ALg8bN7/EedirW+X/OTR4K+ZoZJ1pfR360YMBCcP1ITvqgeq0Od5Fbv7aaL+AVysGrthMUu6P3zo X-Received: by 2002:adf:c042:: with SMTP id c2mr35824136wrf.158.1548194269596; Tue, 22 Jan 2019 13:57:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548194269; cv=none; d=google.com; s=arc-20160816; b=H8hGqB3UATdZVUcy19lcchcVafDUXLYz31aGrDIoIVJqj6logMyQsuMiuFaqhzXd9c 91j7H4mYM2WdlWPkjPGqi1GDRpFDvAL/tz/xt70thLss3BhGF9zqpZNdXS4+x1Yphb01 wSGK5FQ8L7t8XdJM5R91YBBx1EckHcEhyKNmz9cI8hCZeM0kFpOUq5Ad1EQLD7sQkKXq VsOwZBfLMQwILG40tXz5zlk6JkHAUbolIhvkFySeC+pRT6VOxN/HACd/QPgY9oGqqIUn baHkqqZzd7oZX65xci2GOhwpyu0Qb2Wlkh9qXYw3XTqRicwlKOfw7L2KHKRJD2VxeQgz k8bQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=BKiceF0eCEcLLYJ2HmNMq8GOYGcVmd+bgBmQXvFufFI=; b=YTYzjNXldW/dvDdAWz6HRZDT3eW8X8il1ceLGq71GBNuGgPSXuTp/ljfc2ho1+/XBb 5Y76eJV1r8uIPCDKqY/NbWlldrqpf/Gw/vK0fDno/G38BLYjwCL+VBRaVF1ExEztaGvQ +3ZdQkLwfFGbfQxEficnXExv/EFP2of0sy2TP35k8cn4DbCiFpEYq8POZqGv32M9p9wr 15HuArxjz0hJzC9P8zNDdYAKnwsQYH4DVmUUZJD1c5CCyMEMCKq5Ylrc7S1xv3lOYHP7 S4NTUUM+XvzZkjbhyo+m05vFXGpVq6sswseqbwDuAs35fhwe/asBQIdEaqISWamnQu8+ nlzw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=eaNrnb9l; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 21si27625887wmw.118.2019.01.22.13.57.49 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 22 Jan 2019 13:57:49 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=eaNrnb9l; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:50873 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm43I-0005oZ-GU for patch@linaro.org; Tue, 22 Jan 2019 16:57:48 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60887) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm3wP-0007RT-3E for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gm3wM-0008CJ-Iv for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:40 -0500 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:44930) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gm3wK-0007l2-JJ for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:37 -0500 Received: by mail-wr1-x444.google.com with SMTP id z5so50588wrt.11 for ; Tue, 22 Jan 2019 13:50:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BKiceF0eCEcLLYJ2HmNMq8GOYGcVmd+bgBmQXvFufFI=; b=eaNrnb9lJUzjFslVmypTpso1EiPUsPfYAhRJ04YXOhFS4b9k7aIFIxy9jpTkRjvlZj S9myyW4AG7mRTbeRsA8peKMhcyJQXVzTQbVyNu+gUMAhO0DGhPh08F6Ql+dsbipD7JpA 3ONq5X/qe0EgErmda5B1XR6/HxfsWdbayJ+7Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BKiceF0eCEcLLYJ2HmNMq8GOYGcVmd+bgBmQXvFufFI=; b=Vj4/TCfoOIPOz7rmbWxaLvisqsoJ16jfszOp0JsSuPMcM1cNbNumbqyPF621KECeq2 fmzZYsDuAszy6SCP8QjN94z1f1lDkdcIIHD+n7RKXe/N2SBolbfffrV9oAm4YwwEFV97 cfBLE65N9vA86s0R29Q6JZ8Uqns50Y8OaevLWAuRZQg23R0Gag7QTHpMjGrKasdffPay maauAUbQmu1fscXbsgzZUNZFLLaVq1SfSM5lGR0MI2IimBsAu/7+Le+dw53OFxMSC5NN m61RTkYWWPOqC2QIlU/HjsNYDTE1Pj/dNqQt0g7uC+WS7Pb6KgWd8BN/iOMRSsb5EePi AJ0g== X-Gm-Message-State: AJcUukfEG9OSbsR8rs602pjHzr02xKf5aIbrJwo5ivrJ5ly4yvBD1eqa 7rmZTgbhgQpCzqSRASzf9ZKKjiST2Qo= X-Received: by 2002:adf:fc09:: with SMTP id i9mr32149284wrr.299.1548193818596; Tue, 22 Jan 2019 13:50:18 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id c13sm108608405wrb.38.2019.01.22.13.50.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 Jan 2019 13:50:17 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id 4DC923E08E3; Tue, 22 Jan 2019 21:50:16 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Tue, 22 Jan 2019 21:50:07 +0000 Message-Id: <20190122215016.18697-3-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190122215016.18697-1-alex.bennee@linaro.org> References: <20190122215016.18697-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::444 Subject: [Qemu-devel] [PATCH v3 02/11] fp-bench: remove wrong exponent raise in fill_random X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "Emilio G. Cota" , =?utf-8?q?Alex_Benn=C3=A9e?= , Aurelien Jarno Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: "Emilio G. Cota" At this point random_ops[] only contains normals, so there's no need to do anything to them. In fact, raising the exponent here can make the output !normal, which is precisely what the comment says we want to avoid. Signed-off-by: Emilio G. Cota Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée --- tests/fp/fp-bench.c | 4 ---- 1 file changed, 4 deletions(-) -- 2.17.1 diff --git a/tests/fp/fp-bench.c b/tests/fp/fp-bench.c index 546bac9c9c..4ba5e1d2d4 100644 --- a/tests/fp/fp-bench.c +++ b/tests/fp/fp-bench.c @@ -176,8 +176,6 @@ static void fill_random(union fp *ops, int n_ops, enum precision prec, if (no_neg && float32_is_neg(ops[i].f32)) { ops[i].f32 = float32_chs(ops[i].f32); } - /* raise the exponent to limit the frequency of denormal results */ - ops[i].f32 |= 0x40000000; break; case PREC_DOUBLE: case PREC_FLOAT64: @@ -185,8 +183,6 @@ static void fill_random(union fp *ops, int n_ops, enum precision prec, if (no_neg && float64_is_neg(ops[i].f64)) { ops[i].f64 = float64_chs(ops[i].f64); } - /* raise the exponent to limit the frequency of denormal results */ - ops[i].f64 |= LIT64(0x4000000000000000); break; default: g_assert_not_reached();