From patchwork Fri Feb 1 16:06:37 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 157263 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp627932jaa; Fri, 1 Feb 2019 08:15:08 -0800 (PST) X-Google-Smtp-Source: AHgI3Iag/fWVQ8triZ45ntJZfjPwaAcJeAQKyi7jNKQ01QKwuFZm+ITFVnIBWBwt4Psgbe2O8DRX X-Received: by 2002:a25:41c4:: with SMTP id o187mr24766092yba.340.1549037708137; Fri, 01 Feb 2019 08:15:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549037708; cv=none; d=google.com; s=arc-20160816; b=xni2lKmREgFdBbnc3dY79PR+59kY+UnzDxPRMQz60Rbc3EoRdgSHugcqBjDqQaIlbd qdYU+F/iSR/AJgm/kVKQmG56Vnmil4DhvUPRM2aF4rjXgEY7sZVHjNgahwSetoQEnEaQ Hpal470k0oIW/1zroWMe45n/JcxjyrdpDin6bITN06RtlyYLDewCY1WBGD8lIrBVNssJ SCdoXbB3RJioX+UwrMFzPHs2i4OQYIBccTjFzOqL2x+8O0Sl/9nVBWTYOnu/D9zZV1jI t5/LG8q3U2xtOroTzLClUmRQLZVEisn7NuNEVzOSCn85YJqiSFevET06I9zQy5bKSfbF 6pbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=fjjl7HjBb8W2Qs4ekHnqu/8lEMyaCYY9TIp66Rhslmk=; b=OpM8G8T8pPM/cx6VY1MInaeveuGQOrZdYWTynhnl5pk3tZ+T/EFK3jrCmWVLZW5LuD P9EsTcqJmJHqcDW+k1yux87ja9LmcfKyBOnWRHg1T29vsXg382yHeR6U7FsQRZxTUv8h wWa/EnTvOOVNmAMYeqHb8nUw/DsC1LKNeuuNUdkXybIS8SjHlXA8nEb+NlokUsPhZrWS w5A3k+vIe/HiUeg3IG/2HzynjQTnzwxMK6/WKWe/PkZj1zpGmAh5POS5zpOOvI2hNVqj 8UHYEvVTaNM7/JIxe679fwhpPtttcmhbc8ZNrPrLSiUFktD2ie1Rt0DSNK32IovOECSz ZsXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=MIBIjPf2; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d143si240300ywh.409.2019.02.01.08.15.08 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 01 Feb 2019 08:15:08 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=MIBIjPf2; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:57335 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gpbT9-0006Sh-IT for patch@linaro.org; Fri, 01 Feb 2019 11:15:07 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58912) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gpbMB-0008EF-9d for qemu-devel@nongnu.org; Fri, 01 Feb 2019 11:07:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gpbM9-0003hS-Rr for qemu-devel@nongnu.org; Fri, 01 Feb 2019 11:07:55 -0500 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]:39793) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gpbM9-0003Zj-Gl for qemu-devel@nongnu.org; Fri, 01 Feb 2019 11:07:53 -0500 Received: by mail-wr1-x429.google.com with SMTP id t27so7662186wra.6 for ; Fri, 01 Feb 2019 08:07:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=fjjl7HjBb8W2Qs4ekHnqu/8lEMyaCYY9TIp66Rhslmk=; b=MIBIjPf2JMHj0ptCSp8q1Ad3HAwq06rdzFHuObotBm1GGibxTKzB23pmj63uM55nM/ 1REep4dU6JyLv9dtJIcwNO1hOyoTaAjzPyVSANbsHgY3+b9drsrs0yXFcX1+lubtw2MX c4p3N8xc/Nw7qktlYOL5tvLSVcN/18tCsNymE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fjjl7HjBb8W2Qs4ekHnqu/8lEMyaCYY9TIp66Rhslmk=; b=q7vkxRhT74fBryZdzhY/kNQN906AHFx/e/iyAdg1xvLoQYNt0Pe/tooqRsCMi3gU+e 8ZX6Ljm0wsyrjWeuiwpDUO/Fs//V8sTxJSWYQQ453ZP3IypkF8f56KysSEAzUUYqktex Gaw77OA/XWnFjTr9+49r6qzkerEIJ4szKnekuhqdJk7Fcc+y6MvNyKpP0n34NotypAjI hYvQZz+FhCULdvBw72e2HiMMPkyDalwBaQpznzxmmaFO8SHlyLVv0M/uFc7jWmC2edNX Jair4RIZNoou1uBXw3O82OfOZ66shlniWpKqV9jEJZep8tEGhmBe8VApYe8dLyRo7pT+ fkCA== X-Gm-Message-State: AHQUAuZkCxVZ2YX6Mo7Sb1Dwcp2tIZxNiEqZfcJoMQRb+3GTlWtl9BQk 9D1yW2wf3Aus5Ya7EhGsZDAzieqZVnc4nA== X-Received: by 2002:adf:ec47:: with SMTP id w7mr2106824wrn.8.1549037255489; Fri, 01 Feb 2019 08:07:35 -0800 (PST) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id n6sm2847250wmk.9.2019.02.01.08.07.34 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 01 Feb 2019 08:07:34 -0800 (PST) From: Peter Maydell To: qemu-devel@nongnu.org Date: Fri, 1 Feb 2019 16:06:37 +0000 Message-Id: <20190201160653.13829-32-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190201160653.13829-1-peter.maydell@linaro.org> References: <20190201160653.13829-1-peter.maydell@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::429 Subject: [Qemu-devel] [PULL 31/47] target/arm/translate-a64: Don't underdecode SDOT and UDOT X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" In the AdvSIMD scalar x indexed element and vector x indexed element encoding group, the SDOT and UDOT instructions are vector only, and their opcode is unallocated in the scalar group. Correctly UNDEF this unallocated encoding. Reported-by: Laurent Desnogues Signed-off-by: Peter Maydell Reviewed-by: Laurent Desnogues Message-id: 20190125182626.9221-8-peter.maydell@linaro.org --- target/arm/translate-a64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.1 diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 6c4b20daf2c..07fa0523935 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -12641,7 +12641,7 @@ static void disas_simd_indexed(DisasContext *s, uint32_t insn) break; case 0x0e: /* SDOT */ case 0x1e: /* UDOT */ - if (size != MO_32 || !dc_isar_feature(aa64_dp, s)) { + if (is_scalar || size != MO_32 || !dc_isar_feature(aa64_dp, s)) { unallocated_encoding(s); return; }