From patchwork Fri Feb 1 16:06:39 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 157291 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp656237jaa; Fri, 1 Feb 2019 08:40:05 -0800 (PST) X-Google-Smtp-Source: ALg8bN5aaPxcyByA8wwXlk/krGclv6E5Y/cCSPMSzWdrGauim2ZS0BqX1zzsRQgZYuZaCS7TW7zR X-Received: by 2002:a25:c092:: with SMTP id c140mr37173606ybf.495.1549039205836; Fri, 01 Feb 2019 08:40:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549039205; cv=none; d=google.com; s=arc-20160816; b=fX1+z/QAdM3tPmZPgyrmpKrd+M+QvvYJcUQLwq0j7Eqx6u55Hf7cwtTXbZjSWrV4MV sf1tELFnXxwYe4vTniNIATIhnofT0EDfZHjJcNVZhbDqu8EtmIjb0YsBBEz3kVwGFbsT 65jlihNZb3LfkD27hudt0bbiQFsPfPtVYL0KV7wWTuQ6nNzI1QSjrHLtRPpgNr9RK2tn fac/N16xT/HYbOW7Z/eC/gZNOPlUYp1/s8JPiHvUSj9gLKAcd2a1bt/io5hg7DTckz4z rElDzgUHLK3Sh6kEcBXFd5Ocwx30wckMfLrGsbCMlr2Ky5Yta24C8mJ4s9e607HWGGhg fLFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=QbgeaFQVLHd6cVGRSfLE2ibgzbY/AGKfGBe7Fkl1csQ=; b=ewHKvONt6+ae/WbE0v1VdrU4BU9jfDpegUri17nGW3p3bccDe1HqercJNXplVsOsMf KMlyorj0elqPGuAYadDVAh+XeVcMzBi0nMbQuQDLEMVcOjohsEj8aJUtVY5y8jvthjMo NYu0jMq9pe7Gps5Zrq2JZrLi1AvbkwaG2C4vRtpqCk5NB9+xP6poYAyssPRaqUKH8C/Y 2wnGIQa3PCwNp55qozZmiK0lt9hVP+tRLtHTv97a9QTOZqLmHcx/0dFjRjgwmLZeDVbL Fl2EQGIyeeXLxExlUwdPqNS83KAqWZRkF+kCIsmr177dEsFRUjNTPCzcXpOGYLxIgvqS Y/KQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=ba344z3m; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 84si4715122ywo.466.2019.02.01.08.40.05 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 01 Feb 2019 08:40:05 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=ba344z3m; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:57687 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gpbrJ-0000vW-AW for patch@linaro.org; Fri, 01 Feb 2019 11:40:05 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59151) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gpbMH-0008J0-2u for qemu-devel@nongnu.org; Fri, 01 Feb 2019 11:08:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gpbMA-0003iH-BO for qemu-devel@nongnu.org; Fri, 01 Feb 2019 11:08:01 -0500 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]:40648) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gpbM9-0003aI-Sv for qemu-devel@nongnu.org; Fri, 01 Feb 2019 11:07:54 -0500 Received: by mail-wr1-x433.google.com with SMTP id p4so7653688wrt.7 for ; Fri, 01 Feb 2019 08:07:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=QbgeaFQVLHd6cVGRSfLE2ibgzbY/AGKfGBe7Fkl1csQ=; b=ba344z3mKlLr9MWCezUYTaT/nPwbL5L3hEStbsGg7gtQ92fOQO7YSxkCaqUnkDNoWd ctrzZDs9lJ2QkjaMGLd/PKbiGlCl8vcv0UK849D7iy8nNt3auVqqZbqe9V7zT8kNA1sL +ksxqELjKR1kS2lUnSd2sR36a6T92EELo3DeE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QbgeaFQVLHd6cVGRSfLE2ibgzbY/AGKfGBe7Fkl1csQ=; b=K+m9MbDZyEK72+ErazXlUNMjmtL1L2IXytgMChRwe5O+KzpuFV6VfdYQcZa0dtsBRB OlTuKJmGeE4g+lwf7OajmcBQQiSQtnb3VoQpjUKO4/XHSR+bgF5lE+Y10GLvsio2A/d1 ZykIOQCDZpGcclcjH8IZndYkKZTTGh7+9rd5MC01SIED+UnsECwyHe+TnDHSjZQGdUBZ Tll3i1Xkp/dUDkCrGPUfgprfmZ9dmQgzi5zbbMBYGkcixvFzR+SGKX3b0VE6cR2EKFA7 L7pjQMWmgeG1JDqN6RdBA5Hnu/PmqmtndsHqli03RjQo9sz0NkfOZnnEttJPALgKMwf9 9e8g== X-Gm-Message-State: AJcUuke8RT5MNNg4Zu9PR1hRBleD/o86KNXtvAkeomWOYUKRBd0MmkfV D06TUA81LeaXCrmS5TC05bdc+pTfGM8Lpg== X-Received: by 2002:adf:a50c:: with SMTP id i12mr37431327wrb.220.1549037257774; Fri, 01 Feb 2019 08:07:37 -0800 (PST) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id n6sm2847250wmk.9.2019.02.01.08.07.36 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 01 Feb 2019 08:07:37 -0800 (PST) From: Peter Maydell To: qemu-devel@nongnu.org Date: Fri, 1 Feb 2019 16:06:39 +0000 Message-Id: <20190201160653.13829-34-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190201160653.13829-1-peter.maydell@linaro.org> References: <20190201160653.13829-1-peter.maydell@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::433 Subject: [Qemu-devel] [PULL 33/47] target/arm/translate-a64: Fix FCMLA decoding error X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The FCMLA (by element) instruction exists in the "vector x indexed element" encoding group, but not in the "scalar x indexed element" group. Correctly UNDEF the unallocated encodings. Reported-by: Laurent Desnogues Signed-off-by: Peter Maydell Reviewed-by: Laurent Desnogues Message-id: 20190129140411.682-2-peter.maydell@linaro.org --- target/arm/translate-a64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.1 diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 07fa0523935..d46ea9f64e7 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -12650,7 +12650,7 @@ static void disas_simd_indexed(DisasContext *s, uint32_t insn) case 0x13: /* FCMLA #90 */ case 0x15: /* FCMLA #180 */ case 0x17: /* FCMLA #270 */ - if (!dc_isar_feature(aa64_fcma, s)) { + if (is_scalar || !dc_isar_feature(aa64_fcma, s)) { unallocated_encoding(s); return; }