From patchwork Fri Feb 1 16:06:50 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 157282 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp644949jaa; Fri, 1 Feb 2019 08:29:52 -0800 (PST) X-Google-Smtp-Source: ALg8bN6SGDOV8/jCkwfG/PpYw58IZQlRtVp4wGpEMNst/81C1LtqxLUYfNXJGU1ng3zo9KWka8B0 X-Received: by 2002:a25:a205:: with SMTP id b5mr33376160ybi.234.1549038592711; Fri, 01 Feb 2019 08:29:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549038592; cv=none; d=google.com; s=arc-20160816; b=KKB/dZKDy5mwICPFF3R3C3n5aen2jWsshokIaJ8A+ZL4i5y7VrWnKyVRHFm9flOsV4 L0vqHtEtybzbW+Y+/abtS43ENtjSh6qadI7XaW/zibIKKoz609MEypx6WUxKrVWjYhoH lzHn/hYc2ecziUAr6jvlWoZ6O1tQ94+xOrOVmNhQsdsuxn70IrV1j7OASf/N5+eZQX1u uUj/wt7yTkNLteRgo96HLV3sOyCaWeQ2FbvOKihA1AQayVfEXFILVp3yUKRibNw65GR8 9PBQ/XufkYjLei3R0feJs+RZ6qx3XsEU+D6t707G/mZNVZIAU5UFyWRcDwhf2NBcyd3O doog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=ymo0qN3eVsrzEBkdLNPy4tKfT4b2G+wrfkd/axkYG+w=; b=NFi7K0WkC6ZbSwIdwaZGpFa/I4rO4ADepHaPAoKrbxgDDj7HaQl3Gk0Dtk1cUPvpq9 uTfgFBod63dDum8XN4Getq7NWU6ossAEKcP5vkEkgc48eCcJ0rIpKlzIy6WDw6eu149W yr9hqlwOKiF3/QTEDLqH4fJ7e55paqmyZqUxGNKDLaytP6U/MgP5TiLOVI5MNzx69svM s/Hi336A747fCwLhzEyiPSZkOfjVltJpNPd0bVWal0hftSqQNMvdphYbRAA9lBZAs+Dz axta1MjWGODHwcQ9zOfvapAXoBKkCFHiGzb+m3OPO7BlVpPNsaKd+k1/addcjGmae09B QOzQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=Rsd8dc4R; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d63si4661616ywf.107.2019.02.01.08.29.52 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 01 Feb 2019 08:29:52 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=Rsd8dc4R; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:57550 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gpbhQ-0001gf-47 for patch@linaro.org; Fri, 01 Feb 2019 11:29:52 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59102) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gpbMF-0008Id-MC for qemu-devel@nongnu.org; Fri, 01 Feb 2019 11:08:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gpbMB-0003kq-K2 for qemu-devel@nongnu.org; Fri, 01 Feb 2019 11:07:59 -0500 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]:55109) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gpbMB-0003fn-8b for qemu-devel@nongnu.org; Fri, 01 Feb 2019 11:07:55 -0500 Received: by mail-wm1-x334.google.com with SMTP id a62so6651364wmh.4 for ; Fri, 01 Feb 2019 08:07:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=ymo0qN3eVsrzEBkdLNPy4tKfT4b2G+wrfkd/axkYG+w=; b=Rsd8dc4RTcXnWcMnnhLqkzFCA9UD6MZtMV0UOm9gHiVldr6rQwvBlbFqShHvA0UVEh MDyImqXxGFbCe9hysBHqL8vIEiCnMtqLLYfRYdORYC3Zw1U30gbL/r/Z+kM2g1xu+S/U +PgPTw9baZfUxuQ2D+cezuy055L0DM2UkLCaU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ymo0qN3eVsrzEBkdLNPy4tKfT4b2G+wrfkd/axkYG+w=; b=JQCKhPFQpS0w7H2bpaCa0IYxHo7aqM6a6HgvCwqOCZIt6IxNbst7cn30u+KP7iVu8d QKTKqI9YTrqXVf+PYJsGfvNj8QTBQGDHPgAUQVM/u0t6gifDJjiOchtyPczqp/rmvyPw mo/XxUkUYFgJbfxIF8C2NTnm7DM73GnKAwp9I9cktd3XaxCXGHBHrY9V9Piq+HyE4ry+ ytJTd9xZxt3VcNFK0C1JUQeMC2IXRBOGiLTcipiY6UhfK4R2ia6NWgYA7V4sLWIdCgot dnK55uBLJuaY8n28lnUwqiCcCAaTWOkMjRzHslL2XSDo6AskM/2jb9wbcOCcpFciznV1 MHXw== X-Gm-Message-State: AHQUAub89TZZkNol9rTpkFnXpSpNFCm/w7Bto4q0XUFsTcdYGxoVwqhs ZE6T2qAgAhz8Y3xAMQCqglvmLYUA48uRkQ== X-Received: by 2002:a1c:e242:: with SMTP id z63mr2989505wmg.2.1549037271177; Fri, 01 Feb 2019 08:07:51 -0800 (PST) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id n6sm2847250wmk.9.2019.02.01.08.07.50 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 01 Feb 2019 08:07:50 -0800 (PST) From: Peter Maydell To: qemu-devel@nongnu.org Date: Fri, 1 Feb 2019 16:06:50 +0000 Message-Id: <20190201160653.13829-45-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190201160653.13829-1-peter.maydell@linaro.org> References: <20190201160653.13829-1-peter.maydell@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::334 Subject: [Qemu-devel] [PULL 44/47] target/arm: fix decoding of B{, L}RA{A, B} X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Remi Denis-Courmont A flawed test lead to the instructions always being treated as unallocated encodings. Fixes: https://bugs.launchpad.net/bugs/1813460 Signed-off-by: Remi Denis-Courmont Reviewed-by: Richard Henderson Signed-off-by: Peter Maydell --- target/arm/translate-a64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.1 diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index b864ac7a69f..a1997e3ae28 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -2036,7 +2036,7 @@ static void disas_uncond_b_reg(DisasContext *s, uint32_t insn) if (!dc_isar_feature(aa64_pauth, s)) { goto do_unallocated; } - if (op3 != 2 || op3 != 3) { + if ((op3 & ~1) != 2) { goto do_unallocated; } if (s->pauth_active) {