From patchwork Wed Feb 6 05:28:57 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 157573 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp6014561jaa; Tue, 5 Feb 2019 21:33:25 -0800 (PST) X-Google-Smtp-Source: AHgI3IbFA5/vauak9MaoGRgeqJILPJQeKCgELomwgAWAAiHeVJoWsJHsyvGN9N6JV2Blqy1CH+Us X-Received: by 2002:a25:4ac6:: with SMTP id x189mr6818656yba.259.1549431205171; Tue, 05 Feb 2019 21:33:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549431205; cv=none; d=google.com; s=arc-20160816; b=UUWDmbQ8jiqsI61RtUa7mH2/fquS4IupBrQZrXkDlsM74/gZlIHmdCUfzpAvzL6sV1 nOaD+36UBWrm9YW5cBK/igDqtrf1p63Qq75vSw4Tdplz3Ve4wY5QUTXFj8D5QVCCDvvL DuDPApMUoQ4CLUHfnjDWxQtrsPgp0yvSX9gu8xIUxpMUJu9RqI4isjxVmDQm8IaTJAhR CsjqEdPT6rqgDxHkHS7VvBp8BbDBYYt9zKm6Q9/tRdzjuFTMUlSPDCbzHp2wZ8W48dRO Kx2DLURbS2KhtwwDi/1Bl7T+oedDVi4ejU78gaCHtTM4iQe/Oj2QZ/mvt30D+I8uSz9I nm/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=4aGhOqb/f0MMWpRA3SaNTnNHXQzX7rYwLHTSfXiLLio=; b=vlzFO17onSdfhmSew9mCp2g/vPoYbmuCLLhlVLr0oYV24a3icRmS9KNJShVKJO8t3i 5R/vpPDOk5or2n4zNyaUgAcnS9pKdinBJ/RLl7yYh4RboEtufNId6QpTT4I+an2iGohg b1n1M/+MxaI1Ucg4MO7sFmupQBrqRMd/+gKUQtSf+uK/80SgAI/wGZXBduuig8OhrcY4 DjOo1qTz7Cp3FKmxXoUrEo4Nedt8mh+rCi5TeAnqbH5cwZyNMdOWSHbvwnG9GedF6vGH i1Nc9BzU3u3fJW57CBNJ6PeGNELgSKS/OboNiexxJQWLmEWOAH5P8xQR2UcpgTpP9JLm 1z2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=CRheJDgB; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id r198si3075888ywg.440.2019.02.05.21.33.24 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 05 Feb 2019 21:33:24 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=CRheJDgB; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:45415 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1grFpr-0006AK-NB for patch@linaro.org; Wed, 06 Feb 2019 00:33:23 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53355) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1grFlk-0003mr-9I for qemu-devel@nongnu.org; Wed, 06 Feb 2019 00:29:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1grFli-0006AO-UR for qemu-devel@nongnu.org; Wed, 06 Feb 2019 00:29:08 -0500 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]:39116) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1grFli-00069y-M2 for qemu-devel@nongnu.org; Wed, 06 Feb 2019 00:29:06 -0500 Received: by mail-wr1-x442.google.com with SMTP id t27so6107183wra.6 for ; Tue, 05 Feb 2019 21:29:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=4aGhOqb/f0MMWpRA3SaNTnNHXQzX7rYwLHTSfXiLLio=; b=CRheJDgBpyu2xgUVsOiPm5+B9gAa0i+Bz1pdaUX6EwI/kzvISDXZjVUJwc0dPJ9lJv bgHJaY++OKrUdqCfA3upsx5w8kDrl5P+k5uhZKENAzuIoQgxsdrSdT7RcfK+gF44bltL L4iUDI8mVmjI18+g5l5iZ5VzmN5+tvu/zLHuSpoZ+MhqOaJtbm9bHggv4W0JG02q8v8y 7S72NTUg23Xtrmi1N734S4+g5QL78jMcK/dFgIDgPz/VrVnJpJqNMrF6SKXCN0mvGNx2 lKMR+64XPVv9GSN9XOS2FHQCw+Wxdw1h84LW6BLRI93gCSAkrs0Ybah6B0FAJVmOBxN2 8PSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=4aGhOqb/f0MMWpRA3SaNTnNHXQzX7rYwLHTSfXiLLio=; b=cx6SX5JykSjvazV/pASc5flTNohLJrijvQUih7p021KNa9wLNVB5GxMN2l4nDusiTf M8nvlHbmxPHDLCgbMXFudWD+zaoPDF+V7gs6rvRbKI/6dPGgao1AxfJdksYYBadUs7HN g/lvYxBG81fnnn8t4U1OB9CN9XhcfqYOosKFTJbDha/7rsp5NfrI7pxSU1SN7Qwp8r9a E297SzgQcUHFk+BLniBkhxmVveSIY5XughHyDdaq080HyOhLD6UG5yrrxXsjGRr9DFVv aUukFgbeu2pH+qty1qQbLGBSNSShoAAQy/pwc0bQ4Eh6PK2hQabHIeshuCc7cid98SbV MvHg== X-Gm-Message-State: AHQUAuY0o0p5X0iXIT0mgmE7BXwn0Of/mFMroj/vr6NoK8aIo39C+BqC 9WmKwMtkt085J5aTHTQamkerOl6jCRPLVQ== X-Received: by 2002:adf:fc51:: with SMTP id e17mr6149240wrs.268.1549430945396; Tue, 05 Feb 2019 21:29:05 -0800 (PST) Received: from cloudburst.twiddle.net (host81-133-38-158.in-addr.btopenworld.com. [81.133.38.158]) by smtp.gmail.com with ESMTPSA id g9sm19057394wmg.44.2019.02.05.21.29.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 05 Feb 2019 21:29:04 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Wed, 6 Feb 2019 05:28:57 +0000 Message-Id: <20190206052857.5077-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190206052857.5077-1-richard.henderson@linaro.org> References: <20190206052857.5077-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::442 Subject: [Qemu-devel] [PATCH v2 3/3] target/arm: Implement ARMv8.3-JSConv X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Richard Henderson --- v2: Return 0 for NaN --- target/arm/cpu.h | 10 +++++ target/arm/helper.h | 2 + target/arm/cpu.c | 1 + target/arm/cpu64.c | 2 + target/arm/op_helper.c | 76 ++++++++++++++++++++++++++++++++++++++ target/arm/translate-a64.c | 26 +++++++++++++ target/arm/translate.c | 15 ++++++++ 7 files changed, 132 insertions(+) -- 2.17.2 Tested-by: Laurent Desnogues Reviewed-by: Peter Maydell diff --git a/target/arm/cpu.h b/target/arm/cpu.h index 47238e4245..bfc532f0ca 100644 --- a/target/arm/cpu.h +++ b/target/arm/cpu.h @@ -3227,6 +3227,11 @@ static inline bool isar_feature_aa32_vcma(const ARMISARegisters *id) return FIELD_EX32(id->id_isar5, ID_ISAR5, VCMA) != 0; } +static inline bool isar_feature_aa32_jscvt(const ARMISARegisters *id) +{ + return FIELD_EX32(id->id_isar6, ID_ISAR6, JSCVT) != 0; +} + static inline bool isar_feature_aa32_dp(const ARMISARegisters *id) { return FIELD_EX32(id->id_isar6, ID_ISAR6, DP) != 0; @@ -3305,6 +3310,11 @@ static inline bool isar_feature_aa64_dp(const ARMISARegisters *id) return FIELD_EX64(id->id_aa64isar0, ID_AA64ISAR0, DP) != 0; } +static inline bool isar_feature_aa64_jscvt(const ARMISARegisters *id) +{ + return FIELD_EX64(id->id_aa64isar1, ID_AA64ISAR1, JSCVT) != 0; +} + static inline bool isar_feature_aa64_fcma(const ARMISARegisters *id) { return FIELD_EX64(id->id_aa64isar1, ID_AA64ISAR1, FCMA) != 0; diff --git a/target/arm/helper.h b/target/arm/helper.h index 53a38188c6..6998f7e8d5 100644 --- a/target/arm/helper.h +++ b/target/arm/helper.h @@ -218,6 +218,8 @@ DEF_HELPER_FLAGS_2(rintd_exact, TCG_CALL_NO_RWG, f64, f64, ptr) DEF_HELPER_FLAGS_2(rints, TCG_CALL_NO_RWG, f32, f32, ptr) DEF_HELPER_FLAGS_2(rintd, TCG_CALL_NO_RWG, f64, f64, ptr) +DEF_HELPER_FLAGS_2(fjcvtzs, TCG_CALL_NO_RWG, i64, f64, ptr) + /* neon_helper.c */ DEF_HELPER_FLAGS_3(neon_qadd_u8, TCG_CALL_NO_RWG, i32, env, i32, i32) DEF_HELPER_FLAGS_3(neon_qadd_s8, TCG_CALL_NO_RWG, i32, env, i32, i32) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index edf6e0e1f1..8ea6569088 100644 --- a/target/arm/cpu.c +++ b/target/arm/cpu.c @@ -2001,6 +2001,7 @@ static void arm_max_initfn(Object *obj) cpu->isar.id_isar5 = t; t = cpu->isar.id_isar6; + t = FIELD_DP32(t, ID_ISAR6, JSCVT, 1); t = FIELD_DP32(t, ID_ISAR6, DP, 1); cpu->isar.id_isar6 = t; diff --git a/target/arm/cpu64.c b/target/arm/cpu64.c index eff0f164dd..69e4134f79 100644 --- a/target/arm/cpu64.c +++ b/target/arm/cpu64.c @@ -311,6 +311,7 @@ static void aarch64_max_initfn(Object *obj) cpu->isar.id_aa64isar0 = t; t = cpu->isar.id_aa64isar1; + t = FIELD_DP64(t, ID_AA64ISAR1, JSCVT, 1); t = FIELD_DP64(t, ID_AA64ISAR1, FCMA, 1); t = FIELD_DP64(t, ID_AA64ISAR1, APA, 1); /* PAuth, architected only */ t = FIELD_DP64(t, ID_AA64ISAR1, API, 0); @@ -344,6 +345,7 @@ static void aarch64_max_initfn(Object *obj) cpu->isar.id_isar5 = u; u = cpu->isar.id_isar6; + u = FIELD_DP32(u, ID_ISAR6, JSCVT, 1); u = FIELD_DP32(u, ID_ISAR6, DP, 1); cpu->isar.id_isar6 = u; diff --git a/target/arm/op_helper.c b/target/arm/op_helper.c index c998eadfaa..be555c44e4 100644 --- a/target/arm/op_helper.c +++ b/target/arm/op_helper.c @@ -24,6 +24,7 @@ #include "internals.h" #include "exec/exec-all.h" #include "exec/cpu_ldst.h" +#include "fpu/softfloat.h" #define SIGNBIT (uint32_t)0x80000000 #define SIGNBIT64 ((uint64_t)1 << 63) @@ -1376,3 +1377,78 @@ uint32_t HELPER(ror_cc)(CPUARMState *env, uint32_t x, uint32_t i) return ((uint32_t)x >> shift) | (x << (32 - shift)); } } + +/* + * Implement float64 to int32_t conversion without saturation; + * the result is supplied modulo 2^32. + */ +uint64_t HELPER(fjcvtzs)(float64 value, void *vstatus) +{ + float_status *status = vstatus; + uint32_t exp, sign; + uint64_t frac; + uint32_t inexact = 1; /* !Z */ + + sign = extract64(value, 63, 1); + exp = extract64(value, 52, 11); + frac = extract64(value, 0, 52); + + if (exp == 0) { + /* While not inexact for IEEE FP, -0.0 is inexact for JavaScript. */ + inexact = sign; + if (frac != 0) { + if (status->flush_inputs_to_zero) { + float_raise(float_flag_input_denormal, status); + } else { + float_raise(float_flag_inexact, status); + inexact = 1; + } + } + frac = 0; + } else if (exp == 0x7ff) { + /* This operation raises Invalid for both NaN and overflow (Inf). */ + float_raise(float_flag_invalid, status); + frac = 0; + } else { + int true_exp = exp - 1023; + int shift = true_exp - 52; + + /* Restore implicit bit. */ + frac |= 1ull << 52; + + /* Shift the fraction into place. */ + if (shift >= 0) { + /* The number is so large we must shift the fraction left. */ + if (shift >= 64) { + /* The the fraction is shifted out entirely. */ + frac = 0; + } else { + frac <<= shift; + } + } else if (shift > -64) { + /* Normal case -- shift right and notice if bits shift out. */ + inexact = (frac << (64 + shift)) != 0; + frac >>= -shift; + } else { + /* The fraction is shifted out entirely. */ + frac = 0; + } + + /* Notice overflow or inexact exceptions. */ + if (true_exp > 31 || frac > (sign ? 0x80000000ull : 0x7fffffff)) { + /* Overflow, for which this operation raises invalid. */ + float_raise(float_flag_invalid, status); + inexact = 1; + } else if (inexact) { + float_raise(float_flag_inexact, status); + } + + /* Honor the sign. */ + if (sign) { + frac = -frac; + } + } + + /* Pack the result and the env->ZF representation of Z together. */ + return deposit64(frac, 32, 32, inexact); +} diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 2f849a6951..b03e592edd 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -6526,6 +6526,24 @@ static void handle_fmov(DisasContext *s, int rd, int rn, int type, bool itof) } } +static void handle_fjcvtzs(DisasContext *s, int rd, int rn) +{ + TCGv_i64 t = read_fp_dreg(s, rn); + TCGv_ptr fpstatus = get_fpstatus_ptr(false); + + gen_helper_fjcvtzs(t, t, fpstatus); + + tcg_temp_free_ptr(fpstatus); + + tcg_gen_ext32u_i64(cpu_reg(s, rd), t); + tcg_gen_extrh_i64_i32(cpu_ZF, t); + tcg_gen_movi_i32(cpu_CF, 0); + tcg_gen_movi_i32(cpu_NF, 0); + tcg_gen_movi_i32(cpu_VF, 0); + + tcg_temp_free_i64(t); +} + /* Floating point <-> integer conversions * 31 30 29 28 24 23 22 21 20 19 18 16 15 10 9 5 4 0 * +----+---+---+-----------+------+---+-------+-----+-------------+----+----+ @@ -6601,6 +6619,14 @@ static void disas_fp_int_conv(DisasContext *s, uint32_t insn) handle_fmov(s, rd, rn, type, itof); break; + case 0b00111110: /* FJCVTZS */ + if (!dc_isar_feature(aa64_jscvt, s)) { + goto do_unallocated; + } else if (fp_access_check(s)) { + handle_fjcvtzs(s, rd, rn); + } + break; + default: do_unallocated: unallocated_encoding(s); diff --git a/target/arm/translate.c b/target/arm/translate.c index eb25895876..a92d06b05b 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -4066,6 +4066,21 @@ static int disas_vfp_insn(DisasContext *s, uint32_t insn) case 17: /* fsito */ gen_vfp_sito(dp, 0); break; + case 19: /* vjcvt */ + if (!dp || !dc_isar_feature(aa32_jscvt, s)) { + return 1; + } else { + TCGv_ptr fpst = get_fpstatus_ptr(0); + gen_helper_fjcvtzs(cpu_F0d, cpu_F0d, fpst); + tcg_temp_free_ptr(fpst); + + tcg_gen_extr_i64_i32(cpu_F0s, cpu_ZF, cpu_F0d); + tcg_gen_movi_i32(cpu_NF, 0); + tcg_gen_movi_i32(cpu_CF, 0); + tcg_gen_movi_i32(cpu_VF, 0); + dp = 0; /* always a single precision result */ + } + break; case 20: /* fshto */ if (!arm_dc_feature(s, ARM_FEATURE_VFP3)) { return 1;