From patchwork Mon Feb 11 01:08:19 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 157963 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp2069634jaa; Sun, 10 Feb 2019 17:32:13 -0800 (PST) X-Google-Smtp-Source: AHgI3IY9gtHXvmEtJvo38dZHHjZNGdODA1/A8j+gA961qY7+xuq5AzKx00xW+JCZk40lj/jpN4qn X-Received: by 2002:a5d:4ac2:: with SMTP id y2mr3585993wrs.98.1549848733374; Sun, 10 Feb 2019 17:32:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549848733; cv=none; d=google.com; s=arc-20160816; b=TRlnXOMMZbu971IWVAzsW4DKOKF6n+EBwWB9B0+ddvU3t+EaeLOFF/VylsZuZzKDvN oo24QE28rkChOZIqkgx95/Z20dm4TFoTh7R/9QyF5nlCbD/eEpKPdfJwYMXfZiFBa9cf UrBIiX0WWqlgG+vE+EhPE6eXexOn2dGlsdE/cW0upqxNFPqv5WY9n6F/nDghQGloOjxp iKYbBmwnYMMc16+NicjytLv6TBwFENvbd5VeRoM/YqnW2kJWH+S+yzS5LIWFnBDqMTKC /DqYzemeNWIcvalc/QLicfpnrLoM2VhNepUIPlUL9mHBcQdgWyIZHAKr+gpCwSzryqES XU0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=n4B8y8+rNu+NTfg8hfCg33xodySkURfq2FGlIVTIp5U=; b=aeiRDx34duSPrR8x3xfGWvY2EjKvByxn3H4kpgHuGBaATKkDdlk+CZXxwLoXKaCuL2 +XvJ2XgCGpN9ktUwBeD/QGjNjxFOctUHgav9Q667gI9Er0owsRwQJ03YKqJP+JlsN/30 5VBIgtKujgi8ZTRAJvJ7b4msO0BmiiYDSLoM0/VqjcyNlHgLOIVIYcIzgZuKPQB0BcxK GaMelDzTT0OKSKfkkvvWSz92d4gQlqskb+KbAsFg3Q1hFiGNxcJ0jsFyJT9dP0Iyxn/l eJZvjWVS2lNh7yJ+8ejA8k7h3/iE9WFHfkBzHoa+VQEERiusUs4JPlMixQ5Q4v5RrxbL v+kw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=IxV42RnR; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id p3si4633606wrj.146.2019.02.10.17.32.13 for (version=TLS1 cipher=AES128-SHA bits=128/128); Sun, 10 Feb 2019 17:32:13 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=IxV42RnR; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:42442 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gt0SC-0006Gy-Aa for patch@linaro.org; Sun, 10 Feb 2019 20:32:12 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37657) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gt05w-0005xX-9l for qemu-devel@nongnu.org; Sun, 10 Feb 2019 20:09:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gt05t-0000Aj-5r for qemu-devel@nongnu.org; Sun, 10 Feb 2019 20:09:12 -0500 Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]:34891) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gt05s-0008HQ-OM for qemu-devel@nongnu.org; Sun, 10 Feb 2019 20:09:08 -0500 Received: by mail-pf1-x434.google.com with SMTP id z9so4474374pfi.2 for ; Sun, 10 Feb 2019 17:08:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=n4B8y8+rNu+NTfg8hfCg33xodySkURfq2FGlIVTIp5U=; b=IxV42RnRrS15dVJKns6jDSdjgAuPFwL/uwFwQtINaxy48JKpTNa85PzMSSaFXCUByf aEgzffwd7IEEcvA10u33zF+2h9VKlifCY0L7bo6mboKYikNQWtoaZiIMWUbhdFAvujk/ 7Ghy0TLRhjyuN4lMQhcHdVKTWQiffR0QciHRNyt+4Z8PWUAEnTXwvL38cl+fuwKLBoN9 q9AcFfX24wUyLu/X4kAHKY+S8zvKMThvE8hKL3HvNjvBaCvMFFs6D1oKRPs8JY9+aJo7 SvCPXeve4RV9EGZR2ABHAQ1kf11GRIjtcw5wE5WxO2OM1rA0VzrLcCGZxxDMlkIoBWYu iPOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=n4B8y8+rNu+NTfg8hfCg33xodySkURfq2FGlIVTIp5U=; b=nYUg93p3P1hZEUYvKD6Be58ZhHgMUFrjVMiNV4csdgyLmphFufHEfMTnU3rEw0/sHx Dm3vf8Mflez2KIBxoiv9RQWXzNyrB1wtBSnileBVNPFxNwtTrA+LrLLJrwC80dpAS7XE 9AmH04SGvnbQtyN9CMVpGF82yOlE4rYgLnpCbmoS0ylj2fFiMiLFAiIJX+GLKp3Pjk0w WGncKvCrq8YJsihyaRBgz9K9vuiPOl02y5zMP/mx0xz0V9NbU5DwMHC6M3sVcnS0L49Q X8AOgfzdDZB7S+6h72gQiEkcGCQaz+oJZUup3Nw+RXwmdJLrIRyNOJUG96jdQeYWzX22 N7ew== X-Gm-Message-State: AHQUAua2ligxuz5DVmyHSDWbN+Mf4UKGgm4OjxAb1HNVXJpwjNltvqkR QFiixCvxnEh8xmeRQ7A8hG35oGXJ34I= X-Received: by 2002:a62:3888:: with SMTP id f130mr33614130pfa.132.1549847332766; Sun, 10 Feb 2019 17:08:52 -0800 (PST) Received: from cloudburst.twiddle.net (97-113-188-82.tukw.qwest.net. [97.113.188.82]) by smtp.gmail.com with ESMTPSA id g14sm17177630pfg.27.2019.02.10.17.08.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 10 Feb 2019 17:08:52 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Sun, 10 Feb 2019 17:08:19 -0800 Message-Id: <20190211010829.29869-17-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190211010829.29869-1-richard.henderson@linaro.org> References: <20190211010829.29869-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::434 Subject: [Qemu-devel] [PATCH v2 16/26] target/arm: Implement the STGP instruction X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) -- 2.17.2 diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 539c25a80b..9bd68d522c 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -2701,7 +2701,7 @@ static void disas_ld_lit(DisasContext *s, uint32_t insn) * +-----+-------+---+---+-------+---+-------+-------+------+------+ * * opc: LDP/STP/LDNP/STNP 00 -> 32 bit, 10 -> 64 bit - * LDPSW 01 + * LDPSW/STGP 01 * LDP/STP/LDNP/STNP (SIMD) 00 -> 32 bit, 01 -> 64 bit, 10 -> 128 bit * V: 0 -> GPR, 1 -> Vector * idx: 00 -> signed offset with non-temporal hint, 01 -> post-index, @@ -2726,6 +2726,7 @@ static void disas_ldst_pair(DisasContext *s, uint32_t insn) bool is_signed = false; bool postindex = false; bool wback = false; + bool set_tag = false; TCGv_i64 clean_addr, dirty_addr; @@ -2738,6 +2739,14 @@ static void disas_ldst_pair(DisasContext *s, uint32_t insn) if (is_vector) { size = 2 + opc; + } else if (opc == 1 && !is_load) { + /* STGP */ + if (!dc_isar_feature(aa64_mte_insn_reg, s) || index == 0) { + unallocated_encoding(s); + return; + } + size = 3; + set_tag = true; } else { size = 2 + extract32(opc, 1, 1); is_signed = extract32(opc, 0, 1); @@ -2788,7 +2797,12 @@ static void disas_ldst_pair(DisasContext *s, uint32_t insn) if (!postindex) { tcg_gen_addi_i64(dirty_addr, dirty_addr, offset); } - clean_addr = clean_data_tbi(s, dirty_addr, wback || rn != 31); + if (set_tag) { + clean_addr = new_tmp_a64(s); + gen_helper_stg(clean_addr, cpu_env, dirty_addr); + } else { + clean_addr = clean_data_tbi(s, dirty_addr, wback || rn != 31); + } if (is_vector) { if (is_load) {