From patchwork Mon Feb 11 23:52:46 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 158037 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp3201563jaa; Mon, 11 Feb 2019 15:57:43 -0800 (PST) X-Google-Smtp-Source: AHgI3IYGXFaHmfHQC7qPnmCRSKQmX8evsJX3/d4up8IpMiO8X8kvUhwPHZZgKBh2vkQIbhTAzRAr X-Received: by 2002:a81:7102:: with SMTP id m2mr626002ywc.235.1549929463148; Mon, 11 Feb 2019 15:57:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549929463; cv=none; d=google.com; s=arc-20160816; b=LIO/XfhZGPdlaXXqyDDf9iQjAvrqQjfllllOGU+7KeyZ4YlnSoELdPHCi74JrfSWgs ELtbTs8ud6c3rVRnMsmbqUX2kEFKXVvQ+jgn28OIPq6VST68luOhw6FzFiIR/XiE7MMY /CYlLN454xeeY0+wOIMmhv3e9EQZCh8j6dx02jdk0oK8LRxP0YITv21xVIS4PxnGoThN xOF8m1nAP3vou/VG2R/suvchVybwbQzMWo54YT/2kJ4Ux7Qk/wOTR4uanljIxyPVG/0G w4CkwCKviK/W3jUqWFOrn0NporOspMvIOUObDomaiTCuVkdURxSf8yVprI1ajVf+OhpQ fAcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=wnM/Ux+FJ1QNzphLa721yF5UFojAxLFZH8jvCJ6dar0=; b=IS4CjB2Kt2q/3ob6eY2C+oSjfy/8oKkl/OqyZtp4IKn9IZxCYfvqYS5J9Uskz6Yucb GWZBubaZDU6WOJZePc5gfSXjSVzObEfLW56tyGyaDTDrtopanz3MOyrJt2ocCvHbKR+i wsiPQ4FNZSt/AgKRon4JG/Kw/lMVsraWiWRi7WRH3uXobDOKm5eTwNsSIQNKIa+QM/pS UA24Wue8gTJkaJWV6RjRI3r1lKEZZNuIHZPMwa3jg63qHemCHQ+T1/8grwvb2NcWpvJ3 IyNf1tSt/C0i1+buH912b5FPgEOJuIKpFaj662t2xNMi1J1HkuxBm1HkqJIea79GmSNq 2DLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=FCVo6cWZ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id q6si6815716ybc.256.2019.02.11.15.57.43 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 11 Feb 2019 15:57:43 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=FCVo6cWZ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:58206 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gtLSI-0000D0-HX for patch@linaro.org; Mon, 11 Feb 2019 18:57:42 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38249) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gtLOJ-0005UG-L4 for qemu-devel@nongnu.org; Mon, 11 Feb 2019 18:53:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gtLOH-0004f8-1L for qemu-devel@nongnu.org; Mon, 11 Feb 2019 18:53:35 -0500 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]:39050) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gtLOE-0004U1-BM for qemu-devel@nongnu.org; Mon, 11 Feb 2019 18:53:30 -0500 Received: by mail-pg1-x543.google.com with SMTP id r11so318906pgp.6 for ; Mon, 11 Feb 2019 15:53:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=wnM/Ux+FJ1QNzphLa721yF5UFojAxLFZH8jvCJ6dar0=; b=FCVo6cWZzgjCIeZgsip7p6+r1b9YIuTtIIE0vpr4ICQp5tPcip6ipLVlpFpx+CMRcr h0Tuo9azsqe56vYAXBWdps+m2Ria9jnIVaZ/2OtPyn8Hd9WT9fzwW2xgalEAB7B8YrwE b9NMbQ+zq740dot2Icu2Puxh/N/q5QblmB0YhUbtswc91Z0MLG7wAcyrf2TKZ2JKuiWE 8TmeEUtW1mxU1+yOHL48gtpVIz4b4ioevtdeGVObBlWdHqtwTQseXkeziY2NTcz00BCR slzH9sIEtvwWEQ0c537bK9O09EYpdJ2ExaPUBupiGMFbKfR6OInhHcHqgwR+D/avC1+k cM7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=wnM/Ux+FJ1QNzphLa721yF5UFojAxLFZH8jvCJ6dar0=; b=TGgP3i9XcPxFLt8yw+dgxH+ZCVa6c0h/+CFh6z5MeOeI7G010zfaZD+HXbq65DmNlE HtPfMBLxXCqj/OWxnk+aAUELFSTKBTAVXj4J2c6CJAR15QQYXvwdhISLnyDh/I6RQFul m+SVp6Xh/XrtZVzfXrsU8MfmlzQdj/gEqt+M/G1QSv57kMqHVjfujVvbGDu+TecSJ+ST x7zHr1Doxo3usMHMhwS0i+HjxUKl42ss/TtSH4nLvOm7VCN6QL8miSmRpHkPwFelAbix uGezG6QyniaBirZM9myZul97iV7ZctxNdxP/B/70DJ7p4x7a+4LZke1OsJu2q/FGx0WC ZTPQ== X-Gm-Message-State: AHQUAuY+fp1PngDviFIehKjmCtKblSXckb54wQC31vMcwi1YeWv/73bN UK7suIjdCSJ8IzfkpRd5Ee8oy55fuf8= X-Received: by 2002:a62:345:: with SMTP id 66mr872084pfd.189.1549929202199; Mon, 11 Feb 2019 15:53:22 -0800 (PST) Received: from cloudburst.twiddle.net (97-113-188-82.tukw.qwest.net. [97.113.188.82]) by smtp.gmail.com with ESMTPSA id c4sm11861031pgq.85.2019.02.11.15.53.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 11 Feb 2019 15:53:21 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Mon, 11 Feb 2019 15:52:46 -0800 Message-Id: <20190211235258.542-17-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190211235258.542-1-richard.henderson@linaro.org> References: <20190211235258.542-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::543 Subject: [Qemu-devel] [PATCH v3 16/28] target/arm: Implement the STGP instruction X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Richard Henderson --- v3: Handle atomicity, require pre-cleaned address. --- target/arm/translate-a64.c | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) -- 2.17.2 diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index feed325083..ef3fc3a397 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -2708,7 +2708,7 @@ static void disas_ld_lit(DisasContext *s, uint32_t insn) * +-----+-------+---+---+-------+---+-------+-------+------+------+ * * opc: LDP/STP/LDNP/STNP 00 -> 32 bit, 10 -> 64 bit - * LDPSW 01 + * LDPSW/STGP 01 * LDP/STP/LDNP/STNP (SIMD) 00 -> 32 bit, 01 -> 64 bit, 10 -> 128 bit * V: 0 -> GPR, 1 -> Vector * idx: 00 -> signed offset with non-temporal hint, 01 -> post-index, @@ -2733,6 +2733,7 @@ static void disas_ldst_pair(DisasContext *s, uint32_t insn) bool is_signed = false; bool postindex = false; bool wback = false; + bool set_tag = false; TCGv_i64 clean_addr, dirty_addr; @@ -2745,6 +2746,14 @@ static void disas_ldst_pair(DisasContext *s, uint32_t insn) if (is_vector) { size = 2 + opc; + } else if (opc == 1 && !is_load) { + /* STGP */ + if (!dc_isar_feature(aa64_mte_insn_reg, s) || index == 0) { + unallocated_encoding(s); + return; + } + size = 3; + set_tag = true; } else { size = 2 + extract32(opc, 1, 1); is_signed = extract32(opc, 0, 1); @@ -2797,6 +2806,15 @@ static void disas_ldst_pair(DisasContext *s, uint32_t insn) } clean_addr = clean_data_tbi(s, dirty_addr, wback || rn != 31); + if (set_tag) { + TCGv_i64 tcg_rn = cpu_reg_sp(s, rn); + if (tb_cflags(s->base.tb) & CF_PARALLEL) { + gen_helper_stg_parallel(cpu_env, clean_addr, tcg_rn); + } else { + gen_helper_stg(cpu_env, clean_addr, tcg_rn); + } + } + if (is_vector) { if (is_load) { do_fp_ld(s, rt, clean_addr, size);