From patchwork Wed Feb 20 13:59:45 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corey Minyard X-Patchwork-Id: 158826 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp5075250jaa; Wed, 20 Feb 2019 07:47:37 -0800 (PST) X-Google-Smtp-Source: AHgI3IZKrKahvSBlkL2vvIWrfr8CV4CxLCSRJnwl0PdOmjDBS29k30C0MSPi1jrF7FCOZnmbefDw X-Received: by 2002:a81:5509:: with SMTP id j9mr28707582ywb.409.1550677657474; Wed, 20 Feb 2019 07:47:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550677657; cv=none; d=google.com; s=arc-20160816; b=qavpP/ZJArv11At1p17EZ185AqBMMVXgnHnQJGrD1vES/rKgp/c33LHh61tOpYxgv3 KZayPWiBRREvtO+sGSKVbgjcbI6sPUpwKXZMkNqZsEc7xcOb+XxtY5iP+SPTfBqjWzm+ KWLyImhFapdg7AUEzraVcT98sd9qIn0eGH1s1GIVaYfgUMDJY6IhVvxVG5Uyc6WPn15u ydr/msFq4dPEj0xMdekSRit43FxCfpPFnYRg5y5ePu3xf8D9Lw15YlsXx+zzmtJl5j5L SF9csKWqxM+xVsuQfH9tSV1t0BQu6f4MSTjA2Kt/gS+B5FkR1y8fQAjBpxsDa0/5EgZj yl3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=8zVyIe1cY6HugBqehzuwkdCf1WHIryJGgXM2dZd5dtU=; b=jjfhYEVfdj6PxkJVbhWNlPohUCSqPlccYrx2el7pxkx4eDh5+1220j4Q0dMvnbPTEU CyvhfCZJjG8uCeBriWQSlaslQ+9lvdyMopMd1qFsMAktyLs9bNBVSdK9HuSeMmxLVZ5b 2I4T/saJ6KAxsR9V7ogaWwmK+5XTjP0yDY1QNugdYDXarEqfTENRR6wKpsBe4vOHF6uK 1TTHDtAoPsiJ934X/0DToM+nqBGUY9z3y2Je9S993mCk7vLh4n9O+yN01ycdKvEG4ry9 z5eVAVND135/azaMj1/vdBMxctj8vMfQa+DqWznEJjwAzeD/IsWkqGO6kOP6A8Ua1N5y Ow0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=qqatf8i+; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id l79si11111345ywl.413.2019.02.20.07.47.37 for (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 20 Feb 2019 07:47:37 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=qqatf8i+; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([127.0.0.1]:41219 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gwU5x-0000qL-04 for patch@linaro.org; Wed, 20 Feb 2019 10:47:37 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51265) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gwTvk-0001uW-As for qemu-devel@nongnu.org; Wed, 20 Feb 2019 10:37:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gwTvi-0005fY-G7 for qemu-devel@nongnu.org; Wed, 20 Feb 2019 10:37:03 -0500 Received: from mail-ot1-x344.google.com ([2607:f8b0:4864:20::344]:46191) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gwTvZ-0004aU-3S for qemu-devel@nongnu.org; Wed, 20 Feb 2019 10:36:56 -0500 Received: by mail-ot1-x344.google.com with SMTP id c18so19220996otl.13 for ; Wed, 20 Feb 2019 07:34:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=8zVyIe1cY6HugBqehzuwkdCf1WHIryJGgXM2dZd5dtU=; b=qqatf8i+5UfM2XRPYDMTb5BhscvDZSqBDDw5d0fH+3u+tfNHpOlN5aohRjBWpbPWNw Usto7xoOKRTY/7Yhf7jtb1UHEjdc/qfiqe+V9YNnRXjrx37aZM+u6Y683svqMVtkGe3t Hl5W0w2yv5yWsmjDQXSIIuT64OtnIqUKuk0jz1uKMzO/9QNap1rO9KZSDxzkaO1RJWuh E7/meIIJKASwY+XHgIXaH8EVb9dKgUdM8aFz4XWazkgQ8rJmI19GlBxzsIDQ3untpM3P LQjXoSNs9jvXpjLgc/Z3Hz1y4xBnn2ZIxbQe+K+ggYik+pw2isMzU7D22gEK5AxV2vRL NvRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=8zVyIe1cY6HugBqehzuwkdCf1WHIryJGgXM2dZd5dtU=; b=LI0NpZjOcDuvQApldWsWbB3j5//OqQfTKJIeqkmNLudGCmcIv39xJaMxV/Qcf8K3PE 6OoctI7PCyQHcOKQ2fTvmTVxrIv5tjqymc+8gVitMhYc089RFdxWHs1c53z6M70yNtia WBsyHjh7GYLp4ovhkOgU3dASQe3JLt5rMR7dqE9mXaeSDhC58mOnDvkrc64GwDAmCcln st6ZoHmNVMHP+4m8UseQAysTkhZRsTak0kafLix2sc70pf7hP9HyLCyX28S4CeWsZitN PlLrUwk7t9FfbYjh6oLAfTMYg8jNbVhUr2n18y2L7y/8q6ZVHx18XDkIpYQ58fRjPYEl aWsA== X-Gm-Message-State: AHQUAuZQ1Wu0qK8jjMLiWj7WNmg7tXhJR9DyHyTSfPJN6Ha8qlSqqvMB S+DRWNkWv5oacrugQ+ZrfxZQXyH+XA== X-Received: by 2002:aca:75cf:: with SMTP id q198mr6067698oic.125.1550671215197; Wed, 20 Feb 2019 06:00:15 -0800 (PST) Received: from serve.minyard.net (serve.minyard.net. [2001:470:b8f6:1b::1]) by smtp.gmail.com with ESMTPSA id l134sm3198160oih.43.2019.02.20.06.00.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Feb 2019 06:00:12 -0800 (PST) Received: from t430.minyard.net (unknown [IPv6:2001:470:b8f6:1b:d1f6:7172:48bb:512b]) by serve.minyard.net (Postfix) with ESMTPA id 7B7CC1808F5; Wed, 20 Feb 2019 14:00:09 +0000 (UTC) Received: by t430.minyard.net (Postfix, from userid 1000) id 2F8A8302812; Wed, 20 Feb 2019 08:00:08 -0600 (CST) From: minyard@acm.org To: qemu-devel@nongnu.org Date: Wed, 20 Feb 2019 07:59:45 -0600 Message-Id: <20190220135956.22589-9-minyard@acm.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190220135956.22589-1-minyard@acm.org> References: <20190220135956.22589-1-minyard@acm.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::344 Subject: [Qemu-devel] [PATCH 08/19] i2c:smbus_eeprom: Get rid of the quick command X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Corey Minyard , Corey Minyard , "Michael S . Tsirkin" , "Dr . David Alan Gilbert" , Paolo Bonzini Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Corey Minyard It's not necessary, it won't be called if it's NULL. Signed-off-by: Corey Minyard --- hw/i2c/smbus_eeprom.c | 8 -------- 1 file changed, 8 deletions(-) -- 2.17.1 diff --git a/hw/i2c/smbus_eeprom.c b/hw/i2c/smbus_eeprom.c index c2b9e3383e..4bc579e69e 100644 --- a/hw/i2c/smbus_eeprom.c +++ b/hw/i2c/smbus_eeprom.c @@ -36,13 +36,6 @@ typedef struct SMBusEEPROMDevice { uint8_t offset; } SMBusEEPROMDevice; -static void eeprom_quick_cmd(SMBusDevice *dev, uint8_t read) -{ -#ifdef DEBUG - printf("eeprom_quick_cmd: addr=0x%02x read=%d\n", dev->i2c.address, read); -#endif -} - static uint8_t eeprom_receive_byte(SMBusDevice *dev) { SMBusEEPROMDevice *eeprom = (SMBusEEPROMDevice *) dev; @@ -95,7 +88,6 @@ static void smbus_eeprom_class_initfn(ObjectClass *klass, void *data) SMBusDeviceClass *sc = SMBUS_DEVICE_CLASS(klass); dc->realize = smbus_eeprom_realize; - sc->quick_cmd = eeprom_quick_cmd; sc->receive_byte = eeprom_receive_byte; sc->write_data = eeprom_write_data; dc->props = smbus_eeprom_properties;