diff mbox series

[3/5] decodetree: Ensure build_tree does not include values outside insnmask

Message ID 20190223232954.7185-4-richard.henderson@linaro.org
State Superseded
Headers show
Series decodetree enhancements | expand

Commit Message

Richard Henderson Feb. 23, 2019, 11:29 p.m. UTC 
From: Philippe Mathieu-Daudé <f4bug@amsat.org>


Reproduced with "scripts/decodetree.py /dev/null".

Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

---
 scripts/decodetree.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.17.2

Comments

Bastian Koppelmann Feb. 25, 2019, 10:08 a.m. UTC | #1 
On 2/24/19 12:29 AM, Richard Henderson wrote:
> From: Philippe Mathieu-Daudé <f4bug@amsat.org>

>

> Reproduced with "scripts/decodetree.py /dev/null".

>

> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>

> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

> ---

>   scripts/decodetree.py | 2 +-

>   1 file changed, 1 insertion(+), 1 deletion(-)


Reviewed-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>


Cheers,

Bastian
diff mbox series

Patch

diff --git a/scripts/decodetree.py b/scripts/decodetree.py
index ba203aeccd..fb9a0ab3ad 100755
--- a/scripts/decodetree.py
+++ b/scripts/decodetree.py
@@ -784,7 +784,7 @@  class Tree:
 
 def build_tree(pats, outerbits, outermask):
     # Find the intersection of all remaining fixedmask.
-    innermask = ~outermask
+    innermask = ~outermask & insnmask
     for i in pats:
         innermask &= i.fixedmask