From patchwork Thu Mar 7 14:41:21 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 159850 Delivered-To: patch@linaro.org Received: by 2002:a02:5cc1:0:0:0:0:0 with SMTP id w62csp7523527jad; Thu, 7 Mar 2019 06:52:35 -0800 (PST) X-Google-Smtp-Source: APXvYqzH5VT5xdDZgPI7Bc8QDbQDMszIVC95/2iHsWXVFz4bAktRrkBzEU6Yuh2rt5s3KpcheQuz X-Received: by 2002:a25:bfc1:: with SMTP id q1mr7446798ybm.135.1551970355563; Thu, 07 Mar 2019 06:52:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551970355; cv=none; d=google.com; s=arc-20160816; b=MDcRtVGtZnO9goukuIvV+XAPagXv4Q6FvZyCiXEVxHE6wFtS2oJRlnjwsdpNs3lVHH oAqiQQ5+fj2bvXhOONZ31gNsZZ8GtfgQZ6sOFeS2LvP4uzhBpfpA7NuyWsfFb44zU+N6 m//Na3UkVmYQy3PpUOURE2r4PZ5fAPTTOns9yPXoammdGD3Btr+e66PUno5Fo+tGSy+K pPUuolAw+sEMR0+dXOEZFRo1ReUNWhkm558w5pbQapZ882cy4E6DttO3RU6st9zjLmO0 gOwURQweFjMuhVFnMUHhQkmZPg960Lb08it+DZ9wtp8tVxxb9EtS8JNcpAa6DxX7sJht 6ZjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=jIwc8Ul+d1IuyfgI8rDvhEncHi1wfHXduZoztXJbzO4=; b=Md9hQ3rgfuJxaJrfbka+vcdFqAX1TRWVd3HZFES37R+IW5RF7aWESlr3IdAAQ+KBbE QB6PxYkb1UrGVpagOVtQWZthTIWHPFmkaTwfbiLv68Qf+v8OtFOn7qIWf+8HEOm5iK5G 4xxsx70w9X/mSOgvweMKDxN65K53pu5L6jkY30RryvgTc8LGA0XJEF2kG+LJ705T372B fEqTaQ4QGGeJ5c84HVYUPWxcVzBD669BfxasEHzM0Z8JPzdCQw/80g6PR1/PAA12MJyY 1z19OHZtW4go6sh4Afyy+/pBv6LVYCEHuRb6spdl6oDNqeTZfwh0z9JsBmrIu/u1dGnc qn5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=pRNwimGO; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id f16si2779548ybn.24.2019.03.07.06.52.35 for (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 07 Mar 2019 06:52:35 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=pRNwimGO; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:53103 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1uNv-0006Wy-2r for patch@linaro.org; Thu, 07 Mar 2019 09:52:35 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49468) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1uDH-0006m5-G3 for qemu-devel@nongnu.org; Thu, 07 Mar 2019 09:41:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h1uDG-0003V4-IX for qemu-devel@nongnu.org; Thu, 07 Mar 2019 09:41:35 -0500 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]:40378) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h1uDG-0003TJ-BQ for qemu-devel@nongnu.org; Thu, 07 Mar 2019 09:41:34 -0500 Received: by mail-pg1-x544.google.com with SMTP id u9so11414140pgo.7 for ; Thu, 07 Mar 2019 06:41:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=jIwc8Ul+d1IuyfgI8rDvhEncHi1wfHXduZoztXJbzO4=; b=pRNwimGO8HXYv5smjiJ9GXElzjGmJnEeai80bJWS5JrH385TER3pvl116M9CUTtYU9 yMpYfTYnmR7oWcz0bvpL4sIAHUq9GZBlp80TrMCb8VeevhsypOyMLaQGaZSd7wLO4tBq XrrhMB6mXHV/eLWFLlijKDHrC+nB2h3yNl405C3ndpDwhDfXIXLPKH0bmxE4aq3a6YOJ AYEz4iwb49oUBexppOEH6qcKS7uufQChYX/HRmS9knajNaGQ0TkWmkrHphrXBrB40Wf4 ivrXx7OI6Tk2uujnEpjlAAoRSS04mpzmC9BTY3kuDiquxLdmWjrcwGJi1s6vHdArHtRM Qbxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=jIwc8Ul+d1IuyfgI8rDvhEncHi1wfHXduZoztXJbzO4=; b=TiLjP1QXgv5CNfmIRBQhop1c9Taj5SBP+DMW/fJGR2rDfOkHooJqEePYVS1p5ivkMd /jRhm6TPi3347PwO2ZKggWEcB0gLxKl0UQ8yT3tY/np4x3Mixu6X7WXgqX2wARc8j/4U Iz6BIQd4eA5WkoMj6P6XehB9WSQ8ZU05SYEWAyWNGS8O+slONoVPNPhbwgtxydVWDaL5 qSf+g+K6xrFwVdWsXs/1GyMwDLs5vhEsi7ggzqDROG410HNvqa/AHIllwtzDSnomd33B VDWt9r4l5u8oTn2vjTEzphl8JHXYQVTwvUPuntLpVE8GtSpioV8OzxSWn80P50Ln18Ac s51Q== X-Gm-Message-State: APjAAAWHgGhEOi4sroBsUE3HVDe7VZxOYyomcM8Jxl2i4FXQ0wI84NNK VQxrnga+nFR6OUSIBlS+9Ovl91bPPt4= X-Received: by 2002:a17:902:aa87:: with SMTP id d7mr12805652plr.146.1551969693083; Thu, 07 Mar 2019 06:41:33 -0800 (PST) Received: from cloudburst.twiddle.net (97-113-188-82.tukw.qwest.net. [97.113.188.82]) by smtp.gmail.com with ESMTPSA id p2sm6222838pgs.7.2019.03.07.06.41.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 07 Mar 2019 06:41:32 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Thu, 7 Mar 2019 06:41:21 -0800 Message-Id: <20190307144126.31847-5-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190307144126.31847-1-richard.henderson@linaro.org> References: <20190307144126.31847-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::544 Subject: [Qemu-devel] [PATCH 4/9] tcg: Use extract2 in tcg_gen_deposit_{i32, i64} X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: david@redhat.com Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Richard Henderson --- tcg/tcg-op.c | 28 ++++++++++++++++++++++++++-- 1 file changed, 26 insertions(+), 2 deletions(-) -- 2.17.2 diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c index 34e0dbc6e0..caee80235e 100644 --- a/tcg/tcg-op.c +++ b/tcg/tcg-op.c @@ -614,6 +614,18 @@ void tcg_gen_deposit_i32(TCGv_i32 ret, TCGv_i32 arg1, TCGv_i32 arg2, mask = (1u << len) - 1; t1 = tcg_temp_new_i32(); + if (TCG_TARGET_HAS_extract2_i32) { + if (ofs + len == 32) { + tcg_gen_shli_i32(t1, arg1, len); + tcg_gen_extract2_i32(ret, t1, arg2, len); + goto done; + } + if (ofs == 0) { + tcg_gen_extract2_i32(ret, arg1, arg2, len); + tcg_gen_rotli_i32(ret, ret, len); + goto done; + } + } if (ofs + len < 32) { tcg_gen_andi_i32(t1, arg2, mask); tcg_gen_shli_i32(t1, t1, ofs); @@ -622,7 +634,7 @@ void tcg_gen_deposit_i32(TCGv_i32 ret, TCGv_i32 arg1, TCGv_i32 arg2, } tcg_gen_andi_i32(ret, arg1, ~(mask << ofs)); tcg_gen_or_i32(ret, ret, t1); - + done: tcg_temp_free_i32(t1); } @@ -2027,6 +2039,18 @@ void tcg_gen_deposit_i64(TCGv_i64 ret, TCGv_i64 arg1, TCGv_i64 arg2, mask = (1ull << len) - 1; t1 = tcg_temp_new_i64(); + if (TCG_TARGET_HAS_extract2_i64) { + if (ofs + len == 64) { + tcg_gen_shli_i64(t1, arg1, len); + tcg_gen_extract2_i64(ret, t1, arg2, len); + goto done; + } + if (ofs == 0) { + tcg_gen_extract2_i64(ret, arg1, arg2, len); + tcg_gen_rotli_i64(ret, ret, len); + goto done; + } + } if (ofs + len < 64) { tcg_gen_andi_i64(t1, arg2, mask); tcg_gen_shli_i64(t1, t1, ofs); @@ -2035,7 +2059,7 @@ void tcg_gen_deposit_i64(TCGv_i64 ret, TCGv_i64 arg1, TCGv_i64 arg2, } tcg_gen_andi_i64(ret, arg1, ~(mask << ofs)); tcg_gen_or_i64(ret, ret, t1); - + done: tcg_temp_free_i64(t1); }