From patchwork Fri Mar 15 03:26:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 160375 Delivered-To: patch@linaro.org Received: by 2002:a02:5cc1:0:0:0:0:0 with SMTP id w62csp16268212jad; Thu, 14 Mar 2019 20:41:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqy0vmqmupxYviQ1PJFAOiT5YT7DNmK5RXNZTrNVuuS2E24pkV6l1tWoxa/9+BqExT3tpB/w X-Received: by 2002:a5d:6b4a:: with SMTP id x10mr711574wrw.63.1552621305016; Thu, 14 Mar 2019 20:41:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552621305; cv=none; d=google.com; s=arc-20160816; b=VFDAz8HVJQzZH3DJpoT5i0D9ZWI4GLWGYXylMv0WYVdxOQrm8R+E6X3mPWbtX1yYY7 TZYoBZeqOvgMR2R4YczienbReY8PU4+JDZzHiLeLMaVJ6/AGeIHWHdMRrsNcV9CN0I9k 23GB329Z8vp4jVgHVapurs3o8ZGW4xQKJyZg/JMLnmhxsRzzoiDyi8dXS8sL4fBBQ7JF GyLxVmiBL/n6KkCh8Ch2QT10iIxrMaFCj5evomx39VbNj7YNFfhrJ4PxD6m9ClSFedrL oNCsuxdTMgQCuY+OQkIPcaImWRrJhqcd9qtHPIHvp5qRYTUg2rTgi0233L5gHDAYprQ9 LYew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=40dndFEh1rhwW/qt+1fjHft74TzjNjRDxNO1+LXr9wE=; b=XR5Zbo49bs8WT9ejoGs4pks3S5EbfhaV/SSVeB/3jq1uCIU4gK2gEPcAn8jLCb6uqS VfyGzszzFvaUmcFU5NPfV+35e/hNwxxmAC6Jw3B5Eref+j5lkna3Z8ZKXkuVLlsNp9JU XpAG4EaNAXj6jfuUNZbUVTfDHnC5YZUBFJWIp6pQ1xnFwUVMOIcoyPs0l+oZbzv9m6Ci z76UFPPIPRZT9ZXqYLudYLEBf9EmB7QC9RB7B7jX2QjuLy2SZ5Rdt26TManzkG1RK9Rt n4uDZNERE048sz+Af9d6BvtPgI40ujpqj8aAidwTQXFQhRVCiPZXo0v5XNhusSNZ3WyW IRHA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=CElIfdGm; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id v8si576208wrn.324.2019.03.14.20.41.44 for (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 14 Mar 2019 20:41:45 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=CElIfdGm; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:48789 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4dj5-0002ds-VS for patch@linaro.org; Thu, 14 Mar 2019 23:41:44 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43825) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4dcJ-0005BE-70 for qemu-devel@nongnu.org; Thu, 14 Mar 2019 23:34:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h4dUl-00033v-DP for qemu-devel@nongnu.org; Thu, 14 Mar 2019 23:26:56 -0400 Received: from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532]:37579) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h4dUl-000328-77 for qemu-devel@nongnu.org; Thu, 14 Mar 2019 23:26:55 -0400 Received: by mail-pg1-x532.google.com with SMTP id q206so5414355pgq.4 for ; Thu, 14 Mar 2019 20:26:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=40dndFEh1rhwW/qt+1fjHft74TzjNjRDxNO1+LXr9wE=; b=CElIfdGmPne/v85S7uvHoo+rC75WrJUtTc2v2CGF+exW2XWwDkSLkwUeCfvH6LU2+B X118oR5cpp7GM8+q6hYz+T2UXGPGNs8MHFfC2AzvkLorMv89ftqeiyKf2abFqyEh5oPA xPQz5LjG/hdV+qbF+y5h02oQuMsZqKsfIy1IpvYpXrZq3dVbxBgKHhU/vuUk0dih7Ika cygEiP8lKcdLlWSTCQXiYJEaXYqh8cSMMEjlYc2LwDKbvBpYoMmeSLNE371zTG260X9A G54+OeOf/8T41M5zjL8jZCcer21BI2UbklnjqCQgcWuA06Ur0HzY6oVo6HdrqQmnAZmI FXhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=40dndFEh1rhwW/qt+1fjHft74TzjNjRDxNO1+LXr9wE=; b=RpcbWatv1ifcEut1rCk87BE/ku/x/BzSuJqDfQODr9nt/Y0NCgYDV0G791yMsskvo1 +iOHyjTpdljzVq6EcX4XgojJO4TQkzfWE8Ho0mkZD00oXdyO+3VH39c9QNxuzsNsO3j2 pz0C4/dXjqw73CBPzwpjt4VDLJVwAqTIjjMUop6llOzd+LRAM5KfTpo/ZqorRqgSAtwC hmb2WxBbQu9D/vMYJO9lw0iDfxGYz671HXhZrCtqzXRxzpbP7zYQsYy8fUFkf9KL5l0F uekjWyPjga0MBryBCyR8aBhXUB2Z+mkU4159XYp7yFTx95pY9FUUoe6RGPtMiijSyZNG zCBw== X-Gm-Message-State: APjAAAU/bhfmZ92LyWqm6+QXkQjvCljkoXCI9KZDavG+ntPMIXk0BR3x ITvpTMPPf5jf9aPJCvHnQKE+UVSi44Y= X-Received: by 2002:a17:902:8a96:: with SMTP id p22mr1783432plo.113.1552620414022; Thu, 14 Mar 2019 20:26:54 -0700 (PDT) Received: from cloudburst.twiddle.net (97-113-188-82.tukw.qwest.net. [97.113.188.82]) by smtp.gmail.com with ESMTPSA id d26sm690816pfn.86.2019.03.14.20.26.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 14 Mar 2019 20:26:53 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Thu, 14 Mar 2019 20:26:23 -0700 Message-Id: <20190315032629.21234-18-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190315032629.21234-1-richard.henderson@linaro.org> References: <20190315032629.21234-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::532 Subject: [Qemu-devel] [PATCH v3 17/23] hw/misc/nrf51_rng: Use qemu_guest_getrandom_nofail X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org, Joel Stanley Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The random number is intended for use by the guest. As such, we should honor the -seed argument for reproducibility. Use the *_nofail routine instead of error_abort directly. Cc: qemu-arm@nongnu.org Cc: Joel Stanley Signed-off-by: Richard Henderson --- hw/misc/nrf51_rng.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.17.2 Reviewed-by: Joel Stanley diff --git a/hw/misc/nrf51_rng.c b/hw/misc/nrf51_rng.c index d188f044f4..3400e90a9b 100644 --- a/hw/misc/nrf51_rng.c +++ b/hw/misc/nrf51_rng.c @@ -14,7 +14,7 @@ #include "qapi/error.h" #include "hw/arm/nrf51.h" #include "hw/misc/nrf51_rng.h" -#include "crypto/random.h" +#include "qemu/guest-random.h" static void update_irq(NRF51RNGState *s) { @@ -145,7 +145,7 @@ static void nrf51_rng_timer_expire(void *opaque) { NRF51RNGState *s = NRF51_RNG(opaque); - qcrypto_random_bytes(&s->value, 1, &error_abort); + qemu_guest_getrandom_nofail(&s->value, 1); s->event_valrdy = 1; qemu_set_irq(s->eep_valrdy, 1);