From patchwork Fri Mar 15 03:26:25 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 160372 Delivered-To: patch@linaro.org Received: by 2002:a02:5cc1:0:0:0:0:0 with SMTP id w62csp16267662jad; Thu, 14 Mar 2019 20:40:48 -0700 (PDT) X-Google-Smtp-Source: APXvYqyxp7xLucbRmpwt0ZfXeaf+ieiTP6Tf5Uc7XDfq84c6fwZrsvDDyuWZroyJFqjyEb0XPMWa X-Received: by 2002:a1c:ef0c:: with SMTP id n12mr559306wmh.105.1552621248789; Thu, 14 Mar 2019 20:40:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552621248; cv=none; d=google.com; s=arc-20160816; b=ULIVR57eZV7hxfBD0P5Vogt9RyQggPjJJlZG4KQ2wcflF7Q09nUoWYIRX7p3SI2s0H xM62Unix8y7pODAjAiJYErt806GOwJsREgeAFC6VnVj2krPB9iK0OGUVQlRE9hsYPVuy p96tCb1T5FjoG4o7yz8bFA/V70sKMpKAVQ5541cwOBHmYuTtNZghpw1i0SYLMCDrBNV8 MjufUnaW9PAG/WxoB2CAWDZR1K2ykGb3Dw4XnlA5K65SPWcUtrJUG5eMEk4eBPb/enOy YKk2p1N7cv3+oKq4B9Y8QlUpSZZmQ0SMaCHrdNd6+0XhVtecTUSx3qI5hSAQ0FkxsEEf 101Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=wbb+2FtxbsNv9nDIL4ojxmrs2WISC5sGRSdsm2e7KNc=; b=MtwTWe95UZyv7pG2pfrJamxTZNsgLZsoMVyZJo3c4Q1drmzD8jw5l1Umco17M0db8L lo0ybPtsW+5pdXDJHPF/LNGdmhbIhthtAtBMElOT5FZrGN+iOnF4uEmZs+V5R/DRl0vM zBJ/a1yHoUD/ERTXvEa5occ/6x5indkUYCkPHyX9VL9Im3LvRwJ2TM79yXlDHtOR4RTL wpuPxsrqxdou7VjxlIiTZIbmLLt+Gs4vnWA8p8qPp9a2SEEFyjzHmEfDwbIpuqZfqvzO +dTQHP7tG4r4Ir/4V3WgwjxE/6WFXKJUlAomYFHUfxZ3wmjscuDMc2/tWEsrpnjp2hHm DZIg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=MpbBVGj6; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id l2si2478275wml.1.2019.03.14.20.40.48 for (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 14 Mar 2019 20:40:48 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=MpbBVGj6; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:48778 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4diB-0001rc-LC for patch@linaro.org; Thu, 14 Mar 2019 23:40:47 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43798) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4dcI-00059t-MP for qemu-devel@nongnu.org; Thu, 14 Mar 2019 23:34:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h4dUo-000376-Bl for qemu-devel@nongnu.org; Thu, 14 Mar 2019 23:26:59 -0400 Received: from mail-pg1-x52a.google.com ([2607:f8b0:4864:20::52a]:39945) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h4dUo-00036I-6C for qemu-devel@nongnu.org; Thu, 14 Mar 2019 23:26:58 -0400 Received: by mail-pg1-x52a.google.com with SMTP id u9so5403507pgo.7 for ; Thu, 14 Mar 2019 20:26:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=wbb+2FtxbsNv9nDIL4ojxmrs2WISC5sGRSdsm2e7KNc=; b=MpbBVGj6KrFs2tVEETUExFUhEjqs/GUUqi28oWfBgjJR2MIBDQpuuWcAmXm72g4VB4 cT7OFFGEBnx0tpNzD672yvpL7Mh4CYbkC40a5qIfIiY0IJ5UmFFjnhkwHWtmLwi8MEON Kjpf6aR3vr/wmvaPrTfIqDq/NMFtuvvoDsLE05uWyAgmNQJCknUugQbYhicdE9JUoHVj qEW7+7i+pF72dsesyvegmtp0g7K8ZmjxNJFvcyYPABxUO9vXuwP6zU42EnYLGQzwmcTx 6gPDIIb1Pmw1BKFDuhJoPf3z3l/7jJQZ2XrTz+502ttXx48AGUNiRwlOeR2IDnq/dO96 c0RQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=wbb+2FtxbsNv9nDIL4ojxmrs2WISC5sGRSdsm2e7KNc=; b=bsT8QPJynNG2zw4JvcmX6fnPk6IM61HX8HRPJLUMITotwlqrKcOCxfCteMcUIbAHSy ZUVI/K7E7Flc+Sobr6ePy5y6fRstoe+KcYTZfE5ueO1u53P5y6pYlwpL07mvWC0AdFIV +SKfAvjehYb7rDqBpjGj2QHiG9H7i1huynDdcV98uwFTLfx0OlyAy6woBmljx1bwRlxJ SJH1H68RUnwEwdAAirdBzxgN2jkt4ZdaaDrYP3UynSLCpTIwmmbcefmGCGvO9K4spx3k lP4r2nDpCC9S+DX1wIFoLnMhYkDeS8qcEsETX1odeGrxfo+OmQtQHYLxp5poh1vRNB/n 9/iQ== X-Gm-Message-State: APjAAAVCm/MKDwUmFHqGuFjcibKDhJZpjQ7zLObmlxmx8fFrUcorJZcV in6yPSNhhZbPdNyC1nCZiOhT+lpnKlk= X-Received: by 2002:a17:902:1125:: with SMTP id d34mr1816140pla.75.1552620416859; Thu, 14 Mar 2019 20:26:56 -0700 (PDT) Received: from cloudburst.twiddle.net (97-113-188-82.tukw.qwest.net. [97.113.188.82]) by smtp.gmail.com with ESMTPSA id d26sm690816pfn.86.2019.03.14.20.26.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 14 Mar 2019 20:26:56 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Thu, 14 Mar 2019 20:26:25 -0700 Message-Id: <20190315032629.21234-20-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190315032629.21234-1-richard.henderson@linaro.org> References: <20190315032629.21234-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::52a Subject: [Qemu-devel] [PATCH v3 19/23] hw/misc/exynos4210_rng: Use qemu_guest_getrandom X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Igor Mitsyanko , qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The random number is intended for use by the guest. As such, we should honor the -seed argument for reproducibility. Cc: qemu-arm@nongnu.org Cc: Igor Mitsyanko Signed-off-by: Richard Henderson --- hw/misc/exynos4210_rng.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) -- 2.17.2 Reviewed-by: Philippe Mathieu-Daudé diff --git a/hw/misc/exynos4210_rng.c b/hw/misc/exynos4210_rng.c index 4ecbebd2d7..0e70ffb404 100644 --- a/hw/misc/exynos4210_rng.c +++ b/hw/misc/exynos4210_rng.c @@ -18,10 +18,10 @@ */ #include "qemu/osdep.h" -#include "crypto/random.h" #include "hw/sysbus.h" #include "qapi/error.h" #include "qemu/log.h" +#include "qemu/guest-random.h" #define DEBUG_EXYNOS_RNG 0 @@ -109,7 +109,6 @@ static void exynos4210_rng_set_seed(Exynos4210RngState *s, unsigned int i, static void exynos4210_rng_run_engine(Exynos4210RngState *s) { Error *err = NULL; - int ret; /* Seed set? */ if ((s->reg_status & EXYNOS4210_RNG_STATUS_SEED_SETTING_DONE) == 0) { @@ -127,13 +126,11 @@ static void exynos4210_rng_run_engine(Exynos4210RngState *s) } /* Get randoms */ - ret = qcrypto_random_bytes((uint8_t *)s->randr_value, - sizeof(s->randr_value), &err); - if (!ret) { + if (qemu_guest_getrandom(s->randr_value, sizeof(s->randr_value), &err)) { + error_report_err(err); + } else { /* Notify that PRNG is ready */ s->reg_status |= EXYNOS4210_RNG_STATUS_PRNG_DONE; - } else { - error_report_err(err); } out: