From patchwork Tue May 14 00:05:11 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 164073 Delivered-To: patch@linaro.org Received: by 2002:a92:9e1a:0:0:0:0:0 with SMTP id q26csp1968182ili; Mon, 13 May 2019 17:08:15 -0700 (PDT) X-Google-Smtp-Source: APXvYqxXBHt5zalRQIYabC0k/rkpssvyP02MSposYfxmU6HqAM99eAbvu6PogM+4Nsc8kkjz/7Au X-Received: by 2002:a50:8877:: with SMTP id c52mr32389820edc.253.1557792494923; Mon, 13 May 2019 17:08:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557792494; cv=none; d=google.com; s=arc-20160816; b=s2/DXKx7AYxrqdqIv7OidJj9thf/iWlb4iimeZDLRmKFBWiG6v6dPTWh++8s6TdMXE Ps/j1TTJLOxPfTACBq36/S1uELhLQB5s+9bWmU7yfvk5wuzY/dvRBIbn7l6+zzNdFALT EnXh0br815nigU68Iz6FNeY8mBNMPa3jqIPA7+KJoG54w8aPahEc0G33/Ffw1n4vhbAU VLfTY7qhdWWQuXTe7WM/hcFPHiCoL0LKcxIvbqNNM4YIsC3K+iq4VKO5746u1lacI04y ViJld3vYrMRwS+3b0vsl1qUP1jmDjocX7/8Dxc+09LiOZH34s36UHpnxkNIgmioopCic 2NMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=I6td3WuBBk5Qpr2iJ7wAnroVlDoSyj0rbd0/PnMjxvM=; b=zRVNNhdR+ujARmH49DZlZP+Vc0ux8k1XzNJqk4y2+1i6nrLUM3/rMFGNyG/NibL05B pAmcieYekIvrE/vygsmXlXSLqR5r8cBE3aOCFMErsa7bnn/PMhK2tUeOA0WRaahxAW+z m2Ze1QpUubwziDDQ0jLtQt7KJRUmhruDL3Nyo42PhOCaWDX5QiciQ2LzygBUonS2d4nx kpI3GnvnK0DhoFRMscP6/BszU+03J0hUbe21xbi53xo4qHqYpXLYWX/jn0GG9VL6hdZf OfGwP2YYZ/4zkXXspi8cxvuAXmtYXAsXaToalmlgKLYPNyWfO1Gxrxji4NKfDVt2K0rG gmxg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=sBXrfU3h; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id i13si691469ede.59.2019.05.13.17.08.14 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 13 May 2019 17:08:14 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=sBXrfU3h; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:36595 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQKzN-0001vh-Qh for patch@linaro.org; Mon, 13 May 2019 20:08:13 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50780) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQKxx-0001cr-E4 for qemu-devel@nongnu.org; Mon, 13 May 2019 20:07:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hQKx8-00035H-SK for qemu-devel@nongnu.org; Mon, 13 May 2019 20:06:45 -0400 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]:41400) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hQKx3-0002uf-3g for qemu-devel@nongnu.org; Mon, 13 May 2019 20:05:52 -0400 Received: by mail-pl1-x634.google.com with SMTP id f12so5249144plt.8 for ; Mon, 13 May 2019 17:05:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=I6td3WuBBk5Qpr2iJ7wAnroVlDoSyj0rbd0/PnMjxvM=; b=sBXrfU3h7DR8iOmdcNVwa3erjb1ZKldKP6Cm7+2f/rnMLVzFlj6A5nGT9fWeQh7iob WqlZrJe+1lSiEbRNvw7K7uWJyRrRWc4xdB45wwPXImlIsgQd+kuSWLkWC5FY+y1PaPqs btYVefJG0d2qEJqf61xxCT4SPE9wM/fqPbzH7Mmba5d+5eWeayHUFwmLwfkA5iGE37uo 84uxp3ZBOs+y0LPl/5ThT0l29Q7YyoL+UomSkt9jTPBkBkuMoFJS2j5L30jLDBsu5OYW Hfg3Ljyed6HMncCMD3E8VJOQS02z+wgfeSpPFKrH8F1e1bCc1ugKfhtWTH+coBVlzNqS Qdng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=I6td3WuBBk5Qpr2iJ7wAnroVlDoSyj0rbd0/PnMjxvM=; b=Nsr+8hQ3uh762datARiizn6MNhQ8GeyjcuH0QwL8GwygVbQzwHaxPEki3V77ptkTlb yihwm0FsvDlLOhtB45CjKcfGjgCHPb+YkwS7DVlfWR9GV6JTISlT1N79BTQN2+WQeSF/ ifgt5ALEpFmF06nPIbNNoXRmYr0mMMo0cmtF2gOb8r1zXApGnD5AYTdRs2yxlcEDQwIt dxHDCn1CzROsuBqQtEkgYzmAejzUHqxDVOvSnneThIhft3mqfPNQsSKKRFrkEcCjIMzi qS7pzQHc3H5awwKpEaSZtEslaiGrPtIJJMhGHQY7nEGybIpnR8jwf443seoNzBprKC/a sQpQ== X-Gm-Message-State: APjAAAUskd5KcDe9YBR4NtGV1KBs+6nMvLI410GU0k96sk1ihM56Vp1L Dh/QSDMRmYfJpMRlZsJxuYADFqf4Bws= X-Received: by 2002:a17:902:8c82:: with SMTP id t2mr26391194plo.256.1557792345431; Mon, 13 May 2019 17:05:45 -0700 (PDT) Received: from localhost.localdomain (97-113-13-231.tukw.qwest.net. [97.113.13.231]) by smtp.gmail.com with ESMTPSA id u3sm238151pfn.29.2019.05.13.17.05.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 May 2019 17:05:44 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Mon, 13 May 2019 17:05:11 -0700 Message-Id: <20190514000540.4313-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190514000540.4313-1-richard.henderson@linaro.org> References: <20190514000540.4313-1-richard.henderson@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::634 Subject: [Qemu-devel] [PULL 02/31] tcg: Do not recreate INDEX_op_neg_vec unless supported X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linux.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Use tcg_can_emit_vec_op instead of just TCG_TARGET_HAS_neg_vec, so that we check the type and vece for the actual operation. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- tcg/optimize.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) -- 2.17.1 diff --git a/tcg/optimize.c b/tcg/optimize.c index 5150c38a25..24faa06260 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -734,9 +734,13 @@ void tcg_optimize(TCGContext *s) } else if (opc == INDEX_op_sub_i64) { neg_op = INDEX_op_neg_i64; have_neg = TCG_TARGET_HAS_neg_i64; - } else { + } else if (TCG_TARGET_HAS_neg_vec) { + TCGType type = TCGOP_VECL(op) + TCG_TYPE_V64; + unsigned vece = TCGOP_VECE(op); neg_op = INDEX_op_neg_vec; - have_neg = TCG_TARGET_HAS_neg_vec; + have_neg = tcg_can_emit_vec_op(neg_op, type, vece) > 0; + } else { + break; } if (!have_neg) { break;