From patchwork Tue May 14 15:52:57 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 164221 Delivered-To: patch@linaro.org Received: by 2002:a92:9e1a:0:0:0:0:0 with SMTP id q26csp2798819ili; Tue, 14 May 2019 09:00:19 -0700 (PDT) X-Google-Smtp-Source: APXvYqxXesxnBASt03IGOfJGBHKeNd9Ty61ScQGY4S+fzZT4ZlcaAg2TgBEesB0tLUMZSoHR8FWy X-Received: by 2002:a17:906:9390:: with SMTP id l16mr25950571ejx.57.1557849619331; Tue, 14 May 2019 09:00:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557849619; cv=none; d=google.com; s=arc-20160816; b=Qyk/wQ60rWCnif32KrIW8ISP5tj+Caex/cXrgfpBfy98oGXhWYnAgBtAMYImwyRwjT Y8be5wjAX4gPIJuWCTgtGwK4wV4EzYrefKfl5gM2tw6fJTwxRlXkCzrvOPy6P4gWjyH7 oPhIfdBzg1RwylTYfP4WNpZV7rYxvIKLgLLeoX5nkbi7k9dLWxSC32/hxZe2CVlGn44D b5vooGmtq7dhE9/4grHr5Hw9S2//x21/ipl+66Vm4isweCcvh9L78NjZP00zD+nDdScP Ia1+U+XStt/GOckBPXRi+7nZBBMN8cRmTzJqoxD2l962RMl8WDxro6cbV1+MLLYuhMNu hd1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=uRA15QcYpp84VA9k9wsWlnaKx7a1xt3gupbkmncewJA=; b=M/gDl5CocIkZV+7gs4iASUQ4v1uJy8UqBYfi5/J4ovrX7nrog04hr1BvO9UYxCxIMU Ook1yITEt8xlAvF7I9m96UGDXO9EcKajJbO5OY3J+2X2SSFbIUZsy6/LTlPJze5OeK8k 59PQ/JAeDMxt/HIVGUpvw7XMXeSo+j7EyFVrnwQdR1oi13TdRFaaJmo40wEN9+NUltjg mLqpNL/mi8Rvw6tUPBVvo21hKhnmT02ghN7+nvBN3Jhqy0y/Lrv6X3Q0FRMcKOlgSTBF beayrLvTZtqRv5ZTZdkCBtWhfMOmmjQatiOEDPuHJRyQBYzzWeoT5ZDqMsPYNJZqrds4 VPsA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=QrqjMzK0; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id k23si857238edd.342.2019.05.14.09.00.19 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 14 May 2019 09:00:19 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=QrqjMzK0; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:50312 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQZqk-0003C9-6o for patch@linaro.org; Tue, 14 May 2019 12:00:18 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60419) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQZjq-0004nI-HP for qemu-devel@nongnu.org; Tue, 14 May 2019 11:53:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hQZjp-0006HR-90 for qemu-devel@nongnu.org; Tue, 14 May 2019 11:53:10 -0400 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:37625) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hQZjp-0006EF-2N for qemu-devel@nongnu.org; Tue, 14 May 2019 11:53:09 -0400 Received: by mail-wm1-x341.google.com with SMTP id 7so3349126wmo.2 for ; Tue, 14 May 2019 08:53:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=uRA15QcYpp84VA9k9wsWlnaKx7a1xt3gupbkmncewJA=; b=QrqjMzK05AStmW3oCrlklHRx6CfYVHGsp13bG9cRguuv9tbuIa/0+nEU4Wty82SXVm vjABYWIxmyMSqI4vNNqm9pzZQ/l+qrK7nFBscmVe8vMrrAgU2QdMdJrBX4sLr3T8M+WI sC7/HbYny2VpQoNgJC2ONGjdgYd5NabnX2W9msnuj8xqxvJ+SSuC+Mqi1Tnc/8PUwmUL nqZiwOtHvCTtNDUO/K1CWh9BdMMvhtv3B5nJDCV6v7qiOl7oF+JMVP8frg5xD2F+lJrj wWvriOy4rKg58n4Rjs41XcyiB0V9/aygEC6TIb2bCAS+k7n8M94cL4h78XfKW2Nl5i7B rcLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=uRA15QcYpp84VA9k9wsWlnaKx7a1xt3gupbkmncewJA=; b=R234V+2bAz5cLZx06W0ZGgzLBMY2NErTQPUEfzhskndzZMLPBRGeUN7J+M3yZzFN0l qIoAuH9kL+hJCzCqIa+NP72EH8Vur/RAa8lewrEkMuvYvW7Bx0N36d6EJEV5GDJlEyw2 iBk1gEwSM4IgykSt8cnpTYqxHgvI4SduuM3pLWGUGBDi5hg7GBpxMTphu0tOzs6Hcydu aJBEFJ3nX1RrFKuiIvBv5LT89yyluSPe2HCo2qy88kK/8LxkNA/cejMGkRrT2n5hMoL8 apU8TM6R7Qsgh/1/Fp4KPkzWXcCOo31vARr2tMfjsvDcTbWiEeTWPeuvH8sEswKbeLR0 0scg== X-Gm-Message-State: APjAAAWiid5h5kgJW0qkwKNi4essITxAKRGkoV1dZxjFK9bGJMkJrTcV kEdsqVOkFsRikZUHmPPHvXxTaA== X-Received: by 2002:a1c:4406:: with SMTP id r6mr19995002wma.130.1557849188006; Tue, 14 May 2019 08:53:08 -0700 (PDT) Received: from zen.linaroharston ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id w18sm7054926wru.15.2019.05.14.08.53.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 14 May 2019 08:53:05 -0700 (PDT) Received: from zen.linaroharston. (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id A38941FF96; Tue, 14 May 2019 16:53:02 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Tue, 14 May 2019 16:52:57 +0100 Message-Id: <20190514155301.16123-8-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190514155301.16123-1-alex.bennee@linaro.org> References: <20190514155301.16123-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::341 Subject: [Qemu-devel] [RFC PATCH 07/11] target/arm: add LOG_UNIMP messages to arm-semi X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , qemu-arm@nongnu.org, =?utf-8?q?Alex_Benn=C3=A9e?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Clean-up our unimplemented bits with a proper message. Signed-off-by: Alex Bennée --- target/arm/arm-semi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- 2.20.1 Reviewed-by: Philippe Mathieu-Daudé diff --git a/target/arm/arm-semi.c b/target/arm/arm-semi.c index 253c66b172a..a3bbef18ef7 100644 --- a/target/arm/arm-semi.c +++ b/target/arm/arm-semi.c @@ -28,6 +28,7 @@ #include "cpu.h" #include "hw/semihosting/semihost.h" #include "hw/semihosting/console.h" +#include "qemu/log.h" #ifdef CONFIG_USER_ONLY #include "qemu.h" @@ -366,7 +367,7 @@ target_ulong do_arm_semihosting(CPUARMState *env) return len - ret; } case TARGET_SYS_READC: - /* XXX: Read from debug console. Not implemented. */ + qemu_log_mask(LOG_UNIMP, "%s: SYS_READC not implemented", __func__); return 0; case TARGET_SYS_ISTTY: GET_ARG(0); @@ -400,7 +401,7 @@ target_ulong do_arm_semihosting(CPUARMState *env) return buf.st_size; } case TARGET_SYS_TMPNAM: - /* XXX: Not implemented. */ + qemu_log_mask(LOG_UNIMP, "%s: SYS_TMPNAM not implemented", __func__); return -1; case TARGET_SYS_REMOVE: GET_ARG(0);