From patchwork Fri May 17 02:39:17 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 164372 Delivered-To: patch@linaro.org Received: by 2002:a92:9e1a:0:0:0:0:0 with SMTP id q26csp1607874ili; Thu, 16 May 2019 19:52:09 -0700 (PDT) X-Google-Smtp-Source: APXvYqyaDDGfC/77yoO7fgyCc+pPC6jyuQbW6SpE1UhLZCCQwMXRq5a1dUNdMsGBo+R+59iQ22gI X-Received: by 2002:a50:aad9:: with SMTP id r25mr53203356edc.266.1558061528987; Thu, 16 May 2019 19:52:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558061528; cv=none; d=google.com; s=arc-20160816; b=eGG3oFfEY7YVow4gf5Xra+6r+qB41X3NMKolu0JwRpL/INSoPQoSkrBkQ3Ca7kImEm NuvP8ayZMGDo1SNg52G8NmjjiVYv8WRWCUJpJTsw82jCmp5ckNKDhxymFnvWWud81voH LW3D5USlTXmeqqqvvxHZyUpQh0gA99ccA7Y5/8494Ku0a3AuElVqKljTfeyWqreDU0Kh DTMGhHe8t30NbXqeDswqIJVdJWeSe8cTqbJ6nwjPERvfWiPx5W2e02OrUHGCiVQaCWh6 5JIanKkBv+DRsAolOMX+zXjwzzHiRN4ydzAh835OfCkAYy+7O3m0g9os2P1OWuxzxopJ KClg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=zHL5/dOLNq3cxnvhnBPOBazkJM0pmZq+fc+P6w38V4s=; b=b85aQJpFA45MMLyFQ0MfCtaY5pj53l2s48BlxbcpPXIH2/brGmfEtmHHnSb+MPV+MM Jh5I6Gc2y0ClIjiGubgxVLAZ8bLdqIHELc/2DwbwYUtB2bzxb66Ergt+QX+nZ0fS2st2 4AsKtCyAP7f9aRK1tEPfMROtS2moGaiEGE0YJna45cuoNj7wXNo9CgLnVZfPNRdzI/b7 XLuTG+eoOhRhJs+o6BubKOg34O0EDXhzrphNaJTO6pz9HLPULyNocy1H2eX8iscvtz/x 0qX9sTLNEp4sxvjT2ayqbEsod9hOu9oWRV6yjCs4+aMLZznKuW6pfkAn0wgtahCGz7DP POXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=NgF8HzPq; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id jt10si1175367ejb.292.2019.05.16.19.52.08 for (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 16 May 2019 19:52:08 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=NgF8HzPq; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:40281 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRSye-0007EG-1J for patch@linaro.org; Thu, 16 May 2019 22:52:08 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39158) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRSmw-0005mq-2i for qemu-devel@nongnu.org; Thu, 16 May 2019 22:40:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hRSmq-0002E5-Ne for qemu-devel@nongnu.org; Thu, 16 May 2019 22:39:59 -0400 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]:34774) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hRSmk-0002B0-CD for qemu-devel@nongnu.org; Thu, 16 May 2019 22:39:51 -0400 Received: by mail-pg1-x541.google.com with SMTP id c13so2528493pgt.1 for ; Thu, 16 May 2019 19:39:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=zHL5/dOLNq3cxnvhnBPOBazkJM0pmZq+fc+P6w38V4s=; b=NgF8HzPq3hUpPgukWYKOVmFXN7jjuXkq4n3g/lazes+V4szF+voHzAT+KTPT5vXVKR gtUOk5Zar0zJYvQovL/cb9W2qpz6IRGy5jU+Oc9l4SebLiXPulN0SAp/Nz8CZMNEj25i H3uHDxz04GXlulOuokRYThNvOTunXSZCFjZysL7wfZOwMlRrtzKh2/aJFC02H0SxNpTs jTbWV6pAX2xWeG/FdLqT6rkbwyhIWj0My6uuc5WXBqrs7akU1f6eIqrmE8wUN42kJWuN yCwcALfwi3x5WAiU11oET3eNMY04m7Ril7vdECWMkdeDMxaYuVdPxrXIongNBgNR5SFJ UBJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=zHL5/dOLNq3cxnvhnBPOBazkJM0pmZq+fc+P6w38V4s=; b=s3bqSUyLSR9ooSRhTtKFkZg4qUIRp8WjOeczpvMxIrtzqj7EUQjBuidONG30Ud3CmR q6k+gCE1nE0tpOW2GwyAWkMEsIInG2fqzC0aqBG46wd8mSNfjFL4tDynjgS7pZg36BDa 8T6AIjDcQcJ9BjqnofvzyG6o17PLMKDjLrCyXjX41ZaDM2ll+MJkmlb6KFOxMd+Nuksm Wc0JBgKs1st0FqXJq5HTS8EtoNMPHY17JqpQT8O84/MUUIt7O5tN3x/0Zs4dGf80NENF KsKahIbNoQuHUdZ1cXSprhiHJnaKqEx++Ccorxnfn3lNFoNXnhBT7W+Qlx29rFM+TVZr c3IQ== X-Gm-Message-State: APjAAAVjFdChACDE5SABIK2QpSIhpOsmI9Hg++GLmENwaydifde0UVlT /o3maBkzGnH/4ctvg0bT/g9o5cbAgXI= X-Received: by 2002:a62:a511:: with SMTP id v17mr31236498pfm.129.1558060788972; Thu, 16 May 2019 19:39:48 -0700 (PDT) Received: from localhost.localdomain (97-113-13-231.tukw.qwest.net. [97.113.13.231]) by smtp.gmail.com with ESMTPSA id w6sm6984152pge.30.2019.05.16.19.39.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 May 2019 19:39:48 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Thu, 16 May 2019 19:39:17 -0700 Message-Id: <20190517023924.1686-19-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190517023924.1686-1-richard.henderson@linaro.org> References: <20190517023924.1686-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::541 Subject: [Qemu-devel] [PATCH v8 18/25] hw/misc/nrf51_rng: Use qemu_guest_getrandom_nofail X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, berrange@redhat.com, armbru@redhat.com Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The random number is intended for use by the guest. As such, we should honor the -seed argument for reproducibility. Use the *_nofail routine instead of error_abort directly. Reviewed-by: Laurent Vivier Reviewed-by: Joel Stanley Signed-off-by: Richard Henderson --- hw/misc/nrf51_rng.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.17.1 diff --git a/hw/misc/nrf51_rng.c b/hw/misc/nrf51_rng.c index d188f044f4..3400e90a9b 100644 --- a/hw/misc/nrf51_rng.c +++ b/hw/misc/nrf51_rng.c @@ -14,7 +14,7 @@ #include "qapi/error.h" #include "hw/arm/nrf51.h" #include "hw/misc/nrf51_rng.h" -#include "crypto/random.h" +#include "qemu/guest-random.h" static void update_irq(NRF51RNGState *s) { @@ -145,7 +145,7 @@ static void nrf51_rng_timer_expire(void *opaque) { NRF51RNGState *s = NRF51_RNG(opaque); - qcrypto_random_bytes(&s->value, 1, &error_abort); + qemu_guest_getrandom_nofail(&s->value, 1); s->event_valrdy = 1; qemu_set_irq(s->eep_valrdy, 1);