From patchwork Fri May 17 02:39:04 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 164362 Delivered-To: patch@linaro.org Received: by 2002:a92:9e1a:0:0:0:0:0 with SMTP id q26csp1603117ili; Thu, 16 May 2019 19:45:34 -0700 (PDT) X-Google-Smtp-Source: APXvYqxr3cHx9r/XFmK86a9FskDCi7as55M2R+jobJQTez4eom55lvBYcYd77t1zxi8xYi0RH2GF X-Received: by 2002:a50:b78b:: with SMTP id h11mr53612937ede.134.1558061134875; Thu, 16 May 2019 19:45:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558061134; cv=none; d=google.com; s=arc-20160816; b=kwJIMeOzpL401wavPvY+occWhksjN7rIB6JFhnvta829qwtWrbwI1w0mgJHmuaJPmg Wjq6CrfwiJGLFcUhzqEU0LF6afzAjS7H05R7QIY3W0hRNtD+KUUyxeDYtfEjgAQuINBD w2Z9pN94jUETmF99fNPVYaq9lh2em575GJXTDQ47xhRvtzOrjtgODzLwuGabxsloXZ/Q xHnN4ddAYO4Hvamr2VBcT/VbIy/UIpHvXYVFJdeXmd76rFHpqp6BOGar4Qe7ZbDw/uQ+ +rBARUewcHF5/TprZq+c1XJZvmDiF8PaXtIHoIMUMQCe5WK9mc/JYNLA5udKt3luIN7d zL7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=p/AR+QB1/uCfqQ+ytrGBnYCYqwPtnBM3b7CBgieQEw0=; b=kQfPao0jE9CvmLx1Iuv3PNHEP+k6w0zqwmM9LCeEB3YiJ5fd6gTJhhikyepgqw+IcH v6pTVs6QvwL0e/Hy3+xT7Z9SQYK3yMFVz2TsjAHO6TTNQr1jX9dMRc4Pec1Blulk0JmN 5MaIqn+NbgBQ8I4EQtLRuxaXyTclhAdpheFnGny/wLwpB22bl974nze8ulJL15IPLiIg d9uXRjHE43l8MKmVrM0+9sML1kLF/5HVNo51kpJMXKXRqhRFGFLrNEKyNGckYnJY4d+/ EqivUPHJeR5VHHZc1pB5k5y/JfCw+2elnSdCxXqpKKoRqWzoRmJdUyZURnQYBQrun1ub 6g6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=z6N5mSF+; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id e11si297744ede.248.2019.05.16.19.45.34 for (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 16 May 2019 19:45:34 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=z6N5mSF+; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:40192 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRSsH-0002CF-OK for patch@linaro.org; Thu, 16 May 2019 22:45:33 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38984) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRSmV-0005Ot-IO for qemu-devel@nongnu.org; Thu, 16 May 2019 22:39:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hRSmU-00021s-Lq for qemu-devel@nongnu.org; Thu, 16 May 2019 22:39:35 -0400 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]:39715) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hRSmU-000210-GB for qemu-devel@nongnu.org; Thu, 16 May 2019 22:39:34 -0400 Received: by mail-pf1-x443.google.com with SMTP id z26so2872281pfg.6 for ; Thu, 16 May 2019 19:39:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=p/AR+QB1/uCfqQ+ytrGBnYCYqwPtnBM3b7CBgieQEw0=; b=z6N5mSF+S/c66TXWfJZUlO0YBvfkWd8E8uyNzbDhFBxwmx1sse58qhUM3qDbffp9Lp oBUysDFc7IrgR1/vbIKHWozE1CTLaJTghD6fr+Hw13LxWVTPAcu4fIljfF3PcrrieeMo G8KNUQtQekXGvIYIJ0rqxXir4BKW4KUQsyj85B/qtGtXAZGegYBnsPqWYM1oFGS0iI+9 uoiDwLjilM6IRf6Aa+49hFbsTkAckkJtV/O2s8ft6AAGL03JH5uCClI9rYhg4HNPy43j SMVwnxrtcG7PcWLxS6WW7RAgw/pgIkdMQZMTjsFRo9yIZ+zZZFq+6oGZ5z6f/qx78hEO ddMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=p/AR+QB1/uCfqQ+ytrGBnYCYqwPtnBM3b7CBgieQEw0=; b=FMkvr75TVNkI/+LYUbl4NH1fRZy6ReAYB0Im+JPbicFv5jBChXKSmrinwdvZtbD1G8 4q6es5F6VapCm7xiwicSifTNitUhDwx7p1YasRy7Sc8h44x+bsBB3AQWQHOleqLoX9Lr ugMb/7/O6BM1xmQKetSwI5kJOebSf9dX+x+KxIRy6cRFCwYZaLjKq7KY1yXFd5jTkicP 6D8P6nOBPTD2zr70ZJSmi2T8wYHEGWm3iL6V7/p4mkkj40QO7jXMFSQwwX8sA+REPIdj O/kULI3XoUnw6RWO0y3dYdPlg6xhqPYKIHUaPoWY8YLa6BRu6zplqIgFj7LktNg+QO19 mCMg== X-Gm-Message-State: APjAAAUmrZFuqqv2VQ6B5tybG/AP51CzMLahuyIDazCZPly1HBVDAAxa 3uO6l0JtETeWUwtF9Zgl2RiRIpScJUk= X-Received: by 2002:a63:fa4a:: with SMTP id g10mr54222747pgk.147.1558060773113; Thu, 16 May 2019 19:39:33 -0700 (PDT) Received: from localhost.localdomain (97-113-13-231.tukw.qwest.net. [97.113.13.231]) by smtp.gmail.com with ESMTPSA id w6sm6984152pge.30.2019.05.16.19.39.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 May 2019 19:39:32 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Thu, 16 May 2019 19:39:04 -0700 Message-Id: <20190517023924.1686-6-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190517023924.1686-1-richard.henderson@linaro.org> References: <20190517023924.1686-1-richard.henderson@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::443 Subject: [Qemu-devel] [PATCH v8 05/25] crypto: Use O_CLOEXEC in qcrypto_random_init X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, berrange@redhat.com, armbru@redhat.com Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Avoids leaking the /dev/urandom fd into any child processes. Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé Signed-off-by: Richard Henderson --- crypto/random-platform.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.17.1 diff --git a/crypto/random-platform.c b/crypto/random-platform.c index 260b64564d..6df40744c7 100644 --- a/crypto/random-platform.c +++ b/crypto/random-platform.c @@ -42,9 +42,9 @@ int qcrypto_random_init(Error **errp) #else /* TBD perhaps also add support for BSD getentropy / Linux * getrandom syscalls directly */ - fd = open("/dev/urandom", O_RDONLY); + fd = open("/dev/urandom", O_RDONLY | O_CLOEXEC); if (fd == -1 && errno == ENOENT) { - fd = open("/dev/random", O_RDONLY); + fd = open("/dev/random", O_RDONLY | O_CLOEXEC); } if (fd < 0) {