From patchwork Sat May 18 19:01:50 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 164452 Delivered-To: patch@linaro.org Received: by 2002:a92:9e1a:0:0:0:0:0 with SMTP id q26csp3707971ili; Sat, 18 May 2019 12:13:04 -0700 (PDT) X-Google-Smtp-Source: APXvYqwehaQRiGzcfLO15xKBdXBYOruNcAQa59A/wqHeWk4lrRMVJJOi9z11XhqsJgtfe0rELWpC X-Received: by 2002:a50:a5fb:: with SMTP id b56mr65478813edc.262.1558206784064; Sat, 18 May 2019 12:13:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558206784; cv=none; d=google.com; s=arc-20160816; b=M/CPWtBfEiQozeCQzGBsONZNijeF9ItWbqUMUkDjnmqnJBKclpSe+rVkCQyum3/xmr BsfNd1wAPWjVRFPiRVbLvRfUEluDcLZCyo3IzPf9/2Q9x4rQWWyEcr/l9u4h3vDQcWYT N21dLbYi/ZI0bkmwHS0nXJM3qg4OWdgig8rgAilQ6IPGSjQ1a9X0hzJg/N9wafIJq/vw DzQ/+FPGQUt6BiI87zJgBsS/kP8FI8CiR8a9dAV8Afd5y0VZ2iqsT3Kboqk7Z63LODsM b2lrlVzF+PBhhsZ4EI4l+xRvyJdB5U2b4keWlZwn9xSSLJ1HSM7D0kPe6pNbkbQM6szS +bLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=cyPCzZg9DUKeW2pqf+eu++K5/1I4IivLKFA9dQuPgvg=; b=z1Y2lJco6mu1TCmU015BcKB73GpkOAjOJRA1XzAihvUXmao2rwAZxnNwF+YR4Vz//A XJryjW+M1hH1Y9xnXWv77FK0v/iKhObkKPmcW60V2sDKiLN+bnAy6UTNqGgyvOuxro3n PCndF0l6y7F6+GhEd5CiF3722RnajvsA2AqkkwtNDutgHkgrG/6vXKQKRWZ0IUqmJFKX pCOfq7VFAay4aasZWKOITBPmjgsmyvT3tqs41ovAh+OHiJaJPcNUvkBr2myNOZKGKJZS aCVVtUPAcXc0blts7gf206EZyAU/z41joIGtPa1a89aMfvYt4z49vGLkuOFEwjQViilm tgZg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=tbQFSHmv; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id t49si8850014edd.121.2019.05.18.12.13.03 for (version=TLS1 cipher=AES128-SHA bits=128/128); Sat, 18 May 2019 12:13:04 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=tbQFSHmv; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:37689 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hS4lS-0001vv-Va for patch@linaro.org; Sat, 18 May 2019 15:13:03 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59195) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hS4dP-0002qF-Kt for qemu-devel@nongnu.org; Sat, 18 May 2019 15:04:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hS4az-0002h8-3W for qemu-devel@nongnu.org; Sat, 18 May 2019 15:02:14 -0400 Received: from mail-pg1-x542.google.com ([2607:f8b0:4864:20::542]:40197) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hS4ay-0002gB-UF for qemu-devel@nongnu.org; Sat, 18 May 2019 15:02:13 -0400 Received: by mail-pg1-x542.google.com with SMTP id d30so4826165pgm.7 for ; Sat, 18 May 2019 12:02:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references; bh=cyPCzZg9DUKeW2pqf+eu++K5/1I4IivLKFA9dQuPgvg=; b=tbQFSHmv+dDsabC/U32Pcoi0BFI9mPCug1jfNkNmSBElKKsAGb7e+447Idhz2zljiv EvxsGRRqscjDRKmwPGa7LgLIl3pJLbsVVRqxEYSLyISJMmnuiDnXdDXk6sniXz4Xezcg sXaf8dWQXfN8oncx0MqCvtR4Xb/BhzCHr673aFGaqGWCYoAIeJNtOdlOv+XOFkkOMmvR PyOmAJ8OPzw2eo6AtcL7fZggS/7qemeDrFRu0FqZ98ehzMHdhFEphY8loBtcmrg+Zi8x YajK9+GBw2mlkHvMlBnqOQJrZEFJN3AZCcBei/Rcs6EEp/b7Z09OdYOSRRp4hFMKCXzh jUug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=cyPCzZg9DUKeW2pqf+eu++K5/1I4IivLKFA9dQuPgvg=; b=Ste4+FlI4P0/L/9vhdiADB2CnRM4skyGMfRpJI0B31FFdVP91Ej0hGbEVpgL3i3H53 AtfjpMtR9yuLj0biMor3gzHyY3Lqdyvm3zt9zczq0iD7hkjBT6V1p6AauRa8HzABCqEB I+9BsuNSv/SNY3tTdKSBing3K0bGIpFGuMj1SzoVeiGRg8Y2rVNb397pUxY17Kh6xDWk VuWFllfGtNEhvEnt1GGDUdpM0sit4yH1puYNKSMU5wZvsfSFeraqNolx/Pna/O1rufY+ Q4LlpjMDK7BQwGiVtSrJvMpPEVkTCsy8NvvXpnYp68AViEiipFll5p+OFc+f8Fdek/ho CdyA== X-Gm-Message-State: APjAAAWhYXtdPqo+hpCFZttb4JKiV5n6rkBethiyRnJO/Y5Ysj+lYeiP hjBvgSdiLPw+Sr1GFgllFP0FAMvTI4o= X-Received: by 2002:a63:6907:: with SMTP id e7mr22562145pgc.209.1558206131801; Sat, 18 May 2019 12:02:11 -0700 (PDT) Received: from localhost.localdomain (97-113-13-231.tukw.qwest.net. [97.113.13.231]) by smtp.gmail.com with ESMTPSA id m9sm2751274pgd.23.2019.05.18.12.02.10 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 18 May 2019 12:02:11 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Sat, 18 May 2019 12:01:50 -0700 Message-Id: <20190518190157.21255-10-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190518190157.21255-1-richard.henderson@linaro.org> References: <20190518190157.21255-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::542 Subject: [Qemu-devel] [PATCH 09/16] tcg/i386: Remove expansion for missing minmax X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" This is now handled by code within tcg-op-vec.c. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.inc.c | 37 ------------------------------------- 1 file changed, 37 deletions(-) -- 2.17.1 diff --git a/tcg/i386/tcg-target.inc.c b/tcg/i386/tcg-target.inc.c index ffcafb1e14..569a2c2120 100644 --- a/tcg/i386/tcg-target.inc.c +++ b/tcg/i386/tcg-target.inc.c @@ -3297,7 +3297,6 @@ int tcg_can_emit_vec_op(TCGOpcode opc, TCGType type, unsigned vece) case INDEX_op_smax_vec: case INDEX_op_umin_vec: case INDEX_op_umax_vec: - return vece <= MO_32 ? 1 : -1; case INDEX_op_abs_vec: return vece <= MO_32; @@ -3551,25 +3550,6 @@ static void expand_vec_cmpsel(TCGType type, unsigned vece, TCGv_vec v0, tcg_temp_free_vec(t); } -static void expand_vec_minmax(TCGType type, unsigned vece, - TCGCond cond, bool min, - TCGv_vec v0, TCGv_vec v1, TCGv_vec v2) -{ - TCGv_vec t1 = tcg_temp_new_vec(type); - - tcg_debug_assert(vece == MO_64); - - tcg_gen_cmp_vec(cond, vece, t1, v1, v2); - if (min) { - TCGv_vec t2; - t2 = v1, v1 = v2, v2 = t2; - } - vec_gen_4(INDEX_op_x86_vpblendvb_vec, type, vece, - tcgv_vec_arg(v0), tcgv_vec_arg(v1), - tcgv_vec_arg(v2), tcgv_vec_arg(t1)); - tcg_temp_free_vec(t1); -} - void tcg_expand_vec_op(TCGOpcode opc, TCGType type, unsigned vece, TCGArg a0, ...) { @@ -3609,23 +3589,6 @@ void tcg_expand_vec_op(TCGOpcode opc, TCGType type, unsigned vece, expand_vec_cmpsel(type, vece, v0, v1, v2, v3, v4, va_arg(va, TCGArg)); break; - case INDEX_op_smin_vec: - v2 = temp_tcgv_vec(arg_temp(a2)); - expand_vec_minmax(type, vece, TCG_COND_GT, true, v0, v1, v2); - break; - case INDEX_op_smax_vec: - v2 = temp_tcgv_vec(arg_temp(a2)); - expand_vec_minmax(type, vece, TCG_COND_GT, false, v0, v1, v2); - break; - case INDEX_op_umin_vec: - v2 = temp_tcgv_vec(arg_temp(a2)); - expand_vec_minmax(type, vece, TCG_COND_GTU, true, v0, v1, v2); - break; - case INDEX_op_umax_vec: - v2 = temp_tcgv_vec(arg_temp(a2)); - expand_vec_minmax(type, vece, TCG_COND_GTU, false, v0, v1, v2); - break; - default: break; }