| Message ID | 20190523150803.31504-4-richard.henderson@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | target/rx: Improvements to disassembly | expand |
On Fri, 24 May 2019 00:08:00 +0900, Richard Henderson wrote: > > Note that the ld == 3 case handled by prt_ldmi is decoded as > XCHG_rr and cannot appear here. > > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> Reviewed-by: Yoshinori Sato <ysato@users.sourceforge.jp> > --- > target/rx/disas.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/target/rx/disas.c b/target/rx/disas.c > index 515b365528..db10385fd0 100644 > --- a/target/rx/disas.c > +++ b/target/rx/disas.c > @@ -366,13 +366,7 @@ static bool trans_XCHG_rr(DisasContext *ctx, arg_XCHG_rr *a) > /* xchg dsp[rs].<mi>,rd */ > static bool trans_XCHG_mr(DisasContext *ctx, arg_XCHG_mr *a) > { > - static const char msize[][4] = { > - "b", "w", "l", "ub", "uw", > - }; > - char dsp[8]; > - > - rx_index_addr(ctx, dsp, a->ld, a->mi); > - prt("xchg\t%s[r%d].%s, r%d", dsp, a->rs, msize[a->mi], a->rd); > + prt_ldmi(ctx, "xchg", a->ld, a->mi, a->rs, a->rd); > return true; > } > > -- > 2.17.1 >
diff --git a/target/rx/disas.c b/target/rx/disas.c index 515b365528..db10385fd0 100644 --- a/target/rx/disas.c +++ b/target/rx/disas.c @@ -366,13 +366,7 @@ static bool trans_XCHG_rr(DisasContext *ctx, arg_XCHG_rr *a) /* xchg dsp[rs].<mi>,rd */ static bool trans_XCHG_mr(DisasContext *ctx, arg_XCHG_mr *a) { - static const char msize[][4] = { - "b", "w", "l", "ub", "uw", - }; - char dsp[8]; - - rx_index_addr(ctx, dsp, a->ld, a->mi); - prt("xchg\t%s[r%d].%s, r%d", dsp, a->rs, msize[a->mi], a->rd); + prt_ldmi(ctx, "xchg", a->ld, a->mi, a->rs, a->rd); return true; }
Note that the ld == 3 case handled by prt_ldmi is decoded as XCHG_rr and cannot appear here. Signed-off-by: Richard Henderson <richard.henderson@linaro.org> --- target/rx/disas.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) -- 2.17.1