From patchwork Fri Jun 7 09:11:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yoshinori Sato X-Patchwork-Id: 166090 Delivered-To: patch@linaro.org Received: by 2002:a92:9e1a:0:0:0:0:0 with SMTP id q26csp392718ili; Fri, 7 Jun 2019 02:22:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqyjBo8nM8Hxb286xbI+x6aBJjLVh3rxREAW+bi+B09Z6MqHvRjR2h6QPwEFu/5Wc79sCqwL X-Received: by 2002:a37:a86:: with SMTP id 128mr23248181qkk.169.1559899365091; Fri, 07 Jun 2019 02:22:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559899365; cv=none; d=google.com; s=arc-20160816; b=Zqu4BTtRdZGpa5hNzm9Mmhcf5pAcpnP2rbW4EpLfb7TgHwcnKUAtmtIVR5fsH14D4I Yo3NqqwMUQcPgnA5Dw9AzwXj6UQYzEGqz1kKmY+9LJeGLDAt3Vxl6ymcYDM9bPD49vxJ mCjVqZoV8UY8IVHl5K5cZSmTlrsclZFkcCPhzFh9pyf6Agd5bEZM5zxBaDmKvHOgXd4s 98TR2fYYcO14JC1pVggvotmNrhSn2yQF74LpF15xXw9aEinI19EcK/JFZvHBdQKzAbyG KXGIqLmoZkn57JDjANj6JmzQgXEjSXoERdam9O0DPxiGLV4JXLqo4U0sDoHs0XiS208t 90qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from; bh=8SKps57bKQ5Zr7NmncoGCauYMVVwE0Ljvsz5DfOK444=; b=ZJ8rkCUKMT+iB+aoYi3DX4+gmlC4ZlxVIUuaUmZtcWO7O+bgU+zIqI80XAVC6vtg2b WrvovkU3vLrXvE+m2j+38Ng1xBXALiwNPATnrFUFbqnaexU5Pw667x+gLrHpweqffDQ3 gtyGeWCaXcO8HsNQNSOmPsRsDo8z11AF4E3BylIvK8OXGW4UbLDNvjujv+EZKxS2uM0X KR9BL66o57D4BdGi3UR5sFv4xejfxgQfz7f3lHlRxc+Pm5U5PRhSqBdgF6xaibDO6c3n NwX0bB4cAVwV2C77KaDgj5smppLMSIy/E1+3vSOkTRDh8c5v14+K98tzzQ5vEqvqpMx5 w0Jg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.47 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.47]) by mx.google.com with ESMTPS id z128si350489qke.46.2019.06.07.02.22.45 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 07 Jun 2019 02:22:45 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.47 as permitted sender) client-ip=209.51.188.47; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.47 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1]:47428 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZB5A-00083L-Lw for patch@linaro.org; Fri, 07 Jun 2019 05:22:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41420) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZAuT-0000sM-Cu for qemu-devel@nongnu.org; Fri, 07 Jun 2019 05:11:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hZAuP-0002w4-9A for qemu-devel@nongnu.org; Fri, 07 Jun 2019 05:11:41 -0400 Received: from mail02.asahi-net.or.jp ([202.224.55.14]:41550) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hZAuO-0002r0-QV for qemu-devel@nongnu.org; Fri, 07 Jun 2019 05:11:37 -0400 Received: from h61-195-96-97.vps.ablenet.jp (h61-195-96-97.ablenetvps.ne.jp [61.195.96.97]) (Authenticated sender: PQ4Y-STU) by mail02.asahi-net.or.jp (Postfix) with ESMTPA id BE45E4180B; Fri, 7 Jun 2019 18:11:31 +0900 (JST) Received: from yo-satoh-debian.localdomain (ZM005235.ppp.dion.ne.jp [222.8.5.235]) by h61-195-96-97.vps.ablenet.jp (Postfix) with ESMTPSA id 778A8240086; Fri, 7 Jun 2019 18:11:31 +0900 (JST) From: Yoshinori Sato To: qemu-devel@nongnu.org Date: Fri, 7 Jun 2019 18:11:12 +0900 Message-Id: <20190607091116.49044-21-ysato@users.sourceforge.jp> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190607091116.49044-1-ysato@users.sourceforge.jp> References: <20190607091116.49044-1-ysato@users.sourceforge.jp> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 202.224.55.14 Subject: [Qemu-devel] [PATCH v17 20/24] target/rx: Use prt_ldmi for XCHG_mr disassembly X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, Richard Henderson , Yoshinori Sato , philmd@redhat.com Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson Note that the ld == 3 case handled by prt_ldmi is decoded as XCHG_rr and cannot appear here. Reviewed-by: Yoshinori Sato Signed-off-by: Richard Henderson Signed-off-by: Yoshinori Sato --- target/rx/disas.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) -- 2.11.0 Reviewed-by: Philippe Mathieu-Daudé diff --git a/target/rx/disas.c b/target/rx/disas.c index 515b365528..db10385fd0 100644 --- a/target/rx/disas.c +++ b/target/rx/disas.c @@ -366,13 +366,7 @@ static bool trans_XCHG_rr(DisasContext *ctx, arg_XCHG_rr *a) /* xchg dsp[rs].,rd */ static bool trans_XCHG_mr(DisasContext *ctx, arg_XCHG_mr *a) { - static const char msize[][4] = { - "b", "w", "l", "ub", "uw", - }; - char dsp[8]; - - rx_index_addr(ctx, dsp, a->ld, a->mi); - prt("xchg\t%s[r%d].%s, r%d", dsp, a->rs, msize[a->mi], a->rd); + prt_ldmi(ctx, "xchg", a->ld, a->mi, a->rs, a->rd); return true; }