From patchwork Fri Jun 7 09:11:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yoshinori Sato X-Patchwork-Id: 166094 Delivered-To: patch@linaro.org Received: by 2002:a92:9e1a:0:0:0:0:0 with SMTP id q26csp397466ili; Fri, 7 Jun 2019 02:28:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqw1jOrt8/k/y4DNnhfF2aQQ0+gbsrwaTQCCZFZ0S/eKd6LAecmymSN2LGu39O/TSzRjpWeD X-Received: by 2002:ac8:270e:: with SMTP id g14mr43455814qtg.65.1559899707007; Fri, 07 Jun 2019 02:28:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559899707; cv=none; d=google.com; s=arc-20160816; b=y7BbpCMSYEg7ZfevF1244TLQkr0FBo+Vfol2sbVzl80f9Ft9qnVCeiU0ZKBl6QwTHC 4iGn2Nu9h+EyEvM4oFdNd6W714v4m/9XhknOLqJWQTq40zqZFP8GYfzeQ7NYh0+YQpT0 PluyUmEcN0Tg60Tg93SFQ2YM2uMjElecGBkz+CNit7y4IsLFmfEvprKAqLF5GPzC1K49 6DslxjLuLY/IEZUuBjZTNSlajPc7SzxDOEbhD9k8Hy9Tupu2Pc89cHRuTEWPvZQ7owGC 11MxCtlMgauiqewjAWJLViEdzkpvjhCtMGzpmj7DPT//ikQdvjCHmL/lreWql3u6PlP4 8cyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from; bh=yOSdJXh/lu3G+IM5vi401H4qTl9BzDRi1axsmnV43ZI=; b=loq8u8gTNsKDBuwhKmqD02Phiwikss3W9uEp4YKKhF5i1blJjv2KqKepNGKtus6711 rZb4zE16eIynxlc0v2LJjg1Jbdinl5EsrsbSNfDXPgku0YUd9R85VnL6JwgEqDe2Jr27 dXBfO4jJWnZY/oMQgJ27s9OH0VIl/wo1rodMw4S3Pj/LSNKKdopbEi6OgAMbSRntpe1C h+2swFE4YXHXAt6abIMtd4SnZxsPwK4gRi946p7lRXxswgzSjdO7rGzpW2UXt2gfRmyW SDCFIfXNYrWOi33RbuEJ1akevgKvQ2qET4Kt+MAwZNEAbsroDZGwiwifNFZBQwNgdqA2 Jdmg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.47 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.47]) by mx.google.com with ESMTPS id x16si833861qvc.167.2019.06.07.02.28.26 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 07 Jun 2019 02:28:26 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.47 as permitted sender) client-ip=209.51.188.47; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.47 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1]:47476 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZBAg-0005DD-GQ for patch@linaro.org; Fri, 07 Jun 2019 05:28:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41426) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZAuT-0000ss-Ia for qemu-devel@nongnu.org; Fri, 07 Jun 2019 05:11:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hZAuP-0002x5-Gy for qemu-devel@nongnu.org; Fri, 07 Jun 2019 05:11:41 -0400 Received: from mail02.asahi-net.or.jp ([202.224.55.14]:41553) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hZAuO-0002rE-UZ for qemu-devel@nongnu.org; Fri, 07 Jun 2019 05:11:37 -0400 Received: from h61-195-96-97.vps.ablenet.jp (h61-195-96-97.ablenetvps.ne.jp [61.195.96.97]) (Authenticated sender: PQ4Y-STU) by mail02.asahi-net.or.jp (Postfix) with ESMTPA id 8E9F641B48; Fri, 7 Jun 2019 18:11:32 +0900 (JST) Received: from yo-satoh-debian.localdomain (ZM005235.ppp.dion.ne.jp [222.8.5.235]) by h61-195-96-97.vps.ablenet.jp (Postfix) with ESMTPSA id 4CEFD240085; Fri, 7 Jun 2019 18:11:32 +0900 (JST) From: Yoshinori Sato To: qemu-devel@nongnu.org Date: Fri, 7 Jun 2019 18:11:15 +0900 Message-Id: <20190607091116.49044-24-ysato@users.sourceforge.jp> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190607091116.49044-1-ysato@users.sourceforge.jp> References: <20190607091116.49044-1-ysato@users.sourceforge.jp> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 202.224.55.14 Subject: [Qemu-devel] [PATCH v17 23/24] target/rx: Dump bytes for each insn during disassembly X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, Richard Henderson , Yoshinori Sato , philmd@redhat.com Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson There are so many different forms of each RX instruction that it will be very useful to be able to look at the bytes to see on which path a bug may lie. Reviewed-by: Yoshinori Sato Signed-off-by: Richard Henderson Signed-off-by: Yoshinori Sato --- target/rx/disas.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) -- 2.11.0 Reviewed-by: Philippe Mathieu-Daudé diff --git a/target/rx/disas.c b/target/rx/disas.c index 5a32a87534..d73b53db44 100644 --- a/target/rx/disas.c +++ b/target/rx/disas.c @@ -102,7 +102,21 @@ static int bdsp_s(DisasContext *ctx, int d) /* Include the auto-generated decoder. */ #include "decode.inc.c" -#define prt(...) (ctx->dis->fprintf_func)((ctx->dis->stream), __VA_ARGS__) +static void dump_bytes(DisasContext *ctx) +{ + int i, len = ctx->len; + + for (i = 0; i < len; ++i) { + ctx->dis->fprintf_func(ctx->dis->stream, "%02x ", ctx->bytes[i]); + } + ctx->dis->fprintf_func(ctx->dis->stream, "%*c", (8 - i) * 3, '\t'); +} + +#define prt(...) \ + do { \ + dump_bytes(ctx); \ + ctx->dis->fprintf_func(ctx->dis->stream, __VA_ARGS__); \ + } while (0) #define RX_MEMORY_BYTE 0 #define RX_MEMORY_WORD 1