From patchwork Thu Jun 13 12:13:52 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 166614 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp695006ilk; Thu, 13 Jun 2019 05:27:25 -0700 (PDT) X-Google-Smtp-Source: APXvYqybU3HtSDL72mW/6vAlI1qU8fHK5KpbdCSv/UNS4hyX84z2MILfucxaAmAtgvfb7pgqV2t8 X-Received: by 2002:a0c:bd18:: with SMTP id m24mr3326594qvg.118.1560428845325; Thu, 13 Jun 2019 05:27:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560428845; cv=none; d=google.com; s=arc-20160816; b=G5kqZLIhBR8xtLQwugmve7+rpPXo0TBvVZWF/omagZWuZDNpky3VJZKLx73FN+eLSU 0DUMKE809jKoUsLE5giRMM9LkX/16FGPPDv/Ud+6bxEKv6pQh3OyZIiL/JkVuDiLE6+r oRHB6d53k1jgBobTzRKtRCJQ+Zavl29aQAVKH5K8WSR+xqB6jvl03UArkqnJBPIxL0fd vP0QM+HgTKTKaETcosxB5RpZJnMscXd9jPMKWqvLwMASpTKcZtwvbiZSQmngoHfDSsKM TDBaAz8PE1MMonsf0Kjlv3b4KaVBk5DSMexuJ70HA5fejJFy8Al61MJvwg0dB/HgcnFq JiVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=A6zB6s48Mdps2LC1th7zZyg8f6vSOggdH9q3F9SoDps=; b=rBAL5D3mepYaqFjrTgItmIfZHwMrnqJ5bkth4HfWPwxexxM64+cC8SeQofm+l94VcF zVHiMBi8XDX/TSvCPfS9BPsox7Ii5qmjyCkTs6XL3z86emVljpWyM4BVYXS47LO6PmcB E1scQEmkUW2oMtegZuH47nd0Gc0c+QSd2Cc2agRnD+Xse/lFm0ObtZKete0thuQczHnw WVruZDcMFMHCcy2/Kjg1TP4sdhIYaCJx3XE0WopVAaFRjtsTRvLhkGQ8k76Sq3BKz0Dl IokdCj5JS5wujQyUn8FOk28dMSghj4y27qMko6gj7DCvQ0PW3TyR1oGZ2zY8zmpC3oqP gb8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=GqddfPVK; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 53si1779500qtx.195.2019.06.13.05.27.25 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 13 Jun 2019 05:27:25 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=GqddfPVK; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:39386 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbOpA-0005KE-Sg for patch@linaro.org; Thu, 13 Jun 2019 08:27:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58811) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbOcz-0007uF-RP for qemu-devel@nongnu.org; Thu, 13 Jun 2019 08:14:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hbOcx-0003zF-Do for qemu-devel@nongnu.org; Thu, 13 Jun 2019 08:14:49 -0400 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]:32989) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hbOcv-0003wG-63 for qemu-devel@nongnu.org; Thu, 13 Jun 2019 08:14:45 -0400 Received: by mail-wr1-x431.google.com with SMTP id n9so20572366wru.0 for ; Thu, 13 Jun 2019 05:14:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=A6zB6s48Mdps2LC1th7zZyg8f6vSOggdH9q3F9SoDps=; b=GqddfPVKPAImuE+nN8zpYvXcatzOSLgJqFUAadSshC0ahGORjGzEM1fSizt+Hp629B eoN/4Wu26fgJmYlJ8ZnngfduwZOp1EKPafuiJO5uc3GxHQLwc9P9bAwCf6Da2ntuXA9V 2KAkuj4ymP9ivFVJ3PE9aw8a/EwGJTYS1NxJfyhMjR+nKttessRpBZEYOza/byEb2W4A TMogiNOLHQftGc0c5H+djmRndyVhHOu2w0ZBwuT1LOoI+fP6LQb2oppPnPKAxHJJ4BM+ DByE+Fa3b0cpnljXUbc5uJBjXZ0vA59z3881W06dFSW6aUWZ0vkMVgL5kT3MQ8CPoboK sxQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=A6zB6s48Mdps2LC1th7zZyg8f6vSOggdH9q3F9SoDps=; b=WmKeiDbm9i7n/iUNM2F+fF8WLoASW8yB9Pn/rFq7viBTJDDD+s6BDSzrW1hZHB+fvJ dAvFICnqhyHfbLLNrDXQ1NDEL0ETkPhBD6cCCOzN3VGV/u8pjDbBE/YioboHTnizbTc9 wdSHT5NUcnTP90CVSooyBbQxUPjvN9LbQMPGyAYRNtF1xU/87wx4MM89zpQSm3fB47se eJJo2Ar0hydtZRmmjTDUO7XJ1Vi2/B8xI0tt7nuoFnQOnxMAv9hXLVCIiTwbMLjjWAn7 nkJgl15bf0jZFeof1zL5pxk8fBfnvaGxthT77ObQKDC2iU+cBO2oj8k8JGZXJhI0xR2y 142A== X-Gm-Message-State: APjAAAXD5WzUmFqmERYbZpZrozlkQyeVrYV29Rij6WQwwtRFQa848f15 hhoS25zK1VO5Ry3cSmT2FTKgjoVe3x8pTw== X-Received: by 2002:adf:9cd0:: with SMTP id h16mr42664147wre.211.1560428083050; Thu, 13 Jun 2019 05:14:43 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id y6sm2010576wrp.12.2019.06.13.05.14.42 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Jun 2019 05:14:42 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Date: Thu, 13 Jun 2019 13:13:52 +0100 Message-Id: <20190613121433.5246-8-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190613121433.5246-1-peter.maydell@linaro.org> References: <20190613121433.5246-1-peter.maydell@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::431 Subject: [Qemu-devel] [PULL 07/48] decodetree: Fix comparison of Field X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson Typo comparing the sign of the field, twice, instead of also comparing the mask of the field (which itself encodes both position and length). Reported-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20190604154225.26992-1-richard.henderson@linaro.org Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Peter Maydell --- scripts/decodetree.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.1 diff --git a/scripts/decodetree.py b/scripts/decodetree.py index 81874e22cc7..d7a59d63ac3 100755 --- a/scripts/decodetree.py +++ b/scripts/decodetree.py @@ -184,7 +184,7 @@ class Field: return '{0}(insn, {1}, {2})'.format(extr, self.pos, self.len) def __eq__(self, other): - return self.sign == other.sign and self.sign == other.sign + return self.sign == other.sign and self.mask == other.mask def __ne__(self, other): return not self.__eq__(other)