From patchwork Sun Jun 16 14:28:24 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yoshinori Sato X-Patchwork-Id: 166954 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp1785338ilk; Sun, 16 Jun 2019 07:41:20 -0700 (PDT) X-Google-Smtp-Source: APXvYqz5bnVklin3ZasgTk59nFI2jV4RqWtPiT2jm56XHCLfZWkFxebPEroq2v6yncbgHYhC0r+P X-Received: by 2002:a37:a743:: with SMTP id q64mr83816777qke.236.1560696080331; Sun, 16 Jun 2019 07:41:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560696080; cv=none; d=google.com; s=arc-20160816; b=m/n5nAOKFoV6gEUyPXQyAzGC1ceCK2mE2EB0wMHYtMQzteRXeePVTTlj+ZXUiLUMWx 59Pb8mS2/5Rkq1Zhwxs+06TUrcBlZSPrpZYtiJyn1aaocgPmbVknmL5MiADSDLkYTcwo x5NZaZWnxrif/ypDZqwkC9DOQtzcUXwCVy17Qp+eSvh/Co/7K7ATfdbKTg9LSHhptnTO q0QGhKs5L54DeMnGdC5ydzofLw2m+OpWIKLs/yObro50Z51QHAJqaMViL1r7mvFXXZ8G B/fISpJUa015591j1zZ0O0urMn47UyBGBGKz3VFCYc0xP7fnPMrdQgyLqbqyr8kCjSPl Y+Iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from; bh=VNx9Ajp99J+k2CxoHG8xzhuyro4Mwnnw0aZqs91u9dM=; b=cTDZXSJgMFUnvFymuxHVYjBvhnoIn983l+NOgAFcacS3pw3OnaRLGnyp2R/zYZzRNn 8V23wWeV6DbQkbI8UMG6fUols9QmHeyd2WIEqaxn8ZWxhKalPLTUwzPO6YsXS8fQWZ3b EMFjhj8wDpAZf1wt27AZAuUbZd73iI9NTMmpJlykN2WWSLOp36gwv0EnGs9F7eL+5vuI cvTLBY88HVfiOwhnVbXwxAucHEnkmFQxoZhx0+u/RhmpnN3kwtvGKFzsLtF5w+f9ywjD MX6QyU2CCnvtAdS83fHD2E55dqOEaKNZQ4gPi9Tbm+VTzs1riPOPicbMWlsP9aW7bNuW Tp1g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d18si5347578qtj.19.2019.06.16.07.41.20 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 16 Jun 2019 07:41:20 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1]:40396 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcWLP-0006Yq-Vs for patch@linaro.org; Sun, 16 Jun 2019 10:41:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36353) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcW9X-0005KG-Qp for qemu-devel@nongnu.org; Sun, 16 Jun 2019 10:29:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hcW9W-0002Mn-Lq for qemu-devel@nongnu.org; Sun, 16 Jun 2019 10:29:03 -0400 Received: from mail01.asahi-net.or.jp ([202.224.55.13]:54570) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hcW9W-00028b-CY for qemu-devel@nongnu.org; Sun, 16 Jun 2019 10:29:02 -0400 Received: from h61-195-96-97.vps.ablenet.jp (h61-195-96-97.ablenetvps.ne.jp [61.195.96.97]) (Authenticated sender: PQ4Y-STU) by mail01.asahi-net.or.jp (Postfix) with ESMTPA id 05423125F47; Sun, 16 Jun 2019 23:28:49 +0900 (JST) Received: from yo-satoh-debian.localdomain (ZM005235.ppp.dion.ne.jp [222.8.5.235]) by h61-195-96-97.vps.ablenet.jp (Postfix) with ESMTPSA id AA596240085; Sun, 16 Jun 2019 23:28:48 +0900 (JST) From: Yoshinori Sato To: qemu-devel@nongnu.org Date: Sun, 16 Jun 2019 23:28:24 +0900 Message-Id: <20190616142836.10614-13-ysato@users.sourceforge.jp> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190616142836.10614-1-ysato@users.sourceforge.jp> References: <20190616142836.10614-1-ysato@users.sourceforge.jp> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 202.224.55.13 Subject: [Qemu-devel] [PATCH v20 12/24] target/rx: Dump bytes for each insn during disassembly X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, Richard Henderson , Yoshinori Sato , philmd@redhat.com Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson There are so many different forms of each RX instruction that it will be very useful to be able to look at the bytes to see on which path a bug may lie. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Yoshinori Sato Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49044-24-ysato@users.sourceforge.jp> Tested-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/rx/disas.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) -- 2.11.0 diff --git a/target/rx/disas.c b/target/rx/disas.c index 5a32a87534..d73b53db44 100644 --- a/target/rx/disas.c +++ b/target/rx/disas.c @@ -102,7 +102,21 @@ static int bdsp_s(DisasContext *ctx, int d) /* Include the auto-generated decoder. */ #include "decode.inc.c" -#define prt(...) (ctx->dis->fprintf_func)((ctx->dis->stream), __VA_ARGS__) +static void dump_bytes(DisasContext *ctx) +{ + int i, len = ctx->len; + + for (i = 0; i < len; ++i) { + ctx->dis->fprintf_func(ctx->dis->stream, "%02x ", ctx->bytes[i]); + } + ctx->dis->fprintf_func(ctx->dis->stream, "%*c", (8 - i) * 3, '\t'); +} + +#define prt(...) \ + do { \ + dump_bytes(ctx); \ + ctx->dis->fprintf_func(ctx->dis->stream, __VA_ARGS__); \ + } while (0) #define RX_MEMORY_BYTE 0 #define RX_MEMORY_WORD 1