From patchwork Tue Jun 18 14:10:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yoshinori Sato X-Patchwork-Id: 167153 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp4280991ilk; Tue, 18 Jun 2019 07:13:15 -0700 (PDT) X-Google-Smtp-Source: APXvYqwBkV5V/TcfrHu4hxHv7Gb2WnPNnnO6IhctotD1MMakOyHTiCiKpyHYlzKrWKw52XkKew7k X-Received: by 2002:a37:e40b:: with SMTP id y11mr18706060qkf.88.1560867195352; Tue, 18 Jun 2019 07:13:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560867195; cv=none; d=google.com; s=arc-20160816; b=qLIjUkp9GTOZtakl1YdAzl3xX3ZCZ4D2VvQVWLfGSNEKZRfoo3d/hSYRxZd2MwO7CH 4epqKyFCH6kFMBN71hwswrIuqYlgIJWX9dD4GmjhGaiJlSqjpn3+q3R9hDauXnh6zr4o 48vu9Yfo8XS9npL6UQ1DkCz8CSDzdN/xzhSrpQCq6Yi4EPHNVvk6CAKcYmXCO0L5OJWX mJxcW6k7ayBupKr6p/12gWNKyjK/YDPw9+ER3NJgCbfHWPOyzp6YZzK6LU+StN/+GWLD PsAY21kn6YEN6k6obR0awJxU6pRUqQ7W2DFxrCYIp9rVmEZOp4pZPyox1P+8NUmDlB3g B25g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from; bh=VNx9Ajp99J+k2CxoHG8xzhuyro4Mwnnw0aZqs91u9dM=; b=OTuHymixwvK+CJfIpSwAVlAHHA7JmOYLo766lr2/hCSCTdwpNUwinO9Eit3GOXkQyp vhg6zjitXxQHKGsEQ44TZo44f65FM3H13OYSpYloUsP3I7aV7vQVYwlge4sJKqdB1T02 z3isS7OjjqYBYDNJGi4WsoeUSQ9mxrRBA5HevUXc+VMLJmFW1frsxTfNd6giOEZq/1cO DvH3xA0U5Qj7bW6zf3JNqpE5ooH8gQw80Ew+w8wG6XaKgmZC+sphSZ5LWyfxb3h/+u91 miEMGrQQ9EvT6pw/eUuYWiL+W0B7FtnMQr2kZqRCiy3a67f0M0YCwCHL886KVyv6Gh0A UBWw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id p13si10318816qkj.54.2019.06.18.07.13.15 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 18 Jun 2019 07:13:15 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1]:58414 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hdErK-0004AW-Rt for patch@linaro.org; Tue, 18 Jun 2019 10:13:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60048) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hdEpl-0002sc-KT for qemu-devel@nongnu.org; Tue, 18 Jun 2019 10:11:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hdEpi-0007sM-T2 for qemu-devel@nongnu.org; Tue, 18 Jun 2019 10:11:36 -0400 Received: from mail02.asahi-net.or.jp ([202.224.55.14]:35006) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hdEpi-0007qL-9o for qemu-devel@nongnu.org; Tue, 18 Jun 2019 10:11:34 -0400 Received: from h61-195-96-97.vps.ablenet.jp (h61-195-96-97.ablenetvps.ne.jp [61.195.96.97]) (Authenticated sender: PQ4Y-STU) by mail02.asahi-net.or.jp (Postfix) with ESMTPA id 2EE7843F58; Tue, 18 Jun 2019 23:11:33 +0900 (JST) Received: from yo-satoh-debian.localdomain (ZM005235.ppp.dion.ne.jp [222.8.5.235]) by h61-195-96-97.vps.ablenet.jp (Postfix) with ESMTPSA id 9BBBF240086; Tue, 18 Jun 2019 23:11:32 +0900 (JST) From: Yoshinori Sato To: qemu-devel@nongnu.org Date: Tue, 18 Jun 2019 23:10:59 +0900 Message-Id: <20190618141118.52955-21-ysato@users.sourceforge.jp> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190618141118.52955-1-ysato@users.sourceforge.jp> References: <20190618141118.52955-1-ysato@users.sourceforge.jp> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 202.224.55.14 Subject: [Qemu-devel] [PATCH v21 11/21] target/rx: Dump bytes for each insn during disassembly X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, imammedo@redhat.com, Richard Henderson , Yoshinori Sato , philmd@redhat.com Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson There are so many different forms of each RX instruction that it will be very useful to be able to look at the bytes to see on which path a bug may lie. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Yoshinori Sato Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49044-24-ysato@users.sourceforge.jp> Tested-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/rx/disas.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) -- 2.11.0 diff --git a/target/rx/disas.c b/target/rx/disas.c index 5a32a87534..d73b53db44 100644 --- a/target/rx/disas.c +++ b/target/rx/disas.c @@ -102,7 +102,21 @@ static int bdsp_s(DisasContext *ctx, int d) /* Include the auto-generated decoder. */ #include "decode.inc.c" -#define prt(...) (ctx->dis->fprintf_func)((ctx->dis->stream), __VA_ARGS__) +static void dump_bytes(DisasContext *ctx) +{ + int i, len = ctx->len; + + for (i = 0; i < len; ++i) { + ctx->dis->fprintf_func(ctx->dis->stream, "%02x ", ctx->bytes[i]); + } + ctx->dis->fprintf_func(ctx->dis->stream, "%*c", (8 - i) * 3, '\t'); +} + +#define prt(...) \ + do { \ + dump_bytes(ctx); \ + ctx->dis->fprintf_func(ctx->dis->stream, __VA_ARGS__); \ + } while (0) #define RX_MEMORY_BYTE 0 #define RX_MEMORY_WORD 1