From patchwork Tue Jun 18 14:39:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yoshinori Sato X-Patchwork-Id: 167169 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp4366549ilk; Tue, 18 Jun 2019 08:27:11 -0700 (PDT) X-Google-Smtp-Source: APXvYqxqO7FPWEL48YhxqzEd0nUP4nhJyRI/wDyKBgMKFsNs+UIFqSOI1/XnX1/EzXH/dLPesV5m X-Received: by 2002:a37:5cc3:: with SMTP id q186mr21674134qkb.74.1560871631739; Tue, 18 Jun 2019 08:27:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560871631; cv=none; d=google.com; s=arc-20160816; b=ctil1J1/F8vp8c0Y4gDHyWe0BKvv5P6ZIGMnXdZypHoLt2f2OuvaaOEndK7D+cJksD b2bSdl9V88N7+EpngKGNqDBoGIhCYLEYw67cBaL3OL1eHGBlYIAPe7e92ebH4oNTEdql oW9KN40/YyJG9aQcQMTMeMijds2IrAlaqvbV+LXHpCBvEX3EYzTeViKCgKJLcoMvLHDo ExV8njEdzfLHoy9fh/12r4vjI/AOsHV53bziLg64NtHkNfb/nDk/i+uLXA/W43GmrL1l Mon5wtCNGgQ87qvWAoAkdEHbgaNbPCueBaGa93FD8Ek5Lji6eoI5rvsWi4NDasR6MID2 hMgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from; bh=VNx9Ajp99J+k2CxoHG8xzhuyro4Mwnnw0aZqs91u9dM=; b=r7sPboqWsb4JPvqdR/0ESCl40ejYUWWkHaYhelsFBsgX1OIG+ourvPBjaA9x6r42Pv Xp01qwQVcJENBcEO00rTDRZtJrGl+VB+dy8loeuUHwN/nh9qqK+8uklB1HGRlHsTee4z kTbMDkVAz6YWDjPA1+730ZRrxQZn1US2FYKmQPlpcDi/kx0fPyGjNgpAGcO/KA5v7yzF FqozkC/5V+WwWu9U+lvGmdcPWctl0YIRwPU4w3BdYs5aAOBaYM394lafPpjHIt8onmu4 XMYF873fD188/p0vG8KtghEsDhOMFRVSKDm6YLuS5aJFVB/mRKEIrMDfOLoEk14zBui0 026w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id n38si505200qtf.207.2019.06.18.08.27.11 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 18 Jun 2019 08:27:11 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1]:58974 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hdG0o-00018a-SF for patch@linaro.org; Tue, 18 Jun 2019 11:27:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39616) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hdFGs-0002np-L3 for qemu-devel@nongnu.org; Tue, 18 Jun 2019 10:39:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hdFGq-0000jE-MM for qemu-devel@nongnu.org; Tue, 18 Jun 2019 10:39:38 -0400 Received: from mail02.asahi-net.or.jp ([202.224.55.14]:36571) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hdFGq-0000ft-Ax for qemu-devel@nongnu.org; Tue, 18 Jun 2019 10:39:36 -0400 Received: from h61-195-96-97.vps.ablenet.jp (h61-195-96-97.ablenetvps.ne.jp [61.195.96.97]) (Authenticated sender: PQ4Y-STU) by mail02.asahi-net.or.jp (Postfix) with ESMTPA id 3F67B44042; Tue, 18 Jun 2019 23:39:34 +0900 (JST) Received: from yo-satoh-debian.localdomain (ZM005235.ppp.dion.ne.jp [222.8.5.235]) by h61-195-96-97.vps.ablenet.jp (Postfix) with ESMTPSA id EB3A5240085; Tue, 18 Jun 2019 23:39:33 +0900 (JST) From: Yoshinori Sato To: qemu-devel@nongnu.org Date: Tue, 18 Jun 2019 23:39:15 +0900 Message-Id: <20190618143923.53838-14-ysato@users.sourceforge.jp> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190618143923.53838-1-ysato@users.sourceforge.jp> References: <20190618143923.53838-1-ysato@users.sourceforge.jp> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 202.224.55.14 Subject: [Qemu-devel] [PATCH RESEND v21 13/21] target/rx: Dump bytes for each insn during disassembly X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, imammedo@redhat.com, Richard Henderson , Yoshinori Sato , philmd@redhat.com Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson There are so many different forms of each RX instruction that it will be very useful to be able to look at the bytes to see on which path a bug may lie. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Yoshinori Sato Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49044-24-ysato@users.sourceforge.jp> Tested-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/rx/disas.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) -- 2.11.0 diff --git a/target/rx/disas.c b/target/rx/disas.c index 5a32a87534..d73b53db44 100644 --- a/target/rx/disas.c +++ b/target/rx/disas.c @@ -102,7 +102,21 @@ static int bdsp_s(DisasContext *ctx, int d) /* Include the auto-generated decoder. */ #include "decode.inc.c" -#define prt(...) (ctx->dis->fprintf_func)((ctx->dis->stream), __VA_ARGS__) +static void dump_bytes(DisasContext *ctx) +{ + int i, len = ctx->len; + + for (i = 0; i < len; ++i) { + ctx->dis->fprintf_func(ctx->dis->stream, "%02x ", ctx->bytes[i]); + } + ctx->dis->fprintf_func(ctx->dis->stream, "%*c", (8 - i) * 3, '\t'); +} + +#define prt(...) \ + do { \ + dump_bytes(ctx); \ + ctx->dis->fprintf_func(ctx->dis->stream, __VA_ARGS__); \ + } while (0) #define RX_MEMORY_BYTE 0 #define RX_MEMORY_WORD 1