From patchwork Tue Jul 9 07:50:42 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 168729 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp8211383ilk; Tue, 9 Jul 2019 00:53:31 -0700 (PDT) X-Google-Smtp-Source: APXvYqyABZnnDMkNgMIcKluV8l1fbYm7rCiRFO6hrtY+Kw0dqsYWs9xA/N3uM7GcqgKUI/Z3V1It X-Received: by 2002:a50:9799:: with SMTP id e25mr22868513edb.79.1562658811758; Tue, 09 Jul 2019 00:53:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562658811; cv=none; d=google.com; s=arc-20160816; b=QeDDEZroO2FneuAh4vua/nk/g7u96U76CDSGl5uXds/HCkf8++Zibpp2Nk4e2w0LKh Ekr31Qn/fmy8WW5MT8sOK434zQEt75wGiPYTfYldWCJgGSoC445pqiQ7Xt88lzqaQOSf YoQqo8rGX1uH8RocSAKrhunqZG4VK+G9TVB/uVlNMdzfau7NwG7EnALe1lhH/lyIfr2Z 2vUp//Hx3mKlZ6LoyQbHrZ8c+CkGjllzKmSoeYiykPm3aZpjh2bbMGhXP67DdA8B1557 J8FuTU2RdkQVFBQjdBsImck3asL5QY8Y7I94cNLdJ5FeqxiaCXNwdgCAZ9U7s9yzPtYn fUiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=ty0ceSlhLSlZJKGDv3kDThADamDPPm/37CRvid7ZnoA=; b=PezAFPB12AOg0Ht8MEUM1O3HgRNg4NGwuc3d+Y8bKEf12jOQUx/QsmR1juL/1gayQV w4AK3wullKH/XuVOmQy8TQLEHYwjk014XNrdofEYuMHtrjfcF4JvAyedl1r/9EXV3IaP fLimu+uD81QNEavs2af034wn1IjP0yWbN6jr3rmwm3IoE1OhPTU903Oqjjli6Y/ZbRBO H/43c6+Uwm9SL6v02Sm+FYJ5omG224R/PbxEPRUC6dsZ86jInhPRMcavVFGo9pr9EZt+ D9xQA6rZSTAySaQt5WItVqnH40LR0OQ9KXbW1pqHgDs7Fxt2hoiDnkAMXsagYGA8n0u+ Vtxg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=eWVcSsFq; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id dc19si5610408ejb.324.2019.07.09.00.53.31 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 09 Jul 2019 00:53:31 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=eWVcSsFq; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:47594 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hkkwM-0008Rw-Nb for patch@linaro.org; Tue, 09 Jul 2019 03:53:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52223) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hkku9-0005rK-Us for qemu-devel@nongnu.org; Tue, 09 Jul 2019 03:51:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hkku8-0001BO-U0 for qemu-devel@nongnu.org; Tue, 09 Jul 2019 03:51:13 -0400 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]:41979) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hkku8-00019N-Nv for qemu-devel@nongnu.org; Tue, 09 Jul 2019 03:51:12 -0400 Received: by mail-pf1-x443.google.com with SMTP id m30so8873280pff.8 for ; Tue, 09 Jul 2019 00:51:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ty0ceSlhLSlZJKGDv3kDThADamDPPm/37CRvid7ZnoA=; b=eWVcSsFq9aLtDqtSBovb1RXNVYi06MIZTx56QqIKqG9j3TY5gU/ZweOs6GXXjFukWQ S4ATp2+8TJg2v/yeVLaAqmvZzSsl+LUM4q8tL0YZgdOLJbSqBN6/Wug6OIHfM/X2brty nKVnwEp9hwJ6Cpx6HNfpTjEseWl6BAQaQxpDlrJDNuXMVYGBPU5WzSPPdOKK+UM3w4ng 4K3dH9yX3uRHet9lQitMSsAzaUAc4KmNkkYlSLBK69aRWO5bEG2zuPA91Ef66acY0i8w iyXTmAOV/4W5dK7usOsv4rIToP+9LJ5E04FyKHN6nhq3/msOFujHkX0KIE0hSU0qAxPY B/hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ty0ceSlhLSlZJKGDv3kDThADamDPPm/37CRvid7ZnoA=; b=Kp43iMVTTJzAqS+ap49HAXowaKGWneYYxLpjQGauVomO8FaPxAR5+ilrSEIofPkLnX G8L5ZPL0vUgiMhz7S5mbmjx3UhvKVJJJCvly3+Xmqk+5A38jgpQ15UYaD+b6VLhx7U5/ eJuvIHjL0o0uc3UCKB91BCb6z2W+bL0/unku7+XZz1B5caQOu0uuRlwPAsh/Ddnfz1fj kZeINUBNRr7gXY0hnC+LohGCHcho4tyG6f1fZY2u9L4M+YbF1mJlPA0kE0q09xyx8Z4A 5pzvZ4IjOrkiChoOmwOmJuH9O/xaRTZs5ZSygZnlB9owrDI77LWcnyhqaapjTY+Opr3k HyFw== X-Gm-Message-State: APjAAAUe1K0OwZjE5TLxLzuGMsn5bpw1ktMjnQ2A6dfOSnI2/26au0/A lVwncFhx+PIe/NUViENGwEyqfwM7nqZwMQ== X-Received: by 2002:a17:90a:24ac:: with SMTP id i41mr30885394pje.124.1562658670711; Tue, 09 Jul 2019 00:51:10 -0700 (PDT) Received: from localhost.localdomain ([172.56.12.212]) by smtp.gmail.com with ESMTPSA id y22sm28237375pfo.39.2019.07.09.00.51.07 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 09 Jul 2019 00:51:10 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Tue, 9 Jul 2019 09:50:42 +0200 Message-Id: <20190709075042.13941-6-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190709075042.13941-1-richard.henderson@linaro.org> References: <20190709075042.13941-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::443 Subject: [Qemu-devel] [PULL 3/3] tcg: Fix expansion of INDEX_op_not_vec X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" This operation can always be emitted, even if we need to fall back to xor. Adjust the assertions to match. Signed-off-by: Richard Henderson --- tcg/tcg-op-vec.c | 6 ++++++ 1 file changed, 6 insertions(+) -- 2.17.1 diff --git a/tcg/tcg-op-vec.c b/tcg/tcg-op-vec.c index c8fdc24f56..6714991bf4 100644 --- a/tcg/tcg-op-vec.c +++ b/tcg/tcg-op-vec.c @@ -90,6 +90,9 @@ bool tcg_can_emit_vecop_list(const TCGOpcode *list, case INDEX_op_bitsel_vec: /* These opcodes are mandatory and should not be listed. */ g_assert_not_reached(); + case INDEX_op_not_vec: + /* These opcodes have generic expansions using the above. */ + g_assert_not_reached(); default: break; } @@ -438,11 +441,14 @@ static bool do_op2(unsigned vece, TCGv_vec r, TCGv_vec a, TCGOpcode opc) void tcg_gen_not_vec(unsigned vece, TCGv_vec r, TCGv_vec a) { + const TCGOpcode *hold_list = tcg_swap_vecop_list(NULL); + if (!TCG_TARGET_HAS_not_vec || !do_op2(vece, r, a, INDEX_op_not_vec)) { TCGv_vec t = tcg_const_ones_vec_matching(r); tcg_gen_xor_vec(0, r, a, t); tcg_temp_free_vec(t); } + tcg_swap_vecop_list(hold_list); } void tcg_gen_neg_vec(unsigned vece, TCGv_vec r, TCGv_vec a)