From patchwork Tue Jul 23 10:35:54 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 169500 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp8704319ilk; Tue, 23 Jul 2019 03:38:12 -0700 (PDT) X-Google-Smtp-Source: APXvYqwFNK3WhibIAHeZ6aT98AWebmUwVD399k+0+HKTg6kkMSuYSORTOZEQidXAOjh/PKRG5DjJ X-Received: by 2002:ac8:37b9:: with SMTP id d54mr53519699qtc.189.1563878292155; Tue, 23 Jul 2019 03:38:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563878292; cv=none; d=google.com; s=arc-20160816; b=HXs69rQQTUfHKksKdsVfNmS8qZH6ehM+DdkJ1s4K6aGm8MuiWcR0vr8fX6Zqez6+J0 C2y5ExGz91b/YP8ZSYrfHAJ6pDdz8PEvYEnivnOEVrn2+x4TGJk9V6yWuZTuWzLwOoIG AXBD/zLL1LlhBMOZU0NBWUsI4meUx7pM60a6xQ0WQkyV8gO1ek85B+fk0cUxPnkgTIgU 7PYFMU231jr3gvDqMibf38BgFAt/iH1L7u6aPGcKweC0TeRd70XdA+SKGBr7f/nIhVm2 7GdpXyd5qBkl6iG1Irt3wnKNxik0DNfEFoZpvWtfg/zWxVEb7RBY5y13MX7rzBFgQV0/ 5PKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=1aB6CS66id195EEgwuQ7Hg3FMvOUuzvHx6tDmNmk8yg=; b=lQQ+AaxLLqBedQ+1n7I0+BckhT+NAEIPUjQkp6HiHJiZdK0fgCWRrvJMUv4pL8Qvg3 HkP9Cl9B+ejRrr2SGh6SyembJkNyGYAWL9CpEZZ6UleOpZE0vO4I68T8VbmrbR7NOy1b q4g75gdJ79C2nVN083a5yvnE+rY5MNxPqzQYsLbYLWW8RlwkQ0wUNbJhKd9+Rkh1BcoY mHYyxDX/A06UPVqVDAEX6s9itSe8218wdK6mA5xMLyRKInTOMUTjpcY8ThCDv3bLNGho F+T4ytrD0yN8+vyXdrm1FdAHyeRz72i5NW7ToEkvLeYzENNWkiLen7JYkWNoyzl0fhtp HGMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=RVy5HDBx; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id t5si23933875qkm.234.2019.07.23.03.38.12 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 23 Jul 2019 03:38:12 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=RVy5HDBx; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:41024 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpsBP-0004wa-9K for patch@linaro.org; Tue, 23 Jul 2019 06:38:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37801) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hps9c-0005nZ-Fk for qemu-devel@nongnu.org; Tue, 23 Jul 2019 06:36:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hps9b-0007O2-B7 for qemu-devel@nongnu.org; Tue, 23 Jul 2019 06:36:20 -0400 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]:37964) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hps9b-0007N7-4F for qemu-devel@nongnu.org; Tue, 23 Jul 2019 06:36:19 -0400 Received: by mail-wr1-x433.google.com with SMTP id g17so42618745wrr.5 for ; Tue, 23 Jul 2019 03:36:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1aB6CS66id195EEgwuQ7Hg3FMvOUuzvHx6tDmNmk8yg=; b=RVy5HDBx8clvfTk+OSqIJLjBqNHGrHLwDUU/Z68nry9MeCD6iJvyb6iGDi12MKEHk3 KgfUUIBzM5wlUKXailBbLSjU1cdJ03NsJSCfg1sWoRpagzihYFI4fm3OcBa5zAqRsMcV XxcvTrJaLLVZbOegToBSBnY7VYm0aii2Gxvamp8Tb1vhW6JhbhuR+82BfRrLaZ14JbN9 rVXKAqPCWzcp5dqCFBR9V3EPjKBo2s8kue/1jCuDFsRcejl1KvyNa2sM8fMFE/w/BwDG UxrQotFQRMp9fp4JiLv8wMbKNaEP+FJnQmGWDSXvUlf/Rek7/E1O1lmgKgvPkEZ+Wkcs sVwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1aB6CS66id195EEgwuQ7Hg3FMvOUuzvHx6tDmNmk8yg=; b=gZxFIWXNFgJbs1bjwib0u9DTAT81Rr89eQc0VD9yabxiMXkwcSByUstcTqfEbITHLr 4eliNmN+0rqlcBnARZixXu391ImIIDTmwIMcKduFinhDzbPJdfs8N5YvfhFTWfl52pCw E0mIbLio5EH/UFsRva4wobaK72P6vCv4I1VmWthFjt0RcKxwkw7uFmrZsaSZL7YMakpq jPudt3il0Iwuk770CMJtNQep4S5oFmNCDKq88NiCk4ZDkLmMkf+kRhXZWPdVv/L8yl8O SIyCBJt+C6kwoDGkkq7T2guyTxxVBXW+0+ldgXIiyj3eTeXDeZ0UTHe63QdDcJUA6Bcz Z9dA== X-Gm-Message-State: APjAAAV3Pazzey6+FJR3bAylAYvAmqyEvrDSo2zXzZL7Jz1p2ZyjyTHL 7Eq1XtV2jCDvq0BsJ4K9rdnKIw== X-Received: by 2002:a5d:56d0:: with SMTP id m16mr77613211wrw.276.1563878178022; Tue, 23 Jul 2019 03:36:18 -0700 (PDT) Received: from zen.linaroharston ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id r12sm50472704wrt.95.2019.07.23.03.36.13 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 23 Jul 2019 03:36:14 -0700 (PDT) Received: from zen.linaroharston. (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id C65861FF92; Tue, 23 Jul 2019 11:36:12 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org Date: Tue, 23 Jul 2019 11:35:54 +0100 Message-Id: <20190723103612.5600-6-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190723103612.5600-1-alex.bennee@linaro.org> References: <20190723103612.5600-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::433 Subject: [Qemu-devel] [PULL 05/23] tests/docker: Install Ubuntu images noninteractively X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Alex_Benn=C3=A9e?= , Richard Henderson , Fam Zheng , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé We correctly use the DEBIAN_FRONTEND environment variable on the Debian images, but forgot the Ubuntu ones are based on it. Since building docker images is not interactive, we need to inform the APT tools about it using the DEBIAN_FRONTEND environment variable (we already use it on our Debian images). This fixes: $ make docker-image-ubuntu V=1 [...] Setting up tzdata (2019b-0ubuntu0.19.04) ... debconf: unable to initialize frontend: Dialog debconf: (TERM is not set, so the dialog frontend is not usable.) debconf: falling back to frontend: Readline Configuring tzdata ------------------ Please select the geographic area in which you live. Subsequent configuration questions will narrow this down by presenting a list of cities, representing the time zones in which they are located. 1. Africa 4. Australia 7. Atlantic 10. Pacific 13. Etc 2. America 5. Arctic 8. Europe 11. SystemV 3. Antarctica 6. Asia 9. Indian 12. US Geographic area: 12 [HANG] Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20190711124805.26476-1-philmd@redhat.com> Signed-off-by: Alex Bennée -- 2.20.1 diff --git a/tests/docker/dockerfiles/ubuntu.docker b/tests/docker/dockerfiles/ubuntu.docker index 2500ec84b6f..a4f601395c8 100644 --- a/tests/docker/dockerfiles/ubuntu.docker +++ b/tests/docker/dockerfiles/ubuntu.docker @@ -66,6 +66,6 @@ ENV PACKAGES flex bison \ texinfo \ xfslibs-dev RUN apt-get update && \ - apt-get -y install $PACKAGES + DEBIAN_FRONTEND=noninteractive apt-get -y install $PACKAGES RUN dpkg -l $PACKAGES | sort > /packages.txt ENV FEATURES clang pyyaml sdl2 diff --git a/tests/docker/dockerfiles/ubuntu1804.docker b/tests/docker/dockerfiles/ubuntu1804.docker index 0bb8088658d..44bbf0f77ae 100644 --- a/tests/docker/dockerfiles/ubuntu1804.docker +++ b/tests/docker/dockerfiles/ubuntu1804.docker @@ -53,6 +53,6 @@ ENV PACKAGES flex bison \ texinfo \ xfslibs-dev RUN apt-get update && \ - apt-get -y install $PACKAGES + DEBIAN_FRONTEND=noninteractive apt-get -y install $PACKAGES RUN dpkg -l $PACKAGES | sort > /packages.txt ENV FEATURES clang pyyaml sdl2