From patchwork Sat Aug 17 07:36:19 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yoshinori Sato X-Patchwork-Id: 171527 Delivered-To: patch@linaro.org Received: by 2002:a92:d204:0:0:0:0:0 with SMTP id y4csp415583ily; Sat, 17 Aug 2019 00:37:56 -0700 (PDT) X-Google-Smtp-Source: APXvYqxYx6bV04YDXVTQqHxifVhPdNLqxYjWGAerKtpYSN/rSlHKfZry2AUnIkfCyPV6594eRzUF X-Received: by 2002:ae9:f801:: with SMTP id x1mr11132157qkh.242.1566027476154; Sat, 17 Aug 2019 00:37:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566027476; cv=none; d=google.com; s=arc-20160816; b=czf4QJeN2eQ6iqpxTmJYAxUaOiN+/RljVnY+Om1nbWOhdG44wYlrWnZrmNApYC8/og o3sHQ1+p9NBSasFEAwsLMrW3c4zr1SLRokiPwcch0qs7PT+xW30G4QzdkYZDoIDjZyDP kmuaBJyO479+KtyXefYuyM4NWRugx6x/z90XS07YBq+BbZLMeUJAEnSVzTFeG9PQB4D3 eZwQErKiuK0BADGjkTvaOEFhpR4hQLdD5dMvRsSTGv79FZMOUWjHRk1tCH3V9dvSQkOC SA2UKbCqce/Ju3SqI7TQg+FrXsVKqXPVhoCBfTGnJtf3NatxgTX0+yV5HmYen5UNuIgY nJ7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from; bh=VNx9Ajp99J+k2CxoHG8xzhuyro4Mwnnw0aZqs91u9dM=; b=bPgrEa1Q8kIMwv2Uw/feIcPCUoOPUiV9aHZrZXxg9OaE1VL7bDMHVooyOUJMw/cTO0 TLK2o9b3bGe4KB2sFH7rUbRTTw/E7na5iLLt/ci7HIBptEa3oUVcPertKr5IeIzrFVT0 QnoWKs6TVi2//WteJx4jP0GrrrT7nE4YWjenoIxdXZFEdIAQe5/qf3LdFY8Ps80ZK3nO IY7D65bzXzyosRgfvq10GqTlGUqGpZ/nPz7GuyTPcixAJaKIzW7dsSEzvZRLa5q5SqqT Rns7K1Pj8usN9ijhMkD3Iq62LvifkvObO0ASJl6BI6yEiahCyLUoaVxdCKnTJqLg1jp7 rvZQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id r4si5157148qta.256.2019.08.17.00.37.56 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 17 Aug 2019 00:37:56 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1]:34630 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hytHf-0006wF-5q for patch@linaro.org; Sat, 17 Aug 2019 03:37:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41022) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hytGU-0006pk-TG for qemu-devel@nongnu.org; Sat, 17 Aug 2019 03:36:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hytGS-0006Zc-IA for qemu-devel@nongnu.org; Sat, 17 Aug 2019 03:36:42 -0400 Received: from mail03.asahi-net.or.jp ([202.224.55.15]:47820) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hytGS-0006Xp-8X for qemu-devel@nongnu.org; Sat, 17 Aug 2019 03:36:40 -0400 Received: from h61-195-96-97.vps.ablenet.jp (h61-195-96-97.ablenetvps.ne.jp [61.195.96.97]) (Authenticated sender: PQ4Y-STU) by mail03.asahi-net.or.jp (Postfix) with ESMTPA id 941085723A; Sat, 17 Aug 2019 16:36:38 +0900 (JST) Received: from yo-satoh-debian.localdomain (ZM005235.ppp.dion.ne.jp [222.8.5.235]) by h61-195-96-97.vps.ablenet.jp (Postfix) with ESMTPSA id 517AC240085; Sat, 17 Aug 2019 16:36:38 +0900 (JST) From: Yoshinori Sato To: qemu-devel@nongnu.org Date: Sat, 17 Aug 2019 16:36:19 +0900 Message-Id: <20190817073628.94473-14-ysato@users.sourceforge.jp> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190817073628.94473-1-ysato@users.sourceforge.jp> References: <20190817073628.94473-1-ysato@users.sourceforge.jp> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 202.224.55.15 Subject: [Qemu-devel] [PATCH v23 13/22] target/rx: Dump bytes for each insn during disassembly X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, imammedo@redhat.com, Richard Henderson , Yoshinori Sato , philmd@redhat.com Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson There are so many different forms of each RX instruction that it will be very useful to be able to look at the bytes to see on which path a bug may lie. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Yoshinori Sato Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49044-24-ysato@users.sourceforge.jp> Tested-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/rx/disas.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) -- 2.11.0 diff --git a/target/rx/disas.c b/target/rx/disas.c index 5a32a87534..d73b53db44 100644 --- a/target/rx/disas.c +++ b/target/rx/disas.c @@ -102,7 +102,21 @@ static int bdsp_s(DisasContext *ctx, int d) /* Include the auto-generated decoder. */ #include "decode.inc.c" -#define prt(...) (ctx->dis->fprintf_func)((ctx->dis->stream), __VA_ARGS__) +static void dump_bytes(DisasContext *ctx) +{ + int i, len = ctx->len; + + for (i = 0; i < len; ++i) { + ctx->dis->fprintf_func(ctx->dis->stream, "%02x ", ctx->bytes[i]); + } + ctx->dis->fprintf_func(ctx->dis->stream, "%*c", (8 - i) * 3, '\t'); +} + +#define prt(...) \ + do { \ + dump_bytes(ctx); \ + ctx->dis->fprintf_func(ctx->dis->stream, __VA_ARGS__); \ + } while (0) #define RX_MEMORY_BYTE 0 #define RX_MEMORY_WORD 1